dd-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3344 WIP for rinsepump implementations

LDT3344 updated rinsepump to work for beta1 and beta2

There is a standardized level checking logic proposed , please check with Noe

There is a standardized level checking logic proposed , please check with Noe

please use FPGA version function to initialize or handle HW version

please use FPGA version function to initialize or handle HW version

read the FPGA ID and initialize it

read the FPGA ID and initialize it

LDT-3552 updated the array of the DD valves structure

remove #if 1 and add a TODO with this comment

remove #if 1 and add a TODO with this comment

Yes define registers for all variants without #if 1 and mark a TODO for removal later.

Yes define registers for all variants without #if 1 and mark a TODO for removal later.

I suspect this is temporary. If so, just add a TODO comment to restore later.

I suspect this is temporary. If so, just add a TODO comment to restore later.

Only 1 return per function.

Only 1 return per function.

If result is U08, why are we returning U16?

If result is U08, why are we returning U16?

Should just be one return statement in function. Set a local variable where you have returns, remove the returns, and then just return the local variable at the end of function (like it was before).

Should just be one return statement in function. Set a local variable where you have returns, remove the returns, and then just return the local variable at the end of function (like it was before).

Only 1 return statement per function.

Only 1 return statement per function.

Fix alignment of all of the | separators.

Fix alignment of all of the | separators.

This table should be sorted, so this row needs to be moved up now.

This table should be sorted, so this row needs to be moved up now.

Fix alignment.

Fix alignment.

Why remove these functions. All static functions should be prototyped up here.

Why remove these functions. All static functions should be prototyped up here.

S in status should be capitalized.

S in status should be capitalized.

Any reason why pwmInCount can't just be a U32?

Any reason why pwmInCount can't just be a U32?

Do we really need a start state? Can't we just start in off state.

Do we really need a start state? Can't we just start in off state.

Add detail for alarm.

Add detail for alarm.

Remove extra spaces before =.

Remove extra spaces before =.

Don't need #define for zero.

Don't need #define for zero.

Looks like publish function moved to monitor (priority task). I actually don't think publish function should have moved, but if we move it we need to change interval timing here.

Looks like publish function moved to monitor (priority task). I actually don't think publish function should have moved, but if we move it we need to change interval timing here.

I would consider leaving publish here. Monitor is called from priority task. CAN publishing happens in general task.

I would consider leaving publish here. Monitor is called from priority task. CAN publishing happens in general task.

Remove blank line.

Remove blank line.

We should be a little more descriptive in brief here. Describe calculation of pump speed, monitoring for pump speed alarms and publishing pump data.

We should be a little more descriptive in brief here. Describe calculation of pump speed, monitoring for pump speed alarms and publishing pump data.

I think we can say none for Outputs.

I think we can say none for Outputs.

I don't see an alarm triggered in this function.

I don't see an alarm triggered in this function.

Remove extra blank line.

Remove extra blank line.