Activity dd-firmware/

11 hrs ago

Michael Garthwaite

Merge branch 'staging' into LDT-3372-v1-conductivity-fixes

11 hrs ago

Michael Garthwaite

More
e861acd
changed 0 files
develop

Merge branch 'LDT-3372-v1-conductivity-fixes' into develop

11 hrs ago

Michael Garthwaite

added

11 hrs ago

Michael Garthwaite

removed check. the check now happens on before the get.

11 hrs ago

Michael Garthwaite

removed check. the check now happens on before the get.

11 hrs ago

Michael Garthwaite

fixed

11 hrs ago

Michael Garthwaite

added. DD will now fault

11 hrs ago

Michael Garthwaite

fixed.

11 hrs ago

Michael Garthwaite

fixed

11 hrs ago

Michael Garthwaite

updated.

11 hrs ago

Michael Garthwaite

More
72de2cf
changed 5 files
LDT-3372-v1-conductivity-fixes, develop LEAHI-DD-FIRMWARE-LDT-3372-2

LDT-3372: code review comments.

- -22
- +19
/firmware/App/Drivers/ConductivityTeensy.c
- History
- Source
- Diff
/firmware/App/.../ConductivityTeensy.c
- -18
- +1
/firmware/App/Drivers/ConductivityTeensy.h
- History
- Source
- Diff
/firmware/App/.../ConductivityTeensy.h
- -6
- +23
/firmware/App/Monitors/Conductivity.c
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.c
- -3
- +1
/firmware/App/Monitors/Conductivity.h
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.h
- -3
- +13
/firmware/App/Monitors/Temperature.c
- History
- Source
- Diff
/firmware/App/Monitors/Temperature.c

12 hrs ago

Dara Navaei

More
f27380d
changed 1 file
develop

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

12 hrs ago

Michael Garthwaite

More
d8f08bb
changed 0 files
develop

Merge branch 'LDT-3372-v1-conductivity-fixes' into develop

13 hrs ago

Michael Garthwaite

More
Re: LEAHI-DD-FIRMWARE-LDT-3603-1
commented on review

Yes since you're not using the return value in execOpModes()

15 hrs ago

Vendor - TEL - Sameer Poyil

More
4886ecf
changed 1 file
LDT-2004-dialysate-composition-fix-merge--issue---dd

LDT-2004 Dry bicart fixing merge issue

- -1
- +0
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

15 hrs ago

Raghu Kallala

More
9d35153
changed 1 file
LDT-3603-ability-to-set-operation-sub-mo LEAHI-DD-FIRMWARE-LDT-3603-1

LDT-3603 updated comment wording

- -1
- +1
/firmware/App/Modes/FPModes/FPOperationModes.c
- History
- Source
- Diff
/firmware/App/.../FPModes/FPOperationModes.c

15 hrs ago

Raghu Kallala

More
cb8619f
changed 11 files
LDT-3603-ability-to-set-operation-sub-mo LEAHI-DD-FIRMWARE-LDT-3603-1

LDT-3603 initial draft for FP set operation sub mode

- -0
- +88
/firmware/App/Modes/FPModes/FPOperationModes.c
- History
- Source
- Diff
/firmware/App/.../FPModes/FPOperationModes.c
- -0
- +2
/firmware/App/Modes/FPModes/FPOperationModes.h
- History
- Source
- Diff
/firmware/App/.../FPModes/FPOperationModes.h
- -0
- +35
/firmware/App/Modes/FPModes/ModeGenPermeate.c
- History
- Source
- Diff
/firmware/App/.../FPModes/ModeGenPermeate.c
- -1
- +1
/firmware/App/Modes/FPModes/ModeGenPermeate.h
- History
- Source
- Diff
/firmware/App/.../FPModes/ModeGenPermeate.h
- -0
- +37
/firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.c
- History
- Source
- Diff
/firmware/App/.../ModeGenPermeateDefeatured.c
- -1
- +1
/firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.h
- History
- Source
- Diff
/firmware/App/.../ModeGenPermeateDefeatured.h
- -0
- +62
/firmware/App/Modes/FPModes/ModePreGenPermeate.c
- History
- Source
- Diff
/firmware/App/.../ModePreGenPermeate.c
- -7
- +8
/firmware/App/Modes/FPModes/ModePreGenPermeate.h
- History
- Source
- Diff
/firmware/App/.../ModePreGenPermeate.h
- -0
- +41
/firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.c
- History
- Source
- Diff
/firmware/.../ModePreGenPermeateDefeatured.c
- -1
- +1
/firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.h
- History
- Source
- Diff
/firmware/.../ModePreGenPermeateDefeatured.h
- -0
- +1
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

17 hrs ago

Vendor - TEL - Sameer Poyil

More
ea1a521
changed 1 file
LDT-2004-dialysate-composition-fix-merge--issue---dd

LDT-2004 Dry bicart fixing merge issue

- -5
- +6
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c

9:58 pm

chaithra bs <ven.cburudugatta@diality.com>

More
559b305
changed 0 files
LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test : Added testcases for FlowSensor and Safetyshutdown file

7:52 pm

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

All comments should start with capital letter

7:37 pm

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

comment alignment issue

7:37 pm

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

it should be mentioned what function is used for calculating the equation.

7:30 pm

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

above comment applicable here .

7:29 pm

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

if sensor id is not in the finite state enum value , it return 0 and here it calculate for P9

7:21 pm

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

parameter is sensorId, not sensor

5:12 pm

Dara Navaei

More
24303ae
changed 1 file
LDT-2004-dialysate-composition-fix-merge--issue---dd, LDT-2004-v2-conductivity-sensors and 5 more LEAHI-DD-FIRMWARE-LDT-2004-4

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

5:12 pm

Dara Navaei

More
b604744
changed 1 file
LDT-2004-dialysate-composition-fix-merge--issue---dd, LDT-2004-v2-conductivity-sensors and 5 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/firmware/App/Monitors/BloodLeak.c
- History
- Source
- Diff
/firmware/App/Monitors/BloodLeak.c

5:10 pm

Dara Navaei

5:10 pm

Dara Navaei

More
b6e4ccd
changed 0 files
LDT-2004-dialysate-composition-fix-merge--issue---dd, LDT-2004-v2-conductivity-sensors and 5 more

Merged LDT-3605

4:36 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

More
LEAHI-DD-FIRMWARE-LDT-3605-1
finished reviewing

dd-firmware

Stats

Commits this week: 66

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

Michael Garthwaite

Dara Navaei

Michael Garthwaite

Michael Garthwaite

Vendor - TEL - Sameer Poyil

Raghu Kallala

Raghu Kallala

Vendor - TEL - Sameer Poyil

chaithra bs <ven.cburudugatta@diality.com>

Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

Vendor - TEL - Jashwant Gantyada and Sean Nash