dd-firmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3103 merget latest staging

    • -26
    • +78
    /firmware/App/Modes/ModeGenDialysate.c
    • -2
    • +3
    /firmware/App/Modes/ModeGenDialysate.h
LDT-3103 implemented new pump changes

    • -8
    • +25
    /firmware/App/Modes/ModeGenDialysate.c
LDT-3218: fp tuning. WIP

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode? Sean NashMichael Garthwaite please confirm

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode?
Sean NashMichael Garthwaite please confirm

LDT-3603 converted all signal functions to void functions

    • -6
    • +2
    /firmware/App/Modes/FPModes/ModeGenPermeate.c
    • -1
    • +1
    /firmware/App/Modes/FPModes/ModeGenPermeate.h
I was thinking we could return BOOL to check if the request was successful, added it. But as you clarified the dialin response will only confirm the delivery of message successfully, I can change ...

I was thinking we could return BOOL to check if the request was successful, added it.

But as you clarified the dialin response will only confirm the delivery of message successfully, I can change all these signal functions to void
Thanks!

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Merge branch 'LDT-3372-v1-conductivity-fixes' into develop

WIP on develop

LDT-3372: fixed error on release builds

Merge branch 'staging' into LDT-3372-add-ability-to-override-teensy

Merge branch 'staging' into LDT-3218-update-iofp-permeate-target-flow

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

Merge branch 'staging' into LDT-3372-v1-conductivity-fixes

Merge branch 'LDT-3372-v1-conductivity-fixes' into develop

added

added

removed check. the check now happens on before the get.

removed check. the check now happens on before the get.

removed check. the check now happens on before the get.

removed check. the check now happens on before the get.

fixed

fixed

added. DD will now fault

added. DD will now fault

fixed.

fixed.

fixed

fixed

updated.

updated.

LDT-3372: code review comments.

    • -6
    • +23
    /firmware/App/Monitors/Conductivity.c
    • -3
    • +13
    /firmware/App/Monitors/Temperature.c
Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Merge branch 'LDT-3372-v1-conductivity-fixes' into develop

Yes since you're not using the return value in execOpModes()

Yes since you're not using the return value in execOpModes()

LDT-2004 Dry bicart fixing merge issue

LDT-3603 updated comment wording

    • -1
    • +1
    /firmware/App/Modes/FPModes/FPOperationModes.c
LDT-3603 initial draft for FP set operation sub mode

    • -0
    • +88
    /firmware/App/Modes/FPModes/FPOperationModes.c
    • -0
    • +2
    /firmware/App/Modes/FPModes/FPOperationModes.h
    • -0
    • +35
    /firmware/App/Modes/FPModes/ModeGenPermeate.c
    • -1
    • +1
    /firmware/App/Modes/FPModes/ModeGenPermeate.h