dd-firmware

Clone Tools

Stats

Commits this week: 66
Total Committers: 15
Last Commit: 14:29
Commits this week: 66

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
8 hrs ago

Michael Garthwaite

LDT-3372: code review comments

Options
    • -2
    • +0
    /firmware/App/Drivers/ConductivityTeensy.c
8 hrs ago

Michael Garthwaite

fixed.

fixed.

8 hrs ago

Michael Garthwaite

fixed.

fixed.

8 hrs ago

Michael Garthwaite

fixed.

fixed.

8 hrs ago

Michael Garthwaite

LDT-3372: code review comments

Options
    • -1
    • +1
    /firmware/App/Monitors/Conductivity.c
8 hrs ago

Michael Garthwaite

J1 - P9 J2 - P18 J3 - D17 J4 - D27 J5 - D29 J6 - D43 No sensor - D74 (redundant, so we should be able to live without it in short run)

J1 - P9
J2 - P18
J3 - D17
J4 - D27
J5 - D29
J6 - D43
No sensor - D74 (redundant, so we should be able to live without it in short run)

8 hrs ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

8 hrs ago

Michael Garthwaite

build switch fixes will be completed in the v2 conductivity sensor branch. Per what was agreed on back in November: J1 - P9 J2 - P18 J3 - D17 J4 - D27 J5 - D29 J6 - D43 No sensor - D74 (redundant,...

build switch fixes will be completed in the v2 conductivity sensor branch. Per what was agreed on back in November:

J1 - P9
J2 - P18
J3 - D17
J4 - D27
J5 - D29
J6 - D43
No sensor - D74 (redundant, so we should be able to live without it in short run)

8 hrs ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

8 hrs ago

Michael Garthwaite

LDT-3372: code review comments

Options
    • -1
    • +0
    /firmware/App/Monitors/Conductivity.h
8 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

8 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

8 hrs ago

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

8 hrs ago

Sean Nash

Same question.

Same question.

8 hrs ago

Sean Nash

Why is D74 not a Teensy? And I though you were getting ride of this build switch and using test config (run time switch)?

Why is D74 not a Teensy? And I though you were getting ride of this build switch and using test config (run time switch)?

8 hrs ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

8 hrs ago

Vendor - TEL - Jashwant Gantyada

LDT-3103 merget latest staging

Options
    • -2
    • +2
    /firmware/App/Controllers/BalancingChamber.c
    • -1
    • +1
    /firmware/App/Controllers/BalancingChamber.h
    • -2
    • +3
    /firmware/App/Controllers/DialysatePumps.h
    • -7
    • +8
    /firmware/App/DDCommon.h
    • -26
    • +78
    /firmware/App/Modes/ModeGenDialysate.c
    • -2
    • +3
    /firmware/App/Modes/ModeGenDialysate.h
8 hrs ago

Vendor - TEL - Jashwant Gantyada

LDT-3103 implemented new pump changes

Options
    • -2
    • +2
    /firmware/App/Controllers/BalancingChamber.c
    • -2
    • +2
    /firmware/App/Controllers/BalancingChamber.h
    • -27
    • +129
    /firmware/App/Controllers/DialysatePumps.c
    • -13
    • +6
    /firmware/App/Controllers/DialysatePumps.h
    • -8
    • +25
    /firmware/App/Modes/ModeGenDialysate.c
9 hrs ago

Michael Garthwaite

LDT-3218: fp tuning. WIP

Options
    • -4
    • +4
    /firmware/App/Controllers/ROPump.c
9 hrs ago

Raghu Kallala

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode? Sean NashMichael Garthwaite please confirm

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode?
Sean NashMichael Garthwaite please confirm

9 hrs ago

Raghu Kallala

LDT-3603 converted all signal functions to void functions

Options
    • -6
    • +2
    /firmware/App/Modes/FPModes/ModeGenPermeate.c
    • -1
    • +1
    /firmware/App/Modes/FPModes/ModeGenPermeate.h
    • -6
    • +2
    /firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.c
    • -1
    • +1
    /firmware/App/Modes/FPModes/ModeGenPermeateDefeatured.h
    • -10
    • +2
    /firmware/App/Modes/FPModes/ModePreGenPermeate.c
    • -1
    • +1
    /firmware/App/Modes/FPModes/ModePreGenPermeate.h
    • -6
    • +2
    /firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.c
    • -1
    • +1
    /firmware/App/Modes/FPModes/ModePreGenPermeateDefeatured.h
10 hrs ago

Raghu Kallala

I was thinking we could return BOOL to check if the request was successful, added it. But as you clarified the dialin response will only confirm the delivery of message successfully, I can change ...

I was thinking we could return BOOL to check if the request was successful, added it.

But as you clarified the dialin response will only confirm the delivery of message successfully, I can change all these signal functions to void
Thanks!

10 hrs ago

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
10 hrs ago

Michael Garthwaite

Merge branch 'LDT-3372-v1-conductivity-fixes' into develop

Options
10 hrs ago

Michael Garthwaite

WIP on develop

LDT-3372: fixed error on release builds

Options
    • -1
    • +1
    /firmware/App/Monitors/Conductivity.c
10 hrs ago

Michael Garthwaite

Merge branch 'staging' into LDT-3372-add-ability-to-override-teensy

Options
10 hrs ago

Michael Garthwaite

Merge branch 'staging' into LDT-3218-update-iofp-permeate-target-flow

Options
10 hrs ago

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
10 hrs ago

Michael Garthwaite

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
10 hrs ago

Michael Garthwaite

Merge branch 'staging' into LDT-3372-v1-conductivity-fixes

Options