Activity dd-firmware/

Tree
Accordion

Stats

Commits this week: 49

Total Committers:	16
Last Commit:	13:56
Commits this week:	49

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Friday 06 Mar

2:29 pm

Michael Garthwaite

More
a5d119a
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 34 more LEAHI-DD-FIRMWARE-LDT-3372-2

LDT-3372: code review comments

- -1
- +0
/firmware/App/Monitors/Conductivity.c
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.c

2:29 pm

Michael Garthwaite

More
2483040
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 28 more

LDT-3750 cherry-picked a5d119a

- -2
- +10
/firmware/App/Monitors/Conductivity.c
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.c

2:25 pm

Michael Garthwaite

fixed

fixed

2:24 pm

Michael Garthwaite

fixed

fixed

2:24 pm

Michael Garthwaite

fixed.

fixed.

2:24 pm

Michael Garthwaite

More
e7d048b
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 34 more LEAHI-DD-FIRMWARE-LDT-3372-2

LDT-3372: code review comments

- -2
- +0
/firmware/App/Drivers/ConductivityTeensy.c
- History
- Source
- Diff
/firmware/App/.../ConductivityTeensy.c

2:24 pm

Michael Garthwaite

More
a775888
changed 0 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 28 more

LDT-3372: code review comments e7d048b

2:23 pm

Michael Garthwaite

fixed.

fixed.

2:23 pm

Michael Garthwaite

fixed.

fixed.

2:23 pm

Michael Garthwaite

fixed.

fixed.

2:22 pm

Michael Garthwaite

More
f87a631
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 34 more LEAHI-DD-FIRMWARE-LDT-3372-2

LDT-3372: code review comments

- -1
- +1
/firmware/App/Monitors/Conductivity.c
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.c

2:22 pm

Michael Garthwaite

More
17bccac
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 28 more

LDT-3750 cherry-picked f87a631

- -2
- +10
/firmware/App/Monitors/Conductivity.c
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.c

2:21 pm

Michael Garthwaite

J1 - P9 J2 - P18 J3 - D17 J4 - D27 J5 - D29 J6 - D43 No sensor - D74 (redundant, so we should be able to live without it in short run)

J1 - P9
J2 - P18
J3 - D17
J4 - D27
J5 - D29
J6 - D43
No sensor - D74 (redundant, so we should be able to live without it in short run)

2:20 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

Remove extra blank line.

Remove extra blank line.

2:20 pm

Michael Garthwaite

build switch fixes will be completed in the v2 conductivity sensor branch. Per what was agreed on back in November: J1 - P9 J2 - P18 J3 - D17 J4 - D27 J5 - D29 J6 - D43 No sensor - D74 (redundant,...

build switch fixes will be completed in the v2 conductivity sensor branch. Per what was agreed on back in November:

J1 - P9
J2 - P18
J3 - D17
J4 - D27
J5 - D29
J6 - D43
No sensor - D74 (redundant, so we should be able to live without it in short run)

2:20 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

Remove extra blank line.

Remove extra blank line.

2:18 pm

Michael Garthwaite

More
d603d5c
changed 0 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 28 more

LDT-3372: code review comments b48cd32

2:18 pm

Michael Garthwaite

More
b48cd32
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 34 more LEAHI-DD-FIRMWARE-LDT-3372-2

LDT-3372: code review comments

- -1
- +0
/firmware/App/Monitors/Conductivity.h
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.h

2:18 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

Remove blank line.

Remove blank line.

2:17 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

Remove blank line.

Remove blank line.

2:17 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

Add blank line after declarations.

Add blank line after declarations.

2:17 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

Same question.

Same question.

2:16 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

Why is D74 not a Teensy? And I though you were getting ride of this build switch and using test config (run time switch)?

Why is D74 not a Teensy? And I though you were getting ride of this build switch and using test config (run time switch)?

2:14 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

Remove extra blank line.

Remove extra blank line.

2:13 pm

Vendor - TEL - Jashwant Gantyada

More
ff8dde1
changed 7 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 28 more LEAHI-DD-FIRMWARE-LDT-3750-3

LDT-3103 merge latest staging 3/18/2026 corrected the merge commit ID 97eba3d

- -22
- +43
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -1
- +1
/firmware/App/Controllers/BalancingChamber.h
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.h
- -1
- +0
/firmware/App/Controllers/DialysatePumps.c
- History
- Source
- Diff
/firmware/App/.../DialysatePumps.c
- -2
- +3
/firmware/App/Controllers/DialysatePumps.h
- History
- Source
- Diff
/firmware/App/.../DialysatePumps.h
- -7
- +8
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h
- -26
- +78
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c
- -2
- +3
/firmware/App/Modes/ModeGenDialysate.h
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.h

2:13 pm

Vendor - TEL - Jashwant Gantyada

More
97eba3d
changed 6 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 32 more LEAHI-DD-FIRMWARE-LDT-3103-1

LDT-3103 merget latest staging

- -2
- +2
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -1
- +1
/firmware/App/Controllers/BalancingChamber.h
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.h
- -2
- +3
/firmware/App/Controllers/DialysatePumps.h
- History
- Source
- Diff
/firmware/App/.../DialysatePumps.h
- -7
- +8
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h
- -26
- +78
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c
- -2
- +3
/firmware/App/Modes/ModeGenDialysate.h
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.h

1:51 pm

Vendor - TEL - Jashwant Gantyada

More
ac5e52d
changed 5 files
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 34 more LEAHI-DD-FIRMWARE-LDT-3103-1

LDT-3103 implemented new pump changes

- -2
- +2
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -2
- +2
/firmware/App/Controllers/BalancingChamber.h
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.h
- -27
- +129
/firmware/App/Controllers/DialysatePumps.c
- History
- Source
- Diff
/firmware/App/.../DialysatePumps.c
- -13
- +6
/firmware/App/Controllers/DialysatePumps.h
- History
- Source
- Diff
/firmware/App/.../DialysatePumps.h
- -8
- +25
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

1:51 pm

Vendor - TEL - Jashwant Gantyada

More
7b8aea6
changed 1 file
LDT-1195-dd-is-balancing-chamber-switching, LDT-1477-ultrafiltration---dd---04-dev-- and 28 more

LDT-3750 cherry-picked ac5e52d

- -0
- +1
/firmware/App/Controllers/DialysatePumps.c
- History
- Source
- Diff
/firmware/App/.../DialysatePumps.c

1:33 pm

Michael Garthwaite

More
014d552
changed 1 file
LDT-2004-dialysate-composition-bicarb-mixing-closed-loop--dd, LDT-2004-dialysate-composition-closed-loop--dd, develop

LDT-3218: fp tuning. WIP

- -4
- +4
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c

12:47 pm

Raghu Kallala

More
Re: LEAHI-DD-FIRMWARE-LDT-3603-1
commented on review

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode? Sean NashMichael Garthwaite please confirm

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode?
Sean Nash Michael Garthwaite please confirm

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-24 16:19 -0700