dd-firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -2
    • +2
    /firmware/App/Modes/ModeGenDialysate.c
    • -2
    • +2
    /firmware/App/Modes/ModeGenDialysate.h
LDT-3103 resolved merge conflicts

    • -6
    • +27
    /firmware/App/Modes/ModeGenDialysate.c
    • -2
    • +3
    /firmware/App/Modes/ModeGenDialysate.h
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
done changed it.

done changed it.

Looks the fields are empty and misaligned. fill as needed.

Looks the fields are empty and misaligned. fill as needed.

LDT-3103 updated fill timeout alarm logic and handling

LDT-1195: Updated function comments and requestBalChamberSwitching

    • -2
    • +0
    /firmware/App/Modes/ModeGenDialysate.c
Remove extra blank line.

Remove extra blank line.

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors? It looks kind of messy having separate handling for each sensor - can we conso...

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors?
It looks kind of messy having separate handling for each sensor - can we consolidate some of this code?

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)? Controller properties already include a min and max field - can we use those?

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)?
Controller properties already include a min and max field - can we use those?

Remove blank line.

Remove blank line.

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test : Added testcases for TemperatureSensors file

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test : Added test cases for Heaters.c file

LDT-3223-dialysate-flow-rate---dd---mode-tel-dev-test : Added test cases for InternalADC.c file

changed

changed

removed from everywhere

removed from everywhere

removed

removed

LDY-3103 addressed code review comments

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -2
    • +2
    /firmware/App/Modes/ModeGenDialysate.c
    • -2
    • +2
    /firmware/App/Modes/ModeGenDialysate.h
Result is a BOOL variable, use FALSE.

Result is a BOOL variable, use FALSE.

updated.

updated.

done.

done.

done

done

changed accordingly.

changed accordingly.