dd-firmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3735: Imported NVM module

    • -0
    • +65
    /firmware/App/Drivers/NVDriver.c
    • -0
    • +26
    /firmware/App/Drivers/NVDriver.h
    • -0
    • +677
    /firmware/App/Services/NVMgmtDD.c
    • -0
    • +39
    /firmware/App/Services/NVMgmtDD.h
    • -0
    • +605
    /firmware/App/Services/NVMsgQ.c
    • -0
    • +109
    /firmware/App/Services/NVMsgQ.h
    • -0
    • +1193
    /firmware/App/Services/NVRecordsDD.c
    • -0
    • +502
    /firmware/App/Services/NVRecordsDD.h
I tried the suggested change and tested. But it did not provide the expected results. If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without...

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.

Not sure these min/max are right here either.

Not sure these min/max are right here either.

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

Remove extra blank lines.

Remove extra blank lines.

Remove this reference (across the file) if the implementation is updated.

Remove this reference (across the file) if the implementation is updated.

Update the deadband timing in the comments.

Update the deadband timing in the comments.

Remove blank line. Also, add comments on the key logics for reference.

Remove blank line. Also, add comments on the key logics for reference.

Default case rise count should be 2, instead of 1?

Default case rise count should be 2, instead of 1?

Now that we go with pressure slope detection logic, we don't want to use pressure-based detection for Low Qd. correct?

Now that we go with pressure slope detection logic, we don't want to use pressure-based detection for Low Qd. correct?

The BC valves not even opened and collecting the spent dial pressure as last previous spent dial pressure may not be correct.

The BC valves not even opened and collecting the spent dial pressure as last previous spent dial pressure may not be correct.

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

LDT-3352 heater control update

    • -6
    • +0
    /firmware/App/Modes/ModeGenDialysate.c
LDT-3522 heater control update

    • -6
    • +0
    /firmware/App/Modes/ModeGenDialysate.c
Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

LDT-3352 resolving merge conflicts

    • -5
    • +216
    /firmware/App/Controllers/Heaters.c
    • -246
    • +14
    /firmware/App/Modes/ModeGenDialysate.c
    • -129
    • +86
    /firmware/App/Monitors/Temperature.c
LDT-3352 heater control update

Done.

Done.

Done

Done

Done.

Done.

LDT-3522 updating heater control

    • -1
    • +210
    /firmware/App/Controllers/Heaters.c
    • -246
    • +14
    /firmware/App/Modes/ModeGenDialysate.c
    • -1
    • +1
    /firmware/App/Modes/ModeGenDialysate.h
    • -126
    • +82
    /firmware/App/Monitors/Temperature.c
Same comment.

Same comment.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Input is d78TempAvgC

Input is d78TempAvgC

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces