dd-firmware

Clone Tools

Stats

Commits this week: 31
Total Committers: 16
Last Commit: 09:33
Commits this week: 31

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 06 Apr
10:49 am

Vendor - TEL - Arpita Srivastava

LDT-3735: Imported NVM module

Options
    • -0
    • +65
    /firmware/App/Drivers/NVDriver.c
    • -0
    • +26
    /firmware/App/Drivers/NVDriver.h
    • -0
    • +677
    /firmware/App/Services/NVMgmtDD.c
    • -0
    • +39
    /firmware/App/Services/NVMgmtDD.h
    • -0
    • +605
    /firmware/App/Services/NVMsgQ.c
    • -0
    • +109
    /firmware/App/Services/NVMsgQ.h
    • -0
    • +1193
    /firmware/App/Services/NVRecordsDD.c
    • -0
    • +502
    /firmware/App/Services/NVRecordsDD.h
10:48 am

Sean Nash

10:46 am

Vendor - TEL - Arpita Srivastava

I tried the suggested change and tested. But it did not provide the expected results. If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without...

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.

10:30 am

Sean Nash

Not sure these min/max are right here either.

Not sure these min/max are right here either.

10:27 am

Sean Nash

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

10:24 am

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

10:23 am

Sean Nash

10:22 am

Vinayakam Mani

Remove this reference (across the file) if the implementation is updated.

Remove this reference (across the file) if the implementation is updated.

10:17 am

Vinayakam Mani

Update the deadband timing in the comments.

Update the deadband timing in the comments.

10:15 am

Vinayakam Mani

Remove blank line. Also, add comments on the key logics for reference.

Remove blank line. Also, add comments on the key logics for reference.

10:08 am

Vinayakam Mani

Default case rise count should be 2, instead of 1?

Default case rise count should be 2, instead of 1?

10:05 am

Vinayakam Mani

Now that we go with pressure slope detection logic, we don't want to use pressure-based detection for Low Qd. correct?

Now that we go with pressure slope detection logic, we don't want to use pressure-based detection for Low Qd. correct?

9:36 am

Vinayakam Mani

The BC valves not even opened and collecting the spent dial pressure as last previous spent dial pressure may not be correct.

The BC valves not even opened and collecting the spent dial pressure as last previous spent dial pressure may not be correct.

Friday 03 Apr
6:21 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
6:20 pm

Vinayakam Mani

LDT-3352 heater control update

Options
    • -0
    • +7
    /firmware/App/Controllers/Heaters.c
    • -6
    • +0
    /firmware/App/Modes/ModeGenDialysate.c
6:16 pm

Vinayakam Mani

LDT-3522 heater control update

Options
    • -0
    • +7
    /firmware/App/Controllers/Heaters.c
    • -6
    • +0
    /firmware/App/Modes/ModeGenDialysate.c
4:20 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
4:19 pm

Vinayakam Mani

LDT-3352 resolving merge conflicts

Options
    • -5
    • +216
    /firmware/App/Controllers/Heaters.c
    • -246
    • +14
    /firmware/App/Modes/ModeGenDialysate.c
    • -129
    • +86
    /firmware/App/Monitors/Temperature.c
    • -1
    • +3
    /firmware/App/Monitors/Temperature.h
    • -0
    • +1
    /firmware/App/Services/Messaging.c
3:58 pm

Vinayakam Mani

LDT-3352 heater control update

Options
    • -4
    • +6
    /firmware/App/Controllers/Heaters.c
    • -4
    • +4
    /firmware/App/Monitors/Temperature.c
3:35 pm

Vinayakam Mani

Done.

Done.

3:34 pm

Vinayakam Mani

Done

Done

3:34 pm

Vinayakam Mani

Done.

Done.

3:17 pm

Vinayakam Mani

LDT-3522 updating heater control

Options
    • -1
    • +210
    /firmware/App/Controllers/Heaters.c
    • -0
    • +1
    /firmware/App/Controllers/Heaters.h
    • -246
    • +14
    /firmware/App/Modes/ModeGenDialysate.c
    • -1
    • +1
    /firmware/App/Modes/ModeGenDialysate.h
    • -126
    • +82
    /firmware/App/Monitors/Temperature.c
    • -1
    • +3
    /firmware/App/Monitors/Temperature.h
    • -0
    • +1
    /firmware/App/Services/Messaging.c
1:20 pm

Sean Nash

Same comment.

Same comment.

1:19 pm

Sean Nash

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

1:14 pm

Sean Nash

Input is d78TempAvgC

Input is d78TempAvgC

1:13 pm

Sean Nash

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

9:33 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
9:32 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /firmware/App/Controllers/RinsePump.c
    • -1
    • +1
    /firmware/App/Controllers/RinsePump.h
    • -2
    • +2
    /firmware/App/Controllers/Valves.c
    • -2
    • +2
    /firmware/App/Controllers/Valves.h
    • -2
    • +2
    /firmware/App/Modes/OperationModes.c
    • -2
    • +2
    /firmware/App/Modes/OperationModes.h
9:31 am

Vendor - TEL - Jashwant Gantyada