dd-firmware

Clone Tools

Stats

Commits this week: 35
Total Committers: 17
Last Commit: 11 Jun
Commits this week: 35

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 11 Jun
2:22 pm

Michael Garthwaite

Merge branch 'LDT-4001-hdf-fw-implementation-2-4' into staging

Options
1:27 pm

Vinayakam Mani and Sean Nash

12:28 pm

Michael Garthwaite

LDT-4001: code review comments

Options
    • -13
    • +5
    /firmware/App/Controllers/SubstitutionPump.c
10:10 am

Michael Garthwaite

LDT-4001: code review comments

Options
    • -4
    • +6
    /firmware/App/Controllers/SubstitutionPump.c
    • -1
    • +1
    /firmware/App/Services/Messaging.c
10:08 am

Michael Garthwaite

fixed thanks

fixed thanks

10:00 am

Sean Nash

Should we change msg ID from speed to rate?

Should we change msg ID from speed to rate?

9:59 am

Michael Garthwaite

fixed thanks

fixed thanks

9:59 am

Michael Garthwaite

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

its a speed in rpm. updated function to convert target rate in ml/min to target speed in rpm and use that for the difference.

9:58 am

Michael Garthwaite

fixed thanks

fixed thanks

9:58 am

Michael Garthwaite

LDT-4001: code review updates

Options
    • -3
    • +3
    /firmware/App/Controllers/SubstitutionPump.c
9:57 am

Michael Garthwaite

this is a set speed in rpm

this is a set speed in rpm

9:57 am

Michael Garthwaite

this is speed in rpm

this is speed in rpm

9:57 am

Michael Garthwaite

fixed thanks

fixed thanks

9:57 am

Michael Garthwaite

fixed thanks

fixed thanks

9:57 am

Michael Garthwaite

fixed thanks

fixed thanks

9:55 am

Michael Garthwaite

LDT-4001: code review comments

Options
    • -13
    • +13
    /firmware/App/Controllers/SubstitutionPump.c
    • -2
    • +2
    /firmware/App/Controllers/SubstitutionPump.h
    • -1
    • +1
    /firmware/App/Services/Messaging.c
    • -3
    • +3
    /firmware/App/Services/TDInterface.c
9:50 am

Michael Garthwaite

LDT-4001: code review updates

Options
    • -3
    • +4
    /firmware/App/Controllers/SubstitutionPump.c
    • -1
    • +1
    /firmware/App/Controllers/SubstitutionPump.h
9:43 am

Sean Nash

Change speed to rate.

Change speed to rate.

9:43 am

Sean Nash

pumpTargetRate

pumpTargetRate

9:43 am

Sean Nash

Change function name to say rate instead of speed

Change function name to say rate instead of speed

9:42 am

Sean Nash

Is this a rate too?

Is this a rate too?

9:42 am

Sean Nash

Is this a rate too?

Is this a rate too?

9:40 am

Sean Nash

Change speed to rate.

Change speed to rate.

9:40 am

Sean Nash

Is currentPumpSpeed actually a rate?

Is currentPumpSpeed actually a rate?

9:38 am

Sean Nash

Is this comment correct? Seems like we're stopping pump if requested to turn off.

Is this comment correct? Seems like we're stopping pump if requested to turn off.

9:36 am

Sean Nash

Is currentPumpSpeed also a rate? If not, we're subtracting a speed from a rate which doesn't make much sense.

Is currentPumpSpeed also a rate? If not, we're subtracting a speed from a rate which doesn't make much sense.

9:34 am

Sean Nash

Align comment.

Align comment.

9:34 am

Sean Nash

Align comment. Change "speed" to "rate in comment too. Also, I don't see you initializing these rates.

Align comment. Change "speed" to "rate in comment too.
Also, I don't see you initializing these rates.

9:33 am

Michael Garthwaite

fixed thanks

fixed thanks

9:30 am

Michael Garthwaite

LDT-4001: code review updates

Options
    • -24
    • +24
    /firmware/App/Controllers/SubstitutionPump.c
    • -2
    • +2
    /firmware/App/Controllers/SubstitutionPump.h