dd-firmware

Clone Tools

Stats

Commits this week: 47
Total Committers: 18
Last Commit: 18 Jun
Commits this week: 47

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 16 Jun
10:55 am

Michael Garthwaite

LDT-4485: code review comments

Options
    • -1
    • +0
    /firmware/App/Controllers/SubstitutionPump.c
10:44 am

Vinayakam Mani

Remove blank line.

Remove blank line.

10:37 am

Michael Garthwaite

LDT-4485: code review comments

Options
    • -2
    • +0
    /firmware/App/Drivers/ConductivitySensors.c
    • -23
    • +38
    /firmware/App/Monitors/Conductivity.c
10:33 am

Vendor - TEL - Sameer Poyil

I will mark it as TODO , so you can close it

I will mark it as TODO , so you can close it

10:29 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
10:24 am

Vinayakam Mani

Update name.

Update name.

10:22 am

Vinayakam Mani

Add a Todo comment to resolve the issue.

Add a Todo comment to resolve the issue.

10:20 am

Vinayakam Mani

Align the indentation.

Align the indentation.

10:17 am

Vinayakam Mani

Align the indentation.

Align the indentation.

10:15 am

Vinayakam Mani

Do we need these comments? delete it if not required.

Do we need these comments? delete it if not required.

10:11 am

Vinayakam Mani

Align the indent

Align the indent

9:06 am

Vendor - TEL - Sameer Poyil

LDT-4409 conductivity sampling filter updates

Options
    • -0
    • +1
    /firmware/App/Controllers/ConcentratePumps.c
    • -1
    • +1
    /firmware/App/Controllers/MixingControl.c
    • -0
    • +1
    /firmware/App/Drivers/TemperatureSensors.c
    • -2
    • +2
    /firmware/App/Monitors/Conductivity.c
7:47 am

Vendor - TEL - Sameer Poyil

LDT-4409 mixing control param updates

Options
    • -41
    • +43
    /firmware/App/Controllers/MixingControl.c
    • -2
    • +4
    /firmware/App/Controllers/MixingControl.h
7:02 am

Vendor - TEL - Sameer Poyil

LDT-4409 addressed review comments

Options
    • -2
    • +2
    /firmware/App/Controllers/BalancingChamber.c
    • -1
    • +2
    /firmware/App/Controllers/ConcentratePumps.c
    • -16
    • +11
    /firmware/App/Controllers/DryBiCart.c
    • -23
    • +46
    /firmware/App/Controllers/MixingControl.c
    • -2
    • +1
    /firmware/App/Controllers/MixingControl.h
    • -1
    • +1
    /firmware/App/Drivers/TemperatureSensors.c
    • -1
    • +1
    /firmware/App/Tasks/TaskPriority.c
Monday 15 Jun
2:52 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

LDT-4539: Add state-change event logging to DD modules (BalancingChamber, DryBiCart, Heaters, Ultrafiltration)

Options
    • -0
    • +26
    /firmware/App/Controllers/BalancingChamber.c
    • -0
    • +10
    /firmware/App/Controllers/DryBiCart.c
    • -0
    • +2
    /firmware/App/Controllers/Heaters.c
    • -2
    • +9
    /firmware/App/Controllers/Ultrafiltration.c
    • -1
    • +1
    /firmware/App/Tasks/TaskPriority.c
2:17 pm

Vinayakam Mani

Remove empty line

Remove empty line

2:16 pm

Vinayakam Mani

Remove unused header files.

Remove unused header files.

2:15 pm

Vinayakam Mani

Remove empty line.

Remove empty line.

2:14 pm

Vinayakam Mani

can't we use DialsysateConductivity - local variable instead of getTargetCond()?

can't we use DialsysateConductivity - local variable instead of getTargetCond()?

2:11 pm

Vinayakam Mani

Initialize result to open loop state and remove the open loop state assignment later.

Initialize result to open loop state and remove the open loop state assignment later.

12:38 pm

Michael Garthwaite

Merge branch 'LDT-4485-dd-conductivity-sensors-d17' into develop

Options
    • -12
    • +52
    /firmware/App/Drivers/ConductivitySensors.c
    • -1
    • +1
    /firmware/App/Monitors/Conductivity.c
12:36 pm

Michael Garthwaite

LDT-4485: fixed conductivity monitoring overriding changes from staging. fixed cal and version request for conductivity sensors.

Options
    • -12
    • +52
    /firmware/App/Drivers/ConductivitySensors.c
    • -0
    • +12
    /firmware/App/Drivers/ConductivitySensors.h
    • -3
    • +3
    /firmware/App/Monitors/Conductivity.c
    • -1
    • +3
    /firmware/App/Services/Messaging.c
12:29 pm

Vinayakam Mani

Remove the blank line

Remove the blank line

12:28 pm

Vinayakam Mani

Add headers for all below functions.

Add headers for all below functions.

12:27 pm

Vinayakam Mani

Rmove extra blank line

Rmove extra blank line

12:26 pm

Michael Garthwaite

WIP on develop

Options
    • -14
    • +17
    /firmware/App/Monitors/Conductivity.c
12:19 pm

Vinayakam Mani

Update Input section: Balancing chamber state

Update Input section: Balancing chamber state

12:18 pm

Vinayakam Mani

We can keep it as handler instead of exec since this is being invoked from execMixingControl.

We can keep it as handler instead of exec since this is being invoked from execMixingControl.

12:04 pm

Vinayakam Mani

we should use get balancing chamber fill volume if balancing chamber volume been adjusted by calibration (not an immediate need, but good to have)

we should use get balancing chamber fill volume if balancing chamber volume been adjusted by calibration (not an immediate need, but good to have)

11:58 am

Vinayakam Mani

remove min in the comment.

remove min in the comment.