Activity dd-firmware/

Tree
Accordion

Stats

Commits this week: 28

Total Committers:	18
Last Commit:	09:57
Commits this week:	28

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Today

12 hrs ago

Vendor - TEL - Arpita Srivastava

More
a3d5d8c
changed 2 files
LDT-5157-conductivity-sensor-calibration LEAHI-DD-FIRMWARE-LDT-5157-1

Merge branch 'LDT-3735-non-volatile-memory' of bitbucket.org:diality-cloud/dd-firmware into LDT-5157-conductivity-sensor-calibration

- -1
- +1
/firmware/App/Monitors/Voltages.c
- History
- Source
- Diff
/firmware/App/Monitors/Voltages.c
- -1
- +2
/firmware/App/Tasks/TaskGeneral.c
- History
- Source
- Diff
/firmware/App/Tasks/TaskGeneral.c

12 hrs ago

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-5157-1
started review

LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)

LEAHI-DD-FIRMWARE-LDT-5157_System Data and Logs (DD) - Conductivity Sensor Calibration (1/3)

12 hrs ago

Vendor - TEL - Arpita Srivastava

More
be1ff66
changed 5 files
LDT-3735-non-volatile-memory, LDT-5157-conductivity-sensor-calibration LEAHI-DD-FIRMWARE-LDT-3735-1 LEAHI-DD-FIRMWARE-LDT-5157-1

LDT-3735: Addressed review comments

- -15
- +15
/firmware/App/Services/Messaging.c
- History
- Source
- Diff
/firmware/App/Services/Messaging.c
- -83
- +116
/firmware/App/Services/NVMessagingDD.c
- History
- Source
- Diff
/firmware/App/Services/NVMessagingDD.c
- -17
- +15
/firmware/App/Services/NVMessagingDD.h
- History
- Source
- Diff
/firmware/App/Services/NVMessagingDD.h
- -2
- +1
/firmware/App/Services/NVRecordsDD.c
- History
- Source
- Diff
/firmware/App/Services/NVRecordsDD.c
- -1
- +1
/firmware/App/Services/NVRecordsDD.h
- History
- Source
- Diff
/firmware/App/Services/NVRecordsDD.h

Tuesday 14 Jul

3:18 pm

Dara Navaei

More
ab97cdb
changed 1 file
develop

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

3:16 pm

Michael Garthwaite

More
949ad66
changed 1 file
develop

Merge branch 'LDT-4734-temp-comp-conductivity' into develop

- -3
- +4
/firmware/App/Monitors/Conductivity.c
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.c

3:09 pm

Michael Garthwaite

More
6bccc0b
changed 2 files
develop

Merge branch 'LDT-4734-temp-comp-conductivity' into develop

- -4
- +39
/firmware/App/Drivers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c
- -37
- +94
/firmware/App/Monitors/Conductivity.c
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.c

3:08 pm

Michael Garthwaite

More
daa4204
changed 8 files
develop

Merge branch 'LDT-4733-request-add-variables' into develop

- -2
- +2
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -2
- +2
/firmware/App/Controllers/DryBiCart.c
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.c
- -2
- +2
/firmware/App/Controllers/Heaters.c
- History
- Source
- Diff
/firmware/App/Controllers/Heaters.c
- -2
- +2
/firmware/App/Controllers/MixingControl.h
- History
- Source
- Diff
/firmware/App/Controllers/MixingControl.h
- -2
- +2
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c
- -5
- +4
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c
- -2
- +4
/firmware/App/Tasks/TaskGeneral.c
- History
- Source
- Diff
/firmware/App/Tasks/TaskGeneral.c
- -0
- +1
/firmware/source/sys_main.c
- History
- Source
- Diff
/firmware/source/sys_main.c

3:07 pm

Dara Navaei

More
9fdde08
changed 1 file
LDT-4611-hdf-fw-implementation-5-4, LDT-4876-dd-intermittently-goes-into- and 2 more

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
/firmware/App/DDCommon.h
- History
- Source
- Diff
/firmware/App/DDCommon.h

3:06 pm

Dara Navaei

More
d47b9bc
changed 9 files
LDT-4611-hdf-fw-implementation-5-4, LDT-4876-dd-intermittently-goes-into- and 2 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
/firmware/App/Drivers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c
- -1
- +1
/firmware/App/Drivers/ConductivitySensors.h
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.h
- -2
- +2
/firmware/App/Monitors/Conductivity.c
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.c
- -1
- +1
/firmware/App/Monitors/Conductivity.h
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.h
- -2
- +2
/firmware/App/Monitors/Voltages.c
- History
- Source
- Diff
/firmware/App/Monitors/Voltages.c
- -2
- +2
/firmware/App/Monitors/Voltages.h
- History
- Source
- Diff
/firmware/App/Monitors/Voltages.h
- -1
- +1
/firmware/App/Services/FpgaDD.c
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.c
- -1
- +1
/firmware/App/Services/FpgaDD.h
- History
- Source
- Diff
/firmware/App/Services/FpgaDD.h
- -2
- +2
/firmware/App/Tasks/TaskGeneral.c
- History
- Source
- Diff
/firmware/App/Tasks/TaskGeneral.c

3:02 pm

Michael Garthwaite

More
d5c0178
changed 0 files
LDT-4611-hdf-fw-implementation-5-4, LDT-4876-dd-intermittently-goes-into- and 2 more

Merge branch 'LDT-4733-request-add-variables' into staging

3:02 pm

Michael Garthwaite

More
2ec3d1a
changed 0 files
LDT-4611-hdf-fw-implementation-5-4, LDT-4876-dd-intermittently-goes-into- and 2 more

Merge branch 'LDT-4734-temp-comp-conductivity' into staging

3:02 pm

Michael Garthwaite

More
01211d3
changed 1 file
LDT-4611-hdf-fw-implementation-5-4, LDT-4733-request-add-variables and 4 more

LDT-4733: fixed warning of implicit call

- -0
- +1
/firmware/App/Tasks/TaskGeneral.c
- History
- Source
- Diff
/firmware/App/Tasks/TaskGeneral.c

2:58 pm

Michael Garthwaite

2:58 pm

Michael Garthwaite

2:58 pm

Michael Garthwaite

More
4626638
changed 6 files
LDT-3975-water-treatment-and-degassing-- LEAHI-DD-FIRMWARE-LDT-3975-2

LDT-3975: boost pump control changes to reflect new PI controller.

- -19
- +16
/firmware/App/Controllers/BoostPump.c
- History
- Source
- Diff
/firmware/App/Controllers/BoostPump.c
- -26
- +6
/firmware/App/Controllers/ROPump.c
- History
- Source
- Diff
/firmware/App/Controllers/ROPump.c
- -1
- +1
/firmware/App/Modes/FPModes/ModeGenPermeate.c
- History
- Source
- Diff
/firmware/App/.../FPModes/ModeGenPermeate.c
- -1
- +1
/firmware/App/Modes/FPModes/ModePreGenPermeate.c
- History
- Source
- Diff
/firmware/App/.../ModePreGenPermeate.c
- -1
- +1
/firmware/App/Modes/FPModes/StateFlushConcentrate.c
- History
- Source
- Diff
/firmware/App/.../StateFlushConcentrate.c
- -3
- +2
/firmware/App/Modes/FPModes/StateFlushPermeate.c
- History
- Source
- Diff
/firmware/App/.../StateFlushPermeate.c

2:43 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

Remove blank line.

Remove blank line.

2:42 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

If this is a override message handler, it is not in the table in Messaging.c and it does not have the proper parameter list (1 parameter for a message pointer).

If this is a override message handler, it is not in the table in Messaging.c and it does not have the proper parameter list (1 parameter for a message pointer).

2:37 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

Can we have a payload structure (packed to 1 byte alignment) with 1 field of type U08 for this message and then replace '1' with 'sizeof( new struct type )' ?

Can we have a payload structure (packed to 1 byte alignment) with 1 field of type U08 for this message and then replace '1' with 'sizeof( new struct type )' ?

2:32 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

Add blank line between declarations and rest of function code (throughout this unit)

Add blank line between declarations and rest of function code (throughout this unit)

2:31 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

Add blank line before return statement. ( throughout this unit )

Add blank line before return statement. ( throughout this unit )

2:31 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

Add blank line before return statement.

Add blank line before return statement.

2:30 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:30 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:30 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:30 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:29 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

Add blank line before return statement.

Add blank line before return statement.

2:29 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

Add blank line between declarations and rest of function code.

Add blank line between declarations and rest of function code.

2:29 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

Add blank line before return statement.

Add blank line before return statement.

2:29 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

Add blank line before return statement.

Add blank line before return statement.

2:28 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

Add blank line before return statement.

Add blank line before return statement.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-07-15 22:27 -0700