dd-firmware

Clone Tools

Stats

Commits this week: 34
Total Committers: 18
Last Commit: 23 Jul
Commits this week: 34

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 23 Jul
5:22 pm

Vendor - TEL - Arpita Srivastava

LDT-5157: Added Conductivity Sensor Record

Options
    • -1
    • +1
    /firmware/App/Drivers/TemperatureSensors.c
    • -14
    • +32
    /firmware/App/Services/Messaging.c
    • -586
    • +1568
    /firmware/App/Services/NVMessagingDD.c
    • -14
    • +48
    /firmware/App/Services/NVMessagingDD.h
    • -162
    • +449
    /firmware/App/Services/NVRecordsDD.c
    • -100
    • +187
    /firmware/App/Services/NVRecordsDD.h
5:09 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
5:08 pm

Vinayakam Mani

LDT-4873 merge into develop

Options
    • -5
    • +13
    /firmware/App/Controllers/Heaters.c
5:02 pm

Vinayakam Mani

LDT-4873 removed empty line

Options
    • -1
    • +0
    /firmware/App/Controllers/Heaters.c
4:57 pm

Vinayakam Mani

LDT-4873 latest from staging

Options
    • -4
    • +16
    /firmware/App/Controllers/Heaters.c
4:57 pm

Vendor - TEL - Jashwant Gantyada

4:56 pm

Vinayakam Mani

LDT-4873 fixing cond level sensor alarm

Options
    • -5
    • +14
    /firmware/App/Controllers/Heaters.c
11:22 am

Dara Navaei

Same question as above: should we alarm if the retries failed?

Same question as above: should we alarm if the retries failed?

11:06 am

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

11:05 am

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

10:39 am

Dara Navaei

If a retry goes wrong will you trigger an alarm?

If a retry goes wrong will you trigger an alarm?

10:31 am

Dara Navaei

Any fault alarm here?

Any fault alarm here?

10:18 am

Dara Navaei

Have these variables been initialized correctly?

Have these variables been initialized correctly?

Wednesday 22 Jul
1:26 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:13 pm

Sean Nash

We generally don't add { } to switch cases unless they require local variable declarations.

We generally don't add { } to switch cases unless they require local variable declarations.

1:08 pm

Sean Nash

If we're not including a timestamp, can we just remove this line of code?

If we're not including a timestamp, can we just remove this line of code?

1:07 pm

Sean Nash

Why commented out?

Why commented out?

Tuesday 21 Jul
4:50 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
4:48 pm

Vendor - TEL - Jashwant Gantyada

merged LDT-4410 Into develop

Options
    • -2
    • +2
    /firmware/App/Controllers/DryBiCart.c
    • -1
    • +2
    /firmware/App/Monitors/Conductivity.c
4:32 pm

Vendor - TEL - Jashwant Gantyada

merged latest staging

Options
    • -8
    • +9
    /firmware/App/Controllers/DryBiCart.c
    • -41
    • +50
    /firmware/App/Controllers/MixingControl.c
    • -1
    • +5
    /firmware/App/Controllers/MixingControl.h
    • -74
    • +99
    /firmware/App/Monitors/Conductivity.c
4:10 pm

Vinayakam Mani

0.0F(float type).

0.0F(float type).

4:07 pm

Vinayakam Mani

I meant 'handleBicarbChamberCartridgeFillWaterEndState function stops the inlet water to cartridge'.

I meant 'handleBicarbChamberCartridgeFillWaterEndState function stops the inlet water to cartridge'.

12:06 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
11:41 am

Vendor - TEL - Jashwant Gantyada

Merge branch 'LDT-4410-dialysate-composition-mixing-2' into develop

Options
11:41 am

Vendor - TEL - Jashwant Gantyada

LDT-4410 commented temperature alarm for develop branch working

Options
    • -1
    • +2
    /firmware/App/Drivers/TemperatureSensors.c
10:28 am

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Stepper driver firmware implementation

Options
    • -11
    • +68
    /firmware/App/Controllers/ConcentratePumps.c
    • -10
    • +47
    /firmware/App/Controllers/SubstitutionPump.c
    • -19
    • +19
    /firmware/App/Services/FpgaDD.c
Monday 20 Jul
5:06 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    /firmware/App/DDCommon.h
4:54 pm

Vendor - TEL - Jashwant Gantyada

merged LDT-4410 to develop

Options
    • -120
    • +257
    /firmware/App/Controllers/BalancingChamber.c
    • -59
    • +159
    /firmware/App/Controllers/DryBiCart.c
    • -10
    • +8
    /firmware/App/Controllers/MixingControl.c
    • -2
    • +2
    /firmware/App/Monitors/Conductivity.c
4:39 pm

Vinayakam Mani

Delete it.

Delete it.

4:39 pm

Vendor - TEL - Jashwant Gantyada

LDT-4410 code review comments addressed

Options
    • -48
    • +18
    /firmware/App/Controllers/BalancingChamber.c
    • -2
    • +2
    /firmware/App/Controllers/BalancingChamber.h
    • -1
    • +2
    /firmware/App/Controllers/ConcentratePumps.h
    • -36
    • +32
    /firmware/App/Controllers/DryBiCart.c
    • -7
    • +8
    /firmware/App/Controllers/MixingControl.c
    • -2
    • +2
    /firmware/App/Monitors/Conductivity.c