dd-firmware

Clone Tools

Stats

Commits this week: 51
Total Committers: 20
Last Commit: 29 Jul
Commits this week: 51

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 29 Jul
4:07 pm

Michael Garthwaite

LDT-5209: prelim commit of DD pre gen priming. Added dry bicart state that is similar to chamber f fill but related to pregen.

Options
    • -7
    • +413
    /firmware/App/Controllers/DryBiCart.c
    • -0
    • +4
    /firmware/App/Controllers/DryBiCart.h
    • -1
    • +1
    /firmware/App/Drivers/ConductivitySensors.c
    • -42
    • +280
    /firmware/App/Modes/ModePreGenDialysate.c
    • -0
    • +1
    /firmware/App/Monitors/Conductivity.c
3:56 pm

Vendor - TEL - Sameer Poyil

Also need a function for Spent side only open for drain

Also need a function for Spent side only open for drain

3:55 pm

Vendor - TEL - Sameer Poyil

could you please arrange Fresh side and Spend side valve together ?

could you please arrange Fresh side and Spend side valve together ?

3:46 pm

Vendor - TEL - Arpita Srivastava

Merge branch 'staging' of bitbucket.org:diality-cloud/dd-firmware into LDT-3735-non-volatile-memory

Options
    • -2
    • +5
    /firmware/App/Services/NVRecordsDD.c
    • -2
    • +5
    /firmware/App/Services/NVRecordsDD.h
3:42 pm

Vendor - TEL - Arpita Srivastava

LDT-3735: TODO fix in TD

Options
    • -1
    • +1
    /firmware/App/Services/NVRecordsDD.c
    • -39
    • +0
    /firmware/App/Services/NVRecordsDD.h
2:41 pm

Vendor - TEL - Sameer Poyil

please document this too

please document this too

2:39 pm

Vendor - TEL - Sameer Poyil

this variable is removed now ,

this variable is removed now ,

2:37 pm

Vinayakam Mani

Could you please move 10.0F aligned to the rest of the declaration. I see Drybicart persistence duration (500ms) is as well not aligned.

Could you please move 10.0F aligned to the rest of the declaration. I see Drybicart persistence duration (500ms) is as well not aligned.

2:34 pm

Vendor - TEL - Sameer Poyil

yes . but need to change from fill water state to IDLE state , and Vent state to IDLE state, implement common in a function and call from both state

yes . but need to change from fill water state to IDLE state , and Vent state to IDLE state, implement common in a function and call from both state

2:34 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:34 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:34 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:33 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:33 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:33 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

Updated

2:28 pm

Vendor - TEL - Jashwant Gantyada

added

added

2:28 pm

Vendor - TEL - Jashwant Gantyada

gave space

gave space

2:28 pm

Vendor - TEL - Jashwant Gantyada

updated the comment

updated the comment

2:27 pm

Vendor - TEL - Jashwant Gantyada

yes we need to check band 4. it was a mistake

yes we need to check band 4. it was a mistake

2:27 pm

Vendor - TEL - Jashwant Gantyada

aligned

aligned

2:27 pm

Vendor - TEL - Jashwant Gantyada

added

added

2:27 pm

Vendor - TEL - Jashwant Gantyada

removed

removed

2:26 pm

Vendor - TEL - Jashwant Gantyada

LDT-4410 code review comments addressed

Options
    • -5
    • +5
    /firmware/App/Controllers/BalancingChamber.c
    • -5
    • +5
    /firmware/App/Controllers/BalancingChamber.h
    • -1
    • +1
    /firmware/App/Controllers/DryBiCart.c
    • -1
    • +1
    /firmware/App/Controllers/MixingControl.c
    • -5
    • +0
    /firmware/App/Modes/ModeGenDialysate.c
2:25 pm

Vendor - TEL - Arpita Srivastava

LDT-5157: Fixed sendEvent warning

Options
    • -1
    • +1
    /firmware/App/Services/NVRecordsDD.c
2:18 pm

Vinayakam Mani

Remove the commented lines.

Remove the commented lines.

2:14 pm

Vinayakam Mani

Add comment

Add comment

2:12 pm

Vinayakam Mani

Align the indentation

Align the indentation

2:08 pm

Vinayakam Mani

Do you need to check Band 4 here? less than 80ml or 70 ml, since your comment on band 3 says between 70 to 80ml/min.

Do you need to check Band 4 here? less than 80ml or 70 ml, since your comment on band 3 says between 70 to 80ml/min.

2:02 pm

Vinayakam Mani

70ml/min to 80ml/min?

70ml/min to 80ml/min?

1:58 pm

Vinayakam Mani

Space after closing paranthesis.

Space after closing paranthesis.