Activity dd-firmware/

5 hrs ago

Michael Garthwaite

More
fc80660
changed 2 files
LDT-5209-pre-treatment LEAHI-DD-FIRMWARE-LDT-5209-1

LDT-5209: publishing updates

- -0
- +1
/firmware/App/Controllers/DryBiCart.c
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.c
- -0
- +1
/firmware/App/Controllers/DryBiCart.h
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.h

5 hrs ago

Vendor - TEL - Jashwant Gantyada

More
67d2fdf
changed 4 files
LDT-4410-dialysate-composition-mixing-2, feature/LDT-5102-dd-concentrate-pumps-hardware-d, staging LEAHI-DD-FIRMWARE-LDT-4410-3

LDT-4410 addressed code review comments

- -0
- +23
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -0
- +1
/firmware/App/Controllers/BalancingChamber.h
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.h
- -16
- +31
/firmware/App/Controllers/DryBiCart.c
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.c
- -1
- +1
/firmware/App/Monitors/Conductivity.c
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.c

6 hrs ago

Michael Garthwaite

More
f74c9e1
changed 0 files
LDT-5209-pre-treatment

Merge branch 'staging' into LDT-5209-pre-treatment

6 hrs ago

Michael Garthwaite

More
c67f50a
changed 5 files
LDT-5209-pre-treatment LEAHI-DD-FIRMWARE-LDT-5209-1

LDT-5209: prelim commit of DD pre gen priming. Added dry bicart state that is similar to chamber f fill but related to pregen.

- -7
- +413
/firmware/App/Controllers/DryBiCart.c
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.c
- -0
- +4
/firmware/App/Controllers/DryBiCart.h
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.h
- -1
- +1
/firmware/App/Drivers/ConductivitySensors.c
- History
- Source
- Diff
/firmware/App/.../ConductivitySensors.c
- -42
- +280
/firmware/App/Modes/ModePreGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreGenDialysate.c
- -0
- +1
/firmware/App/Monitors/Conductivity.c
- History
- Source
- Diff
/firmware/App/Monitors/Conductivity.c

6 hrs ago

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-4410-3
commented on review

Also need a function for Spent side only open for drain

6 hrs ago

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-4410-3
commented on review

could you please arrange Fresh side and Spend side valve together ?

6 hrs ago

Vendor - TEL - Arpita Srivastava

More
1e1a875
changed 2 files
LDT-3735-non-volatile-memory LEAHI-DD-FIRMWARE-LDT-3735-1

Merge branch 'staging' of bitbucket.org:diality-cloud/dd-firmware into LDT-3735-non-volatile-memory

- -2
- +5
/firmware/App/Services/NVRecordsDD.c
- History
- Source
- Diff
/firmware/App/Services/NVRecordsDD.c
- -2
- +5
/firmware/App/Services/NVRecordsDD.h
- History
- Source
- Diff
/firmware/App/Services/NVRecordsDD.h

6 hrs ago

Vendor - TEL - Arpita Srivastava

More
c0643d8
changed 2 files
LDT-3735-non-volatile-memory LEAHI-DD-FIRMWARE-LDT-3735-1

LDT-3735: TODO fix in TD

- -1
- +1
/firmware/App/Services/NVRecordsDD.c
- History
- Source
- Diff
/firmware/App/Services/NVRecordsDD.c
- -39
- +0
/firmware/App/Services/NVRecordsDD.h
- History
- Source
- Diff
/firmware/App/Services/NVRecordsDD.h

7 hrs ago

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-4410-3
commented on review

please document this too

7 hrs ago

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-4410-3
commented on review

this variable is removed now ,

7 hrs ago

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-4410-3
replied to Vendor - TEL - Jashwant Gantyada

Could you please move 10.0F aligned to the rest of the declaration. I see Drybicart persistence duration (500ms) is as well not aligned.

7 hrs ago

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-4410-3
replied to Vendor - TEL - Jashwant Gantyada

yes . but need to change from fill water state to IDLE state , and Vent state to IDLE state, implement common in a function and call from both state

7 hrs ago

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

7 hrs ago

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

7 hrs ago

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

7 hrs ago

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

7 hrs ago

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

7 hrs ago

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Updated

7 hrs ago

Vendor - TEL - Jashwant Gantyada

added

7 hrs ago

Vendor - TEL - Jashwant Gantyada

gave space

7 hrs ago

Vendor - TEL - Jashwant Gantyada

updated the comment

7 hrs ago

Vendor - TEL - Jashwant Gantyada

yes we need to check band 4. it was a mistake

7 hrs ago

Vendor - TEL - Jashwant Gantyada

aligned

7 hrs ago

Vendor - TEL - Jashwant Gantyada

added

7 hrs ago

Vendor - TEL - Jashwant Gantyada

removed

7 hrs ago

Vendor - TEL - Jashwant Gantyada

More
c1557cc
changed 5 files
LDT-4410-dialysate-composition-mixing-2, feature/LDT-5102-dd-concentrate-pumps-hardware-d, staging LEAHI-DD-FIRMWARE-LDT-4410-3

LDT-4410 code review comments addressed

- -5
- +5
/firmware/App/Controllers/BalancingChamber.c
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.c
- -5
- +5
/firmware/App/Controllers/BalancingChamber.h
- History
- Source
- Diff
/firmware/App/.../BalancingChamber.h
- -1
- +1
/firmware/App/Controllers/DryBiCart.c
- History
- Source
- Diff
/firmware/App/Controllers/DryBiCart.c
- -1
- +1
/firmware/App/Controllers/MixingControl.c
- History
- Source
- Diff
/firmware/App/Controllers/MixingControl.c
- -5
- +0
/firmware/App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
/firmware/App/Modes/ModeGenDialysate.c

7 hrs ago

Vendor - TEL - Arpita Srivastava

More
847585d
changed 1 file
LDT-5157-conductivity-sensor-calibration LEAHI-DD-FIRMWARE-LDT-5157-1

LDT-5157: Fixed sendEvent warning

- -1
- +1
/firmware/App/Services/NVRecordsDD.c
- History
- Source
- Diff
/firmware/App/Services/NVRecordsDD.c

7 hrs ago

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-4410-3
commented on review

Remove the commented lines.

7 hrs ago

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-4410-3
commented on review

Add comment

7 hrs ago

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-4410-3
commented on review

Align the indentation

dd-firmware

Stats

Commits this week: 50

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Michael Garthwaite

Vendor - TEL - Jashwant Gantyada

Michael Garthwaite

Michael Garthwaite

Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil

Vendor - TEL - Arpita Srivastava

Vendor - TEL - Arpita Srivastava

Vendor - TEL - Sameer Poyil

Vendor - TEL - Sameer Poyil

Vinayakam Mani

Vendor - TEL - Sameer Poyil

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Vendor - TEL - Jashwant Gantyada

Vendor - TEL - Jashwant Gantyada

Vendor - TEL - Jashwant Gantyada

Vendor - TEL - Jashwant Gantyada

Vendor - TEL - Jashwant Gantyada

Vendor - TEL - Jashwant Gantyada

Vendor - TEL - Jashwant Gantyada

Vendor - TEL - Jashwant Gantyada

Vendor - TEL - Arpita Srivastava

Vinayakam Mani

Vinayakam Mani

Vinayakam Mani