ConcentratePumps.h

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove blank line.

Remove blank line.

Should we add _TARGET to these names for clarity?

Should we add _TARGET to these names for clarity?

Is the count really a float?

Is the count really a float?

Do we need an override for the RPM feedback?

Do we need an override for the RPM feedback?

This is a maximum per treatment?

This is a maximum per treatment?

I'm not seeing fixes in this file.

I'm not seeing fixes in this file.

Remove extra blank line.

Remove extra blank line.

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

moved the sets into a separate function from init

moved the sets into a separate function from init

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 121 more files in changeset.
Move up with other controllers.

Move up with other controllers.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 121 more files in changeset.
I only see these configurations being set here in initialize function. Is that all we need? Is this configuration what we want for these valves in all states? I would recommend we combine these 3 ...

I only see these configurations being set here in initialize function. Is that all we need? Is this configuration what we want for these valves in all states?

I would recommend we combine these 3 fpga functions into one single function that takes all 3 params and updates all 3 registers.

I think these should be initialized to zero in case there are unused bits that won't be set below.

I think these should be initialized to zero in case there are unused bits that won't be set below.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

Done.

Done.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Done

Done

Done

Done

Done

Done