LEAHI-DD-FIRMWARE-LDT-1196-6 LEAHI-DD-FIRMWARE-LDT-1196_DD: Request for a variable for target Qd rate

closed on 07 Oct

Author

Moderator

Reviewers

LEAHI-DD-FIRMWARE-LDT-1196_DD: Request for a variable for target Qd rate

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 98

dd-firmware 0
- Folder firmware 0
  - Folder .settings 0
    - File com.ti.ccstudio.project.core.prefs 0 Remove
    - File org.eclipse.core.resources.prefs 0 Remove
  - Folder App 0
    - Folder Controllers 0
      - File BalancingChamber.h 0 Remove
      - File BoostPump.c 0 Remove
      - File BoostPump.h 0 Remove
      - File ConcentratePumps.c 0 Remove
      - File ConcentratePumps.h 0 Remove
      - File DialysatePumps.c 0 Remove
      - File Heaters.c 0 Remove
      - File PermeateTank.c 0 Remove
      - File PermeateTank.h 0 Remove
      - File ROPump.c 0 Remove
      - File ROPump.h 0 Remove
      - File RinsePump.c 0 Remove
      - File RinsePump.h 0 Remove
      - File Valves.c 0 Remove
      - File Valves.h 0 Remove
    - Folder Drivers 0
      - File ConductivitySensors.c 0 Remove
      - File ConductivitySensors.h 0 Remove
      - File FlowSensor.c 0 Remove
      - File FlowSensor.h 0 Remove
      - File FluidPump.c 0 Remove
      - File FluidPump.h 0 Remove
      - File InternalADC.c 0 Remove
      - File InternalADC.h 0 Remove
      - File PressureSensor.c 0 Remove
      - File PressureSensor.h 0 Remove
      - File SafetyShutdown.c 0 Remove
      - File TemperatureSensors.c 0 Remove
      - File TemperatureSensors.h 0 Remove
    - Folder Modes 0
      - Folder FPModes 0
        
        File FPModeFault.c 0 Remove
        
        File FPModeFault.h 0 Remove
        
        File FPModeInitPOST.c 0 Remove
        
        File FPModeInitPOST.h 0 Remove
        
        File FPModeStandby.c 0 Remove
        
        File FPModeStandby.h 0 Remove
        
        File FPOperationModes.c 0 Remove
        
        File FPOperationModes.h 0 Remove
        
        File FlushConcentrate.c 0 Remove
        
        File FlushConcentrate.h 0 Remove
        
        File FlushFilter.c 0 Remove
        
        File FlushFilter.h 0 Remove
        
        File FlushPermeate.c 0 Remove
        
        File FlushPermeate.h 0 Remove
        
        File InletPressureCheck.c 0 Remove
        
        File InletPressureCheck.h 0 Remove
        
        File ModeGenPermeate.c 0 Remove
        
        File ModeGenPermeate.h 0 Remove
        
        File ModeGenPermeateDefeatured.c 0 Remove
        
        File ModeGenPermeateDefeatured.h 0 Remove
        
        File ModePreGenPermeate.c 0 Remove
        
        File ModePreGenPermeate.h 0 Remove
        
        File ModePreGenPermeateDefeatured.c 0 Remove
        
        File ModePreGenPermeateDefeatured.h 0 Remove
      - File ModeFault.c 0 Remove
      - File ModeGenDialysate.c 11 Remove
      - File ModeGenDialysate.h 0 Remove
      - File ModePreGenDialysate.c 0 Remove
      - File OperationModes.c 0 Remove
      - File OperationModes.h 0 Remove
    - Folder Monitors 0
      - File BloodLeak.c 0 Remove
      - File BloodLeak.h 0 Remove
      - File Conductivity.c 0 Remove
      - File Conductivity.h 0 Remove
      - File Flow.c 0 Remove
      - File Flow.h 0 Remove
      - File Level.c 0 Remove
      - File Level.h 0 Remove
      - File Pressure.c 0 Remove
      - File Pressure.h 0 Remove
      - File Temperature.c 0 Remove
      - File Temperature.h 0 Remove
      - File Voltages.c 0 Remove
      - File Voltages.h 0 Remove
      - File WaterQualityMonitor.c 0 Remove
      - File WaterQualityMonitor.h 0 Remove
    - Folder Services 0
      - File AlarmMgmtDD.c 0 Remove
      - File AlarmMgmtDD.h 0 Remove
      - File AlarmMgmtSWFaults.h 0 Remove
      - File FPInterface.c 0 Remove
      - File FPInterface.h 0 Remove
      - File FpgaDD.c 0 Remove
      - File FpgaDD.h 0 Remove
      - File Messaging.c 0 Remove
      - File Messaging.h 0 Remove
      - File SystemCommDD.c 0 Remove
      - File SystemCommDD.h 0 Remove
      - File TDInterface.c 0 Remove
    - Folder Tasks 0
      - File TaskGeneral.c 0 Remove
      - File TaskPriority.c 0 Remove
    - File FPCommon.h 0 Remove
  - Folder include 0
    - File adc.h 0 Remove
    - File can.h 0 Remove
  - Folder source 0
    - File adc.c 0 Remove
    - File can.c 0 Remove
    - File sys_main.c 0 Remove
  - File .cproject 0 Remove
  - File DD.dil 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
jpaguio (deleted user)	Author & Moderator	20m	6	LDT-2198 was merged into this branch after being merged i...
Daniel Ho	Reviewer - 0% reviewed
Vendor - TEL - Sivvanarayana Kurapati	Reviewer - 0% reviewed
Dara Navaei	Reviewer - 0% reviewed	33m
Michael Garthwaite	Reviewer - 0% reviewed
Vinayakam Mani	Reviewer - 0% reviewed	32m	3	RESOLVED IN CODE WALKTHROUGH.
Raghu Kallala	Reviewer - 1% reviewed	3m
Sean Nash	Reviewer - 0% reviewed	8m	3	Appears to be dialysate to dialyzer flow rate.
Vendor - TEL - Arpita Srivastava	Reviewer - 0% reviewed	7m
Total		1h 45m	12

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

jpaguio (deleted user)

LDT-2198 was merged into this branch after being merged into staging_alpha. B...

LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

07 Oct

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

LEAHI-DD-FIRMWARE-LDT-1196-6

LEAHI-DD-FIRMWARE-LDT-1196_DD: Request for a variable for target Qd rate

LEAHI-DD-FIRMWARE-LDT-1196-6 12

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

jpaguio (deleted user)

Log time

LEAHI-DD-FIRMWARE-LDT-1196_DD: Request for a variable for target Qd rate

LEAHI-DD-FIRMWARE-LDT-1196-6 12

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

jpaguio (deleted user)

Log time