dd-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 18
Total Committers: 13
Last Commit: 13:44
Commits this week: 18

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 27 Apr
10:38 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./DryBiCart.c
    • -1
    • +1
    ./DryBiCart.h
1:22 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
12:46 pm

Vinayakam Mani

Remove space after 'Supply'.

Remove space after 'Supply'.

12:44 pm

Vinayakam Mani

Align the value declaration indentation.

Align the value declaration indentation.

12:38 pm

Vinayakam Mani

looks you are already checking this state in a line above.

looks you are already checking this state in a line above.

10:51 am

Vendor - TEL - Sameer Poyil

Merge branch LDT-3978-switch-chamber-f-conductive-lev into develop

Options
    • -0
    • +18
    ./BalancingChamber.c
    • -23
    • +23
    ./DryBiCart.c
    • -2
    • +2
    ./Heaters.c
  4. … 4 more files in changeset.
10:36 am

Vendor - TEL - Sameer Poyil

LDT-3978 fix for conductive level sensor

Options
    • -2
    • +2
    ./BalancingChamber.c
    • -4
    • +5
    ./DryBiCart.c
    • -2
    • +2
    ./Heaters.c
  4. … 2 more files in changeset.
9:56 am

Vinayakam Mani

LDT-872 hetaer control

Options
    • -127
    • +40
    ./Heaters.c
  2. … 2 more files in changeset.
Sunday 26 Apr
12:42 pm

Sean Nash

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

Don't assign BOOL variables implicitly. Always assign a FALSE or TRUE explicitly with ternary operator or inside an if statement.

12:36 pm

Sean Nash

Declare local variables at top of scope.

Declare local variables at top of scope.

12:34 pm

Sean Nash

Add space between ( and ?

Add space between ( and ?

12:33 pm

Sean Nash

Remove blank line.

Remove blank line.

12:31 pm

Sean Nash

Why redeclare result?

Why redeclare result?

12:31 pm

Sean Nash

Remove blank line.

Remove blank line.

12:30 pm

Sean Nash

Why are you redeclaring result? This assignment will not survive outside of the if statement.

Why are you redeclaring result? This assignment will not survive outside of the if statement.

12:30 pm

Sean Nash

Remove blank line.

Remove blank line.

12:29 pm

Sean Nash

Remove blank line.

Remove blank line.

Friday 24 Apr
10:17 pm

Vinayakam Mani

10:15 pm

Vendor - TEL - Sameer Poyil

LDT-3978 conductive level sensor implementation for chamber F fill

Options
    • -0
    • +18
    ./BalancingChamber.c
    • -20
    • +19
    ./DryBiCart.c
  3. … 4 more files in changeset.
1:56 pm

Vendor - TEL - Jashwant Gantyada

Merge branch 'feature/LDT-3963-dialysate-flow-rate---fw-implem' into develop

Options
    • -8
    • +12
    ./BalancingChamber.c
1:54 pm

Vendor - TEL - Jashwant Gantyada

LDT-3963 fixeed bal chamber issues for low qd

Options
    • -8
    • +12
    ./BalancingChamber.c
Thursday 23 Apr
4:11 pm

Vendor - TEL - Sameer Poyil

LDT-3978 addressed review comments

Options
    • -2
    • +2
    ./Heaters.c
  2. … 2 more files in changeset.
3:02 pm

Vinayakam Mani

LDT-872 heater control update

Options
    • -2
    • +2
    ./BalancingChamber.c
    • -17
    • +17
    ./Heaters.c
    • -1
    • +5
    ./Ultrafiltration.c
2:59 pm

Vinayakam Mani

2:57 pm

Vinayakam Mani

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

instead of 0, we can use the level Enum 'LVL_STATE_EMPTY'?

2:49 pm

Vinayakam Mani

lower? and change the D98 level sensor comment as well.

lower? and change the D98 level sensor comment as well.

2:47 pm

Vinayakam Mani

Remove empty line

Remove empty line

2:46 pm

Vinayakam Mani

Space before LVL_STATE_LOW

Space before LVL_STATE_LOW

2:44 pm

Vinayakam Mani

space inside array index.

space inside array index.

2:41 pm

Vinayakam Mani

Space inside parenthesis.

Space inside parenthesis.