dd-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 21
Total Committers: 15
Last Commit: 18 Jun
Commits this week: 21

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 16 Jun
9:06 am

Vendor - TEL - Sameer Poyil

LDT-4409 conductivity sampling filter updates

Options
    • -0
    • +1
    ./ConcentratePumps.c
    • -1
    • +1
    ./MixingControl.c
  3. … 2 more files in changeset.
7:47 am

Vendor - TEL - Sameer Poyil

LDT-4409 mixing control param updates

Options
    • -41
    • +43
    ./MixingControl.c
    • -2
    • +4
    ./MixingControl.h
7:02 am

Vendor - TEL - Sameer Poyil

LDT-4409 addressed review comments

Options
    • -2
    • +2
    ./BalancingChamber.c
    • -1
    • +2
    ./ConcentratePumps.c
    • -16
    • +11
    ./DryBiCart.c
    • -23
    • +46
    ./MixingControl.c
    • -2
    • +1
    ./MixingControl.h
  6. … 2 more files in changeset.
Monday 15 Jun
2:52 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

LDT-4539: Add state-change event logging to DD modules (BalancingChamber, DryBiCart, Heaters, Ultrafiltration)

Options
    • -0
    • +26
    ./BalancingChamber.c
    • -0
    • +10
    ./DryBiCart.c
    • -0
    • +2
    ./Heaters.c
    • -2
    • +9
    ./Ultrafiltration.c
  5. … 1 more file in changeset.
2:17 pm

Vinayakam Mani

Remove empty line

Remove empty line

2:16 pm

Vinayakam Mani

Remove unused header files.

Remove unused header files.

2:15 pm

Vinayakam Mani

Remove empty line.

Remove empty line.

2:14 pm

Vinayakam Mani

can't we use DialsysateConductivity - local variable instead of getTargetCond()?

can't we use DialsysateConductivity - local variable instead of getTargetCond()?

2:11 pm

Vinayakam Mani

Initialize result to open loop state and remove the open loop state assignment later.

Initialize result to open loop state and remove the open loop state assignment later.

12:29 pm

Vinayakam Mani

Remove the blank line

Remove the blank line

12:28 pm

Vinayakam Mani

Add headers for all below functions.

Add headers for all below functions.

12:27 pm

Vinayakam Mani

Rmove extra blank line

Rmove extra blank line

12:19 pm

Vinayakam Mani

Update Input section: Balancing chamber state

Update Input section: Balancing chamber state

12:18 pm

Vinayakam Mani

We can keep it as handler instead of exec since this is being invoked from execMixingControl.

We can keep it as handler instead of exec since this is being invoked from execMixingControl.

12:04 pm

Vinayakam Mani

we should use get balancing chamber fill volume if balancing chamber volume been adjusted by calibration (not an immediate need, but good to have)

we should use get balancing chamber fill volume if balancing chamber volume been adjusted by calibration (not an immediate need, but good to have)

11:58 am

Vinayakam Mani

remove min in the comment.

remove min in the comment.

11:55 am

Vinayakam Mani

Remove the unused header file.

Remove the unused header file.

11:55 am

Vinayakam Mani

Remove the unused header file.

Remove the unused header file.

11:53 am

Vinayakam Mani

Update state name matching handler name.

Update state name matching handler name.

11:42 am

Vinayakam Mani

Same as above.

Same as above.

11:41 am

Vinayakam Mani

The second condition( fill request) should be checked against true?

The second condition( fill request) should be checked against true?

11:18 am

Vendor - TEL - Sameer Poyil

LDT-4409 enable dry bicart default

Options
    • -5
    • +5
    ./BalancingChamber.c
    • -17
    • +12
    ./MixingControl.h
  3. … 3 more files in changeset.
8:17 am

Vendor - TEL - Sameer Poyil

LDT-4409 dry bicart implementation plus refactoring closed loop control

Options
    • -0
    • +1
    ./BalancingChamber.c
    • -14
    • +25
    ./DryBiCart.c
    • -0
    • +3
    ./DryBiCart.h
    • -0
    • +1136
    ./MixingControl.c
    • -0
    • +96
    ./MixingControl.h
  6. … 1 more file in changeset.
Friday 12 Jun
2:19 pm

Michael Garthwaite

Merge branch 'LDT-4485-dd-conductivity-sensors-d17' into develop

Options
    • -7
    • +7
    ./Heaters.c
    • -2
    • +2
    ./RinsePump.c
  3. … 3 more files in changeset.
2:18 pm

Michael Garthwaite

LDT-4485: fixed pumpid call

Options
    • -1
    • +1
    ./SubstitutionPump.c
2:13 pm

Michael Garthwaite

LDT-4485: updates to sub pump rpm measure alarm to not monitor during off state.

Options
    • -1
    • +5
    ./SubstitutionPump.c
9:14 am

Sean Nash

Is this normal UF volume or normal UF volume + Iso UF Volume?

Is this normal UF volume or normal UF volume + Iso UF Volume?

9:11 am

Sean Nash

Consider moving this validity check into the setTDRequestedGenDState function. And what should we do if it's not valid?

Consider moving this validity check into the setTDRequestedGenDState function.
And what should we do if it's not valid?

9:07 am

Sean Nash

Why only these states are valid?

Why only these states are valid?

9:05 am

Sean Nash

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.