dd-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 40
Total Committers: 16
Last Commit: 17:13
Commits this week: 40

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 23 Jul
4:57 pm

Vinayakam Mani

LDT-4873 latest from staging

Options
    • -4
    • +16
    ./Heaters.c
4:57 pm

Vendor - TEL - Jashwant Gantyada

4:56 pm

Vinayakam Mani

LDT-4873 fixing cond level sensor alarm

Options
    • -5
    • +14
    ./Heaters.c
11:22 am

Dara Navaei

Same question as above: should we alarm if the retries failed?

Same question as above: should we alarm if the retries failed?

11:06 am

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

11:05 am

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

10:39 am

Dara Navaei

If a retry goes wrong will you trigger an alarm?

If a retry goes wrong will you trigger an alarm?

10:31 am

Dara Navaei

Any fault alarm here?

Any fault alarm here?

10:18 am

Dara Navaei

Have these variables been initialized correctly?

Have these variables been initialized correctly?

Wednesday 22 Jul
1:26 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:13 pm

Sean Nash

We generally don't add { } to switch cases unless they require local variable declarations.

We generally don't add { } to switch cases unless they require local variable declarations.

1:08 pm

Sean Nash

If we're not including a timestamp, can we just remove this line of code?

If we're not including a timestamp, can we just remove this line of code?

1:07 pm

Sean Nash

Why commented out?

Why commented out?

Tuesday 21 Jul
4:48 pm

Vendor - TEL - Jashwant Gantyada

merged LDT-4410 Into develop

Options
    • -2
    • +2
    ./DryBiCart.c
  2. … 1 more file in changeset.
4:32 pm

Vendor - TEL - Jashwant Gantyada

merged latest staging

Options
    • -8
    • +9
    ./DryBiCart.c
    • -41
    • +50
    ./MixingControl.c
    • -1
    • +5
    ./MixingControl.h
  4. … 1 more file in changeset.
4:10 pm

Vinayakam Mani

0.0F(float type).

0.0F(float type).

4:07 pm

Vinayakam Mani

I meant 'handleBicarbChamberCartridgeFillWaterEndState function stops the inlet water to cartridge'.

I meant 'handleBicarbChamberCartridgeFillWaterEndState function stops the inlet water to cartridge'.

10:28 am

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Stepper driver firmware implementation

Options
    • -11
    • +68
    ./ConcentratePumps.c
    • -10
    • +47
    ./SubstitutionPump.c
  3. … 1 more file in changeset.
Monday 20 Jul
4:54 pm

Vendor - TEL - Jashwant Gantyada

merged LDT-4410 to develop

Options
    • -120
    • +257
    ./BalancingChamber.c
    • -59
    • +159
    ./DryBiCart.c
    • -10
    • +8
    ./MixingControl.c
  4. … 1 more file in changeset.
4:39 pm

Vinayakam Mani

Delete it.

Delete it.

4:39 pm

Vendor - TEL - Jashwant Gantyada

LDT-4410 code review comments addressed

Options
    • -48
    • +18
    ./BalancingChamber.c
    • -2
    • +2
    ./BalancingChamber.h
    • -1
    • +2
    ./ConcentratePumps.h
    • -36
    • +32
    ./DryBiCart.c
    • -7
    • +8
    ./MixingControl.c
  6. … 1 more file in changeset.
4:32 pm

Vinayakam Mani

Remove blank spaces after =.

Remove blank spaces after =.

4:31 pm

Vinayakam Mani

To be deleted this line?

To be deleted this line?

4:25 pm

Vinayakam Mani

Add a comment here to wait for BC switching to go Idle state and transition to spent chamber fill state. Also, add a space after (). Apply the same comment in the next Dialysate delivery state as w...

Add a comment here to wait for BC switching to go Idle state and transition to spent chamber fill state. Also, add a space after (). Apply the same comment in the next Dialysate delivery state as well.

4:19 pm

Vinayakam Mani

I guess we can remove the "balancingChamberFillInProgress" check here.

I guess we can remove the "balancingChamberFillInProgress" check here.

4:00 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Driver update code part 1

Options
    • -0
    • +7
    ./ConcentratePumps.c
  2. … 2 more files in changeset.
2:31 pm

Vinayakam Mani

Remove the TODO comment.

Remove the TODO comment.

2:13 pm

Vinayakam Mani

align the comment.

align the comment.

2:08 pm

Vinayakam Mani

Vendor - TEL - Sameer PoyilWhat's the value you are recommending for?

Vendor - TEL - Sameer PoyilWhat's the value you are recommending for?

2:03 pm

Vinayakam Mani

Remove values in the comment, as they are changing during development (200ms persistence, 4 PSI low pressure, 17 PSI high pressure etc.,), instead use defined persistence, low or high threshold pre...

Remove values in the comment, as they are changing during development (200ms persistence, 4 PSI low pressure, 17 PSI high pressure etc.,), instead use defined persistence, low or high threshold pressure etc.,