dd-firmware / firmware / App

Controllers

Clone Tools

Stats

Commits this week: 40
Total Committers: 16
Last Commit: 17:13
Commits this week: 40

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 27 Jul
11:01 am

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Logic update

Options
    • -38
    • +60
    ./ConcentratePumps.c
    • -34
    • +67
    ./SubstitutionPump.c
8:29 am

Vendor - TEL - Jashwant Gantyada

This was added by Vinay to force the chamber F filling.

This was added by Vinay to force the chamber F filling.

8:27 am

Vendor - TEL - Jashwant Gantyada

It was changed by Vinay as part of the Conductivity spikes issue.

It was changed by Vinay as part of the Conductivity spikes issue.

Sunday 26 Jul
10:01 am

Vendor - TEL - Sameer Poyil

This is a problem, when lower cart pressure, D80 closes and if it is not reached upper cart pressure, it won't open D80

This is a problem, when lower cart pressure, D80 closes and if it is not reached upper cart pressure, it won't open D80

9:56 am

Vendor - TEL - Sameer Poyil

Why do we need 1 minutes of D80 opening ? is it not filling withing 10 seconds ?

Why do we need 1 minutes of D80 opening ? is it not filling withing 10 seconds ?

9:45 am

Vendor - TEL - Sameer Poyil

bicarbChamberLevel is a local variable and not an input

bicarbChamberLevel is a local variable and not an input

9:44 am

Vendor - TEL - Sameer Poyil

This is not required , we should design the state machine properly to handle chamber low level

This is not required , we should design the state machine properly to handle chamber low level

9:42 am

Vendor - TEL - Sameer Poyil

This is not the correct order for state machine,

This is not the correct order for state machine,

Friday 24 Jul
1:27 pm

suresh

LDT-4049:DDstandby review

Options
    • -0
    • +1
    ./Heaters.h
  2. … 2 more files in changeset.
10:11 am

Vinayakam Mani

At end of transition, do you want to initialize the totalSpentChamberFill reset to zero?

At end of transition, do you want to initialize the totalSpentChamberFill reset to zero?

10:07 am

Vinayakam Mani

Could you use SpentChamberLevel here, instead calling the getLevelStatus function again? Same for next conditions check as well ( line:889)

Could you use SpentChamberLevel here, instead calling the getLevelStatus function again? Same for next conditions check as well ( line:889)

9:32 am

Vinayakam Mani

Remove extra paranthesis.

Remove extra paranthesis.

9:29 am

Vinayakam Mani

Remove empty lines

Remove empty lines

9:28 am

Vinayakam Mani

Mention in comment this is equivalent to Qd:600 minus 50ms switching period to stabilize the valve closure.

Mention in comment this is equivalent to Qd:600 minus 50ms switching period to stabilize the valve closure.

9:24 am

Vinayakam Mani

Update the comment for Spent chamber fill, max dialysate flow rate (Qd:600) used for fast filling.

Update the comment for Spent chamber fill, max dialysate flow rate (Qd:600) used for fast filling.

Thursday 23 Jul
10:12 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Fix 2

Options
    • -5
    • +5
    ./SpentChamberFill.c
  2. … 1 more file in changeset.
5:08 pm

Vinayakam Mani

LDT-4873 merge into develop

Options
    • -5
    • +13
    ./Heaters.c
5:02 pm

Vinayakam Mani

LDT-4873 removed empty line

Options
    • -1
    • +0
    ./Heaters.c
4:57 pm

Vinayakam Mani

LDT-4873 latest from staging

Options
    • -4
    • +16
    ./Heaters.c
4:57 pm

Vendor - TEL - Jashwant Gantyada

4:56 pm

Vinayakam Mani

LDT-4873 fixing cond level sensor alarm

Options
    • -5
    • +14
    ./Heaters.c
11:22 am

Dara Navaei

Same question as above: should we alarm if the retries failed?

Same question as above: should we alarm if the retries failed?

11:06 am

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

11:05 am

Dara Navaei

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

10:39 am

Dara Navaei

If a retry goes wrong will you trigger an alarm?

If a retry goes wrong will you trigger an alarm?

10:31 am

Dara Navaei

Any fault alarm here?

Any fault alarm here?

10:18 am

Dara Navaei

Have these variables been initialized correctly?

Have these variables been initialized correctly?

Wednesday 22 Jul
1:26 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:13 pm

Sean Nash

We generally don't add { } to switch cases unless they require local variable declarations.

We generally don't add { } to switch cases unless they require local variable declarations.

1:08 pm

Sean Nash

If we're not including a timestamp, can we just remove this line of code?

If we're not including a timestamp, can we just remove this line of code?