dd-firmware / firmware / App / Drivers

ConductivitySensors.c

Clone Tools

Stats

Commits this week: 2
Total Committers: 6
Last Commit: 11:08
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 01 Dec
9:26 pm

Sean Nash

Why two output lines?

Why two output lines?

9:25 pm

Sean Nash

All cases seem a little off on indents, especially this one.

All cases seem a little off on indents, especially this one.

9:24 pm

Sean Nash

For default cases (throughout this unit), we either need a s/w fault (because this should never happen and indicates memory corruption) or a comment noting it is ok to ignore invalid cases (command...

For default cases (throughout this unit), we either need a s/w fault (because this should never happen and indicates memory corruption) or a comment noting it is ok to ignore invalid cases (commands in this case).

Friday 21 Nov
10:07 am

Sean Nash

Should we be calling get function in monitor instead of driver here?

Should we be calling get function in monitor instead of driver here?

10:06 am

Sean Nash

No overrides?

No overrides?

10:05 am

Sean Nash

Fix indent.

Fix indent.

10:05 am

Sean Nash

Use a #define instead of 1000.

Use a #define instead of 1000.

10:02 am

Sean Nash

If no parameters, just don't have any param lines (don't say none).

If no parameters, just don't have any param lines (don't say none).

10:01 am

Sean Nash

No param, so remove this line.

No param, so remove this line.

10:01 am

Sean Nash

measurementSettingsTX is an output.

measurementSettingsTX is an output.

10:00 am

Sean Nash

Seems like eePromDataTX is an output, not an input.

Seems like eePromDataTX is an output, not an input.

10:00 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:59 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:58 am

Sean Nash

Add comment to right.

Add comment to right.

9:57 am

Sean Nash

///

///

9:57 am

Sean Nash

Add space between } and type name.

Add space between } and type name.

9:56 am

Sean Nash

///

///

9:56 am

Sean Nash

Add space between } and type name.

Add space between } and type name.

9:56 am

Sean Nash

///

///

9:56 am

Sean Nash

Add space between } and type name.

Add space between } and type name.

9:55 am

Sean Nash

///

///

9:55 am

Sean Nash

///

///

9:55 am

Sean Nash

Use /// here so doxygen will pick it up.

Use /// here so doxygen will pick it up.

Thursday 20 Nov
9:23 am

Sean Nash

Comment seems backward. Uncommenting would enable the Teensy driver, right?

Comment seems backward. Uncommenting would enable the Teensy driver, right?

9:22 am

Sean Nash

Are we not supporting overrides with TEENSY driver?

Are we not supporting overrides with TEENSY driver?

9:19 am

Sean Nash

#ifdef

#ifdef

9:18 am

Sean Nash

Should be calling get function in monitor (not driver).

Should be calling get function in monitor (not driver).

9:17 am

Sean Nash

Agree, but this is a temporary driver so I don't want to spend too much time making this unit perfect.

Agree, but this is a temporary driver so I don't want to spend too much time making this unit perfect.

9:09 am

Sean Nash

Why are we doing pre-increment instead of post-increment? I don't think it matters in for loop, but this looks non-standard to me.

Why are we doing pre-increment instead of post-increment? I don't think it matters in for loop, but this looks non-standard to me.

9:03 am

Sean Nash

I don't see support for that with our compiler. Author of code must ensure destination buffer is large enough to hold the specified number of bytes being copied. Code reviewer should verify this.

I don't see support for that with our compiler. Author of code must ensure destination buffer is large enough to hold the specified number of bytes being copied. Code reviewer should verify this.