ConductivityTeensy.h

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
As per Sean's comment mark it as resolved

As per Sean's comment mark it as resolved

marking it as resolved since this is a temporary driver

marking it as resolved since this is a temporary driver

I am marking it as resolved since it is temporary driver

I am marking it as resolved since it is temporary driver

Its like we need to compile the safe library and include it. But if we are using only memcpy and memset, memcmp and static code analyzer check the destination buffer size , I am marking it as resolved

Its like we need to compile the safe library and include it. But if we are using only memcpy and memset, memcmp and static code analyzer check the destination buffer size , I am marking it as resolved

Why two output lines?

Why two output lines?

All cases seem a little off on indents, especially this one.

All cases seem a little off on indents, especially this one.

For default cases (throughout this unit), we either need a s/w fault (because this should never happen and indicates memory corruption) or a comment noting it is ok to ignore invalid cases (command...

For default cases (throughout this unit), we either need a s/w fault (because this should never happen and indicates memory corruption) or a comment noting it is ok to ignore invalid cases (commands in this case).

LDT-2004: Merged select sensor and get single measurement to optimize time.

  1. … 1 more file in changeset.
Should we be calling get function in monitor instead of driver here?

Should we be calling get function in monitor instead of driver here?

No overrides?

No overrides?

Fix indent.

Fix indent.

Use a #define instead of 1000.

Use a #define instead of 1000.

If no parameters, just don't have any param lines (don't say none).

If no parameters, just don't have any param lines (don't say none).

No param, so remove this line.

No param, so remove this line.

measurementSettingsTX is an output.

measurementSettingsTX is an output.

Seems like eePromDataTX is an output, not an input.

Seems like eePromDataTX is an output, not an input.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

Remove extra blank line.

Add comment to right.

Add comment to right.

///

///

Add space between } and type name.

Add space between } and type name.

///

///

Add space between } and type name.

Add space between } and type name.

///

///

Add space between } and type name.

Add space between } and type name.

///

///

///

///

Use /// here so doxygen will pick it up.

Use /// here so doxygen will pick it up.

Comment seems backward. Uncommenting would enable the Teensy driver, right?

Comment seems backward. Uncommenting would enable the Teensy driver, right?

Are we not supporting overrides with TEENSY driver?

Are we not supporting overrides with TEENSY driver?