TemperatureSensors.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merged latest staging into develop

  1. … 33 more files in changeset.
Merge LDT-618-dd-add-ability-to-override-fixes

  1. … 9 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 121 more files in changeset.
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 121 more files in changeset.
Merge branch 'staging' into develop

  1. … 2 more files in changeset.
LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

Done.

Done.

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

Appears to be dialysate to dialyzer flow rate.

Appears to be dialysate to dialyzer flow rate.

Looking at the implementation of this function, it appears that this function is setting dialysateFlowRate to target rate only when delivering dialysate to the dialyzer and to zero in all other cas...

Looking at the implementation of this function, it appears that this function is setting dialysateFlowRate to target rate only when delivering dialysate to the dialyzer and to zero in all other cases. Consider changing variable name to something like dialysateToDialyzerFlowRate and updating function description in header to make this more clear.

0.0F.

0.0F.

Check the current Gen dialysate sub state.

Check the current Gen dialysate sub state.

Please use 0.0F (since its float variable).

Please use 0.0F (since its float variable).

LEAHI-DD-FIRMWARE-LDT-1196_DD: Request for a variable for target Qd rate
LEAHI-DD-FIRMWARE-LDT-1196_DD: Request for a variable for target Qd rate
Why the extra leading zeroes? If you want to ensure the literal is treated like a U32, you can do 0x00000001 or simply 1U, but I suspect the compiler will default to 32 bits anyway.

Why the extra leading zeroes? If you want to ensure the literal is treated like a U32, you can do 0x00000001 or simply 1U, but I suspect the compiler will default to 32 bits anyway.

I believe baro is being moved to the TD firmware. DD will have to get baro readings from TD broadcasts.

I believe baro is being moved to the TD firmware. DD will have to get baro readings from TD broadcasts.

Do you want to add a space for the baro pressure sensor from which we receive from the TD?

Do you want to add a space for the baro pressure sensor from which we receive from the TD?

I have removed multiple M4 valve control across in DD. IO/FP will govern the M4 valve control.

I have removed multiple M4 valve control across in DD. IO/FP will govern the M4 valve control.

LDT-2198 conductivity sensor update

  1. … 10 more files in changeset.
fixed. thanks

fixed. thanks

fixed. thanks

fixed. thanks