FPModes

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
My understanding is that Standby should stop all pumps and heaters, including D108. Although the D108 driver implementation is not available yet, I thought keeping this call would preserve the inte...

My understanding is that Standby should stop all pumps and heaters, including D108. Although the D108 driver implementation is not available yet, I thought keeping this call would preserve the intended Standby behavior and allow it to work once driver support is added. Could you please let me know if there is any concern with leaving it in place for now?

Michael confirmed that FP will eventually support two firmware-controlled sampling modes: Filter Sample and RO Permeate Sample. Since the flow paths are not defined yet, we will keep a generic plac...

Michael confirmed that FP will eventually support two firmware-controlled sampling modes: Filter Sample and RO Permeate Sample. Since the flow paths are not defined yet, we will keep a generic placeholder for the sampling mode/state and update the implementation and requirements once the feature is better defined.

Add TODO or revert back changes.

Add TODO or revert back changes.

Delete empty line

Delete empty line

Add the comment.

Add the comment.

Align the indent throughout.

Align the indent throughout.

Add comment.

Add comment.

Space before and after paranthesis.

Space before and after paranthesis.

If debug is complete, do you want to revert back to actual values? if you still need it for some more time, please add TODO comment.

If debug is complete, do you want to revert back to actual values? if you still need it for some more time, please add TODO comment.

Update the comment.

Update the comment.

Aling the indentation of value field.

Aling the indentation of value field.

Align the indentation.

Align the indentation.

LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
LEAHI-DD-FIRMWARE-LDT-4873_(Request) Add config to disable conductive level sensor fault
LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
you need to bring in the new set of valves here as well.

you need to bring in the new set of valves here as well.

I would recommend commenting the stopping D108 heater here, as there is no implementation yet at driver level. Add a TODO comment for now.

I would recommend commenting the stopping D108 heater here, as there is no implementation yet at driver level. Add a TODO comment for now.

We don't have a specific DD permeate sample mode implementation yet. We need to align with Michael on this. Looks FP may need a mode to handle permeate request (if FP was not in gen permeate mode b...

We don't have a specific DD permeate sample mode implementation yet. We need to align with Michael on this. Looks FP may need a mode to handle permeate request (if FP was not in gen permeate mode by TD request already).

Align the indent. Replace RO to FP.

Align the indent. Replace RO to FP.

LEAHI-DD-FIRMWARE-LDT-4049_Standby - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-4049_Standby - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-DD-FIRMWARE-LDT-4413_Synchronize the Change events content
LEAHI-DD-FIRMWARE-LDT-4413_Synchronize the Change events content
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
a time out for decaying D66 pressure to 3 PSI after D65 closed

a time out for decaying D66 pressure to 3 PSI after D65 closed

remove space after <= and add space end of function call.

remove space after <= and add space end of function call.