dd-firmware / firmware / App / Modes

ModeGenDialysate.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 12:10
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 22 May
11:17 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModeGenDialysate.h
  2. … 18 more files in changeset.
11:11 am

Vendor - TEL - Jashwant Gantyada

10:50 am

Sean Nash and Vinayakam Mani

Thursday 21 May
3:24 pm

Vendor - TEL - Jashwant Gantyada

restored

restored

3:24 pm

Sean Nash

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

3:18 pm

Sean Nash

Should be #ifndef

Should be #ifndef

3:13 pm

Sean Nash

Should be #ifndef I think.

Should be #ifndef I think.

3:06 pm

Sean Nash

Can we make these low priority and 999 rank?

Can we make these low priority and 999 rank?

Sunday 17 May
11:34 pm

Sean Nash

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

11:26 pm

Sean Nash

Details looks weird. Where is inputs and outputs like other function headers?

Details looks weird. Where is inputs and outputs like other function headers?

11:19 pm

Sean Nash

Add a blank line after banner.

Add a blank line after banner.

11:19 pm

Sean Nash

Please restore before you merge to staging.

Please restore before you merge to staging.

11:16 pm

Sean Nash

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

11:14 pm

Sean Nash

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

11:13 pm

Sean Nash

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

11:13 pm

Sean Nash

This definitions has a terrible name (I have no idea what it does) and I think it should be reversed (i.e. alarms are disabled when defined so that a release build will have alarms enabled).

This definitions has a terrible name (I have no idea what it does) and I think it should be reversed (i.e. alarms are disabled when defined so that a release build will have alarms enabled).

Friday 15 May
11:36 am

Vinayakam Mani

align the indent.

align the indent.

11:33 am

Vinayakam Mani

Update the naming for 'balChamberSwPeriod' and 'isBalChamberFillinProgress' as per the assignment.

Update the naming for 'balChamberSwPeriod' and 'isBalChamberFillinProgress' as per the assignment.

Thursday 14 May
7:21 pm

Vendor - TEL - Sameer Poyil

i see some of the code is for building the code , could you please remove all such code ? or create a new branch and push it , it will confuse. while pushing the code , all supporting code for buil...

i see some of the code is for building the code , could you please remove all such code ? or create a new branch and push it , it will confuse. while pushing the code , all supporting code for build / functionality should be removed.

6:02 pm

Vendor - TEL - Sameer Poyil

2:36 pm

Vendor - TEL - Jashwant Gantyada

I had this commented again to push to the develop branch. It is uncommented for my testing.

I had this commented again to push to the develop branch. It is uncommented for my testing.

2:21 pm

Vendor - TEL - Jashwant Gantyada

added TODO above

added TODO above

2:21 pm

Vendor - TEL - Jashwant Gantyada

updated as suggested.

updated as suggested.

2:21 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

2:20 pm

Vendor - TEL - Jashwant Gantyada

updated accordingly.

updated accordingly.

2:20 pm

Vendor - TEL - Jashwant Gantyada

added TODO for all

added TODO for all

2:20 pm

Vendor - TEL - Jashwant Gantyada

makes sense. removed it.

makes sense. removed it.

1:25 pm

Vendor - TEL - Jashwant Gantyada

I think we are using it to send a message to Dialin, to let the tester know whether the command has passed/failed or timed out.

I think we are using it to send a message to Dialin, to let the tester know whether the command has passed/failed or timed out.

1:07 pm

Vendor - TEL - Jashwant Gantyada

restored

restored

Monday 11 May
11:55 am

Vinayakam Mani

Why did we remove this? This is needed for BC Switch only condition.

Why did we remove this? This is needed for BC Switch only condition.