dd-firmware / firmware / App / Services

SystemCommDD.c

Clone Tools

Stats

Commits this week: 2
Total Committers: 4
Last Commit: 12:10
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 27 May
3:43 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./SystemCommDD.c
  2. … 7 more files in changeset.
3:38 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

2:08 pm

Dara Navaei

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

2:07 pm

Dara Navaei

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

2:06 pm

Dara Navaei

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

2:06 pm

Dara Navaei

This file has been updated by HALCoGen automatically.

This file has been updated by HALCoGen automatically.

2:05 pm

Dara Navaei

Done

Done

2:05 pm

Dara Navaei

Done

Done

1:46 pm

Dara Navaei

Done

Done

10:22 am

Sean Nash

Non-Dialin messages should be higher in this list than Dialin messages. Move this above all of the "test" handlers.

Non-Dialin messages should be higher in this list than Dialin messages. Move this above all of the "test" handlers.

10:20 am

Sean Nash

Remove extra copyright block.

Remove extra copyright block.

10:20 am

Sean Nash

These 2 new channels should be using message boxes before Dialin channel message boxes. Align with buffers enum.

These 2 new channels should be using message boxes before Dialin channel message boxes. Align with buffers enum.

10:20 am

Dara Navaei

Merge branch 'staging' into LDT-3272-software-update---dd-firmware

Options
    • -2
    • +8
    ./SystemCommDD.c
  2. … 1 more file in changeset.
10:16 am

Sean Nash

This is auto generated code. How do we keep this code from re-appearing when somebody regenerates this code?

This is auto generated code. How do we keep this code from re-appearing when somebody regenerates this code?

10:02 am

Sean Nash

Same.

Same.

10:02 am

Sean Nash

Same

Same

10:01 am

Sean Nash

We shouldn't delete generated code. Add a #if 0 in this user code section and add a #endif in the user section below the coreEnableFlashEcc() call.

We shouldn't delete generated code. Add a #if 0 in this user code section and add a #endif in the user section below the coreEnableFlashEcc() call.

Friday 22 May
11:17 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./SystemCommDD.c
  2. … 18 more files in changeset.
11:11 am

Vendor - TEL - Jashwant Gantyada

10:50 am

Sean Nash and Vinayakam Mani

Thursday 21 May
3:36 pm

Vendor - TEL - Jashwant Gantyada

LDT-3963 addressed code review comments

Options
    • -1
    • +1
    ./SystemCommDD.c
  2. … 1 more file in changeset.
3:24 pm

Vendor - TEL - Jashwant Gantyada

restored

restored

3:24 pm

Sean Nash

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

3:18 pm

Sean Nash

Should be #ifndef

Should be #ifndef

3:13 pm

Sean Nash

Should be #ifndef I think.

Should be #ifndef I think.

3:06 pm

Sean Nash

Can we make these low priority and 999 rank?

Can we make these low priority and 999 rank?

1:32 pm

Vendor - TEL - Jashwant Gantyada

LDT-3963 addressed code review comments and restored the fault mode transition

Options
    • -2
    • +2
    ./SystemCommDD.c
  2. … 9 more files in changeset.
Sunday 17 May
11:34 pm

Sean Nash

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

11:26 pm

Sean Nash

Details looks weird. Where is inputs and outputs like other function headers?

Details looks weird. Where is inputs and outputs like other function headers?

11:19 pm

Sean Nash

Add a blank line after banner.

Add a blank line after banner.