dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 37
Total Committers: 16
Last Commit: 23 Apr
Commits this week: 37

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 02 Mar
11:40 am

Michael Garthwaite

LDT-3372: code review comments.

Options
    • -13
    • +10
    ./Drivers/ConductivityTeensy.c
11:40 am

Michael Garthwaite

fixed.

fixed.

11:39 am

Michael Garthwaite

then we return false as expected

then we return false as expected

11:33 am

Michael Garthwaite

These are correct variable names based on their coefficient names in calculations of conductivity.

These are correct variable names based on their coefficient names in calculations of conductivity.

11:31 am

Michael Garthwaite

Can you clarify? this is allowing us to switch conductivity calculations based on the needs of the dialin user. ( systems team testing for accuracy )

Can you clarify? this is allowing us to switch conductivity calculations based on the needs of the dialin user. ( systems team testing for accuracy )

11:30 am

Michael Garthwaite

removed. thanks!

removed. thanks!

11:30 am

Michael Garthwaite

parameter check happens in getTeensyCondId

parameter check happens in getTeensyCondId

11:25 am

Michael Garthwaite

Yes as it is a way for us to identify if the teensy is not responding to us correctly. This along with no LED activity on the board helps us identify teensy failures

Yes as it is a way for us to identify if the teensy is not responding to us correctly. This along with no LED activity on the board helps us identify teensy failures

11:24 am

Michael Garthwaite

Not for this situation since its an array of structs and looks like a 2d array. Please see static const FP_OP_MODE_T MODE_TRANSITION_TABLE in FPOperationModes.c static const DD_OP_MODE_T MODE_TRAN...

Not for this situation since its an array of structs and looks like a 2d array. Please see

static const FP_OP_MODE_T MODE_TRANSITION_TABLE in FPOperationModes.c
static const DD_OP_MODE_T MODE_TRANSITION_TABLE in OperationModes.c
static PI_CONTROLLER_T piControllers in PIControllers.c ( FWCommon repo )

11:17 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
11:15 am

Michael Garthwaite

LDT-3372: fixes to conductivity calculation.

Options
    • -5
    • +5
    ./Drivers/ConductivityTeensy.c
9:58 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
9:56 am

Vinayakam Mani

LDT-1477 merge into develop

Options
    • -4
    • +20
    ./Controllers/BalancingChamber.c
9:52 am

Vinayakam Mani

LDT-1477 trimmer heater target update

Options
    • -4
    • +20
    ./Controllers/BalancingChamber.c
    • -2
    • +16
    ./Modes/ModeGenDialysate.c
8:13 am

Vendor - TEL - Sameer Poyil

its unsigned integer , no need to check -ve value

its unsigned integer , no need to check -ve value

Friday 27 Feb
11:28 am

Vendor - TEL - Arpita Srivastava

LDT-1195: Updated balancing chamber switching request flags names and definitions.

Options
    • -89
    • +62
    ./Controllers/BalancingChamber.c
    • -3
    • +2
    ./Controllers/BalancingChamber.h
    • -0
    • +2
    ./Modes/ModeFault.c
    • -17
    • +22
    ./Modes/ModeGenDialysate.c
    • -0
    • +2
    ./Modes/ModeInitPOST.c
    • -1
    • +2
    ./Modes/ModePostGenDialysate.c
    • -1
    • +2
    ./Modes/ModePreGenDialysate.c
    • -0
    • +2
    ./Modes/ModeService.c
    • -5
    • +10
    ./Modes/ModeStandby.c
7:36 am

Vendor - TEL - Sameer Poyil

is this function required?

is this function required?

7:32 am

Vendor - TEL - Sameer Poyil

remove all commented code

remove all commented code

7:31 am

Vendor - TEL - Sameer Poyil

good to have doxygen comments on right hand side

good to have doxygen comments on right hand side

7:26 am

Vendor - TEL - Sameer Poyil

what if user send -ve values ?

what if user send -ve values ?

7:24 am

Vendor - TEL - Sameer Poyil

Where is len used ?

Where is len used ?

7:08 am

Vendor - TEL - Sameer Poyil

its a public function , input parameter check required, apply to all public functions

its a public function , input parameter check required, apply to all public functions

7:07 am

Vendor - TEL - Sameer Poyil

need documentation for this two approach, what is the merits ? when to use it ?

need documentation for this two approach, what is the merits ? when to use it ?

7:06 am

Vendor - TEL - Sameer Poyil

need math formula as documentation

need math formula as documentation

7:00 am

Vendor - TEL - Sameer Poyil

Need mathematical formula as documentation and need to explain each term

Need mathematical formula as documentation and need to explain each term

6:56 am

Vendor - TEL - Sameer Poyil

Need a detailed name for variable - apply for all other

Need a detailed name for variable - apply for all other

Thursday 26 Feb
4:45 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
4:43 pm

Vinayakam Mani

LDT-1477 resolving merge conflicts

Options
    • -0
    • +2
    ./Controllers/RinsePump.c
    • -1
    • +0
    ./Services/FpgaDD.c
    • -3
    • +1
    ./Services/Messaging.c
4:31 pm

Vinayakam Mani

LDT-1477 minor updates

Options
    • -1
    • +1
    ./Services/FpgaDD.c
    • -1
    • +1
    ./Services/Messaging.c
    • -1
    • +0
    ./Services/TDInterface.c
2:24 pm

Michael Garthwaite

LDT-2004: fixes and review changes for v2 conductivity sensors.

Options
    • -1
    • +1
    ./Controllers/Heaters.c
    • -10
    • +10
    ./Drivers/ConductivitySensors.c
    • -2
    • +2
    ./Monitors/Conductivity.c
    • -6
    • +6
    ./Monitors/Temperature.c
    • -3
    • +3
    ./Services/FpgaDD.c