dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 43
Total Committers: 16
Last Commit: 14:11
Commits this week: 43

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 Mar
9:24 am

Raghu Kallala

LDT-3603 addressed review comments and added missing code

Options
    • -0
    • +62
    ./Modes/FPModes/FPModeFault.c
    • -1
    • +4
    ./Modes/FPModes/FPModeFault.h
    • -0
    • +52
    ./Modes/FPModes/FPModeStandby.c
    • -1
    • +2
    ./Modes/FPModes/FPModeStandby.h
    • -88
    • +103
    ./Modes/FPModes/FPOperationModes.c
    • -48
    • +55
    ./Modes/FPModes/ModeGenPermeate.c
    • -2
    • +2
    ./Modes/FPModes/ModeGenPermeate.h
    • -50
    • +55
    ./Modes/FPModes/ModeGenPermeateDefeatured.c
    • -3
    • +2
    ./Modes/FPModes/ModeGenPermeateDefeatured.h
    • -61
    • +67
    ./Modes/FPModes/ModePreGenPermeate.c
    • -3
    • +3
    ./Modes/FPModes/ModePreGenPermeate.h
    • -51
    • +57
    ./Modes/FPModes/ModePreGenPermeateDefeatured.c
    • -2
    • +2
    ./Modes/FPModes/ModePreGenPermeateDefeatured.h
7:21 am

Raghu Kallala

That's a question for me, will that be required? Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required) Init don't have any and service is not defined yet

That's a question for me, will that be required?

Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required)
Init don't have any and service is not defined yet

6:37 am

Raghu Kallala

Updated

Updated

6:37 am

Raghu Kallala

Updated

Updated

6:36 am

Raghu Kallala

Changed and left them as static, as we don't need these outside this unit

Changed and left them as static, as we don't need these outside this unit

6:27 am

Raghu Kallala

You are right, (missed that while duplicating the functions)

You are right, (missed that while duplicating the functions)

Wednesday 11 Mar
5:09 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
5:07 pm

Vendor - TEL - Jashwant Gantyada

Merge branch 'LDT-3103-implement-closed-loop-control-f' into develop

Options
    • -1
    • +2
    ./Controllers/BalancingChamber.c
5:06 pm

Vendor - TEL - Jashwant Gantyada

LDT-3103 fixed lower deadband issues with d48 speed

Options
    • -1
    • +2
    ./Controllers/BalancingChamber.c
2:37 pm

Sean Nash

if ( TRUE == result )

if ( TRUE == result )

2:34 pm

Sean Nash

Since both states require no special handling, remove breaks and group with default - all modes.

Since both states require no special handling, remove breaks and group with default - all modes.

2:34 pm

Sean Nash

Remove comment.

Remove comment.

2:31 pm

Sean Nash

Add comment that all of these states require no special handling.

Add comment that all of these states require no special handling.

2:27 pm

Sean Nash

I think these functions (validate and signal) should be "test" functions and moved down to Dialin test functions section below - for all modes.

I think these functions (validate and signal) should be "test" functions and moved down to Dialin test functions section below - for all modes.

2:25 pm

Sean Nash

Add comment that no action is required for these modes - defaulting to invalid request.

Add comment that no action is required for these modes - defaulting to invalid request.

2:24 pm

Sean Nash

I think this switch should be on requested mode - we haven't changed modes yet.

I think this switch should be on requested mode - we haven't changed modes yet.

2:22 pm

Sean Nash

We have 1 param (and probably should have 2 params - requested mode and submode).

We have 1 param (and probably should have 2 params - requested mode and submode).

2:22 pm

Sean Nash

currentMode is an input.

currentMode is an input.

2:21 pm

Sean Nash

I think this validate function needs to know the requested mode as well - should have 2 params.

I think this validate function needs to know the requested mode as well - should have 2 params.

2:18 pm

Sean Nash

Are we not supporting sub mode requests for these modes?

Are we not supporting sub mode requests for these modes?

2:15 pm

Sean Nash

if ( TRUE == testChangeSubMode )

if ( TRUE == testChangeSubMode )

2:13 pm

Sean Nash

I think these 2 functions are in support of Dialin only, so should be prefixed with "test" as well.

I think these 2 functions are in support of Dialin only, so should be prefixed with "test" as well.

2:09 pm

Sean Nash

I believe we will want BC control during ISO UF state.

I believe we will want BC control during ISO UF state.

2:07 pm

Sean Nash

Remove blank line and comment saying we're not doing anything (because now we're doing something).

Remove blank line and comment saying we're not doing anything (because now we're doing something).

2:05 pm

Sean Nash

isBalChamberSwitchingOffRequested is an output.

isBalChamberSwitchingOffRequested is an output.

2:03 pm

Sean Nash

Should we set the other switch to FALSE, just in case?

Should we set the other switch to FALSE, just in case?

10:08 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
9:48 am

Vendor - TEL - Jashwant Gantyada

Merge branch 'LDT-3103-implement-closed-loop-control-f' into develop

Options
    • -267
    • +363
    ./Controllers/BalancingChamber.c
    • -2
    • +2
    ./Controllers/BalancingChamber.h
    • -27
    • +145
    ./Controllers/DialysatePumps.c
    • -6
    • +8
    ./Controllers/DialysatePumps.h
    • -3
    • +1
    ./DDCommon.h
    • -4
    • +78
    ./Modes/ModeGenDialysate.c
9:31 am

Vendor - TEL - Jashwant Gantyada

LDT-3103 merged latest staging

Options
    • -0
    • +3
    ./Controllers/BalancingChamber.c
    • -1
    • +1
    ./DDCommon.h
9:22 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h