dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 43
Total Committers: 16
Last Commit: 14:11
Commits this week: 43

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 Mar
12:22 pm

Vendor - TEL - Jashwant Gantyada

LDT-3103 addressed code review comments and changes

Options
    • -27
    • +26
    ./Controllers/BalancingChamber.c
    • -74
    • +38
    ./Controllers/DialysatePumps.c
    • -2
    • +2
    ./Controllers/DialysatePumps.h
    • -1
    • +0
    ./DDCommon.h
    • -3
    • +16
    ./Modes/ModeGenDialysate.c
    • -5
    • +3
    ./Services/FpgaDD.c
11:59 am

Michael Garthwaite

LDT-2004: fixes to v2 conductivity sensors during unit 5 bring up

Options
    • -17
    • +19
    ./Drivers/ConductivitySensors.c
10:50 am

Sean Nash

I don't see a TODO. If we intend to uncomment this line out later, we should add a TODO comment to the right as a reminder. If we do not intend to uncomment this later, we should just delete it.

I don't see a TODO. If we intend to uncomment this line out later, we should add a TODO comment to the right as a reminder. If we do not intend to uncomment this later, we should just delete it.

10:48 am

Sean Nash

Fix alignment of "=".

Fix alignment of "=".

10:47 am

Sean Nash

Add a param line in this header.

Add a param line in this header.

10:47 am

Sean Nash

Can we delete this commented out line?

Can we delete this commented out line?

10:46 am

Sean Nash

Add a params line in function header.

Add a params line in function header.

10:45 am

Sean Nash

Why did we change this spelling? Now it's wrong.

Why did we change this spelling? Now it's wrong.

10:44 am

Sean Nash

Can we delete this commented out line?

Can we delete this commented out line?

10:43 am

Sean Nash

Keep this blank line.

Keep this blank line.

10:41 am

Sean Nash

Should be before ModeStandby.

Should be before ModeStandby.

10:40 am

Sean Nash

I see we are doing this same logic in multiple places. Can we just have a function that returns the minimum speed for the given dialysate pump?

I see we are doing this same logic in multiple places. Can we just have a function that returns the minimum speed for the given dialysate pump?

10:37 am

Sean Nash

Remove blank line.

Remove blank line.

10:37 am

Sean Nash

Remove blank line.

Remove blank line.

10:36 am

Sean Nash

Should assign a local variable to this equation and then return the variable. Can this equation result in a negative number? If so, we should handle that first before converting to unsigned int. Al...

Should assign a local variable to this equation and then return the variable.
Can this equation result in a negative number? If so, we should handle that first before converting to unsigned int.
Also, do we want to do any rounding when converting float to integer?

10:32 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:32 am

Vendor - TEL - Jashwant Gantyada

The TODO has already been mentioned in staging. They have it commented out for strike and hold behavior.

The TODO has already been mentioned in staging. They have it commented out for strike and hold behavior.

9:24 am

Raghu Kallala

LDT-3603 addressed review comments and added missing code

Options
    • -0
    • +62
    ./Modes/FPModes/FPModeFault.c
    • -1
    • +4
    ./Modes/FPModes/FPModeFault.h
    • -0
    • +52
    ./Modes/FPModes/FPModeStandby.c
    • -1
    • +2
    ./Modes/FPModes/FPModeStandby.h
    • -88
    • +103
    ./Modes/FPModes/FPOperationModes.c
    • -48
    • +55
    ./Modes/FPModes/ModeGenPermeate.c
    • -2
    • +2
    ./Modes/FPModes/ModeGenPermeate.h
    • -50
    • +55
    ./Modes/FPModes/ModeGenPermeateDefeatured.c
    • -3
    • +2
    ./Modes/FPModes/ModeGenPermeateDefeatured.h
    • -61
    • +67
    ./Modes/FPModes/ModePreGenPermeate.c
    • -3
    • +3
    ./Modes/FPModes/ModePreGenPermeate.h
    • -51
    • +57
    ./Modes/FPModes/ModePreGenPermeateDefeatured.c
    • -2
    • +2
    ./Modes/FPModes/ModePreGenPermeateDefeatured.h
7:21 am

Raghu Kallala

That's a question for me, will that be required? Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required) Init don't have any and service is not defined yet

That's a question for me, will that be required?

Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required)
Init don't have any and service is not defined yet

6:37 am

Raghu Kallala

Updated

Updated

6:37 am

Raghu Kallala

Updated

Updated

6:36 am

Raghu Kallala

Changed and left them as static, as we don't need these outside this unit

Changed and left them as static, as we don't need these outside this unit

6:27 am

Raghu Kallala

You are right, (missed that while duplicating the functions)

You are right, (missed that while duplicating the functions)

Wednesday 11 Mar
5:09 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
5:07 pm

Vendor - TEL - Jashwant Gantyada

Merge branch 'LDT-3103-implement-closed-loop-control-f' into develop

Options
    • -1
    • +2
    ./Controllers/BalancingChamber.c
5:06 pm

Vendor - TEL - Jashwant Gantyada

LDT-3103 fixed lower deadband issues with d48 speed

Options
    • -1
    • +2
    ./Controllers/BalancingChamber.c
2:37 pm

Sean Nash

if ( TRUE == result )

if ( TRUE == result )

2:34 pm

Sean Nash

Since both states require no special handling, remove breaks and group with default - all modes.

Since both states require no special handling, remove breaks and group with default - all modes.

2:34 pm

Sean Nash

Remove comment.

Remove comment.

2:31 pm

Sean Nash

Add comment that all of these states require no special handling.

Add comment that all of these states require no special handling.