dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 42
Total Committers: 16
Last Commit: 13 Mar
Commits this week: 42

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 Mar
9:58 pm

Vendor - TEL - Jashwant Gantyada

LDY-3103 addressed code review comments

Options
    • -20
    • +1
    ./Controllers/BalancingChamber.c
7:25 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
7:25 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Modes/ModeGenDialysate.c
    • -2
    • +2
    ./Modes/ModeGenDialysate.h
6:14 pm

Vinayakam Mani

Result is a BOOL variable, use FALSE.

Result is a BOOL variable, use FALSE.

5:24 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

5:24 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

5:24 pm

Vendor - TEL - Jashwant Gantyada

done

done

5:24 pm

Vendor - TEL - Jashwant Gantyada

changed accordingly.

changed accordingly.

5:23 pm

Vendor - TEL - Jashwant Gantyada

LDT-3103 addressed code review comments

Options
    • -8
    • +21
    ./Controllers/BalancingChamber.c
    • -2
    • +2
    ./Modes/ModeGenDialysate.c
5:18 pm

Vinayakam Mani and Sean Nash

5:12 pm

Vendor - TEL - Praneeth Bunne

Fix getFreshDialPumpInitialRpm function name and brief inputs comment

Options
    • -9
    • +9
    ./Modes/ModeGenDialysate.c
4:53 pm

Sean Nash

I think the 2 initial rpm constants are inputs. The test config we would normally not include.

I think the 2 initial rpm constants are inputs. The test config we would normally not include.

4:52 pm

Sean Nash

I think the word "Initial" should be in the function name (i.e. getFreshDialPumpInitialRpm).

I think the word "Initial" should be in the function name (i.e. getFreshDialPumpInitialRpm).

4:44 pm

Sean Nash

Why did this move? It needs to be in the nth row of the table (n = enum #) so that the enum will index to it in this table.

Why did this move? It needs to be in the nth row of the table (n = enum #) so that the enum will index to it in this table.

4:43 pm

Vinayakam Mani

4:42 pm

Vendor - TEL - Sameer Poyil

align

align

4:42 pm

Vendor - TEL - Sameer Poyil

align

align

4:41 pm

Vendor - TEL - Sameer Poyil

please do not use complicated statement in if condition. take out this logic before if condition and use BOOL variable.

please do not use complicated statement in if condition. take out this logic before if condition and use BOOL variable.

4:38 pm

Vendor - TEL - Sameer Poyil

comment should start with capital letter

comment should start with capital letter

4:36 pm

Vendor - TEL - Jashwant Gantyada

I see the TODO in staging and also, I see it in my branch, but I don't see it on this review.

I see the TODO in staging and also, I see it in my branch, but I don't see it on this review.

4:34 pm

Vendor - TEL - Jashwant Gantyada

done

done

4:34 pm

Vendor - TEL - Jashwant Gantyada

added

added

4:34 pm

Vendor - TEL - Jashwant Gantyada

declared a fill timeout alarm

declared a fill timeout alarm

4:33 pm

Vendor - TEL - Jashwant Gantyada

corrected.

corrected.

4:33 pm

Vendor - TEL - Jashwant Gantyada

done

done

4:33 pm

Vendor - TEL - Jashwant Gantyada

done

done

4:32 pm

Vendor - TEL - Jashwant Gantyada

LDT-3103 addressed code review comments

Options
    • -2
    • +31
    ./Controllers/BalancingChamber.c
    • -1
    • +1
    ./Controllers/DialysatePumps.h
    • -4
    • +4
    ./Modes/ModeGenDialysate.c
    • -3
    • +3
    ./Services/FpgaDD.c
4:32 pm

Sean Nash

4:21 pm

Vendor - TEL - Jashwant Gantyada

in the checkSpentFillComplete function we look at the current and the previous pressure sample and calculate the difference to get the adjusted speed for d48 pump.

in the checkSpentFillComplete function we look at the current and the previous pressure sample and calculate the difference to get the adjusted speed for d48 pump.

4:17 pm

Vendor - TEL - Jashwant Gantyada

I am currently using all of them.

I am currently using all of them.