dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 32
Total Committers: 16
Last Commit: 15:32
Commits this week: 32

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 15 Apr
7:52 am

Michael Garthwaite

LDT-3218: code review comments

Options
    • -0
    • +1
    ./Controllers/ROPump.c
    • -3
    • +4
    ./Controllers/Valves.c
    • -1
    • +1
    ./Controllers/Valves.h
    • -1
    • +1
    ./Services/FpgaDD.c
7:45 am

Michael Garthwaite

fixed

fixed

7:45 am

Michael Garthwaite

fixed

fixed

7:45 am

Michael Garthwaite

fixed

fixed

7:45 am

Michael Garthwaite

LDT-3777: code review comments

Options
    • -0
    • +3
    ./Drivers/ConductivitySensors.c
Tuesday 14 Apr
9:23 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
9:22 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Controllers/BalancingChamber.c
    • -2
    • +2
    ./Controllers/Heaters.c
    • -1
    • +1
    ./Controllers/Heaters.h
    • -2
    • +2
    ./Controllers/RinsePump.c
    • -1
    • +1
    ./Controllers/Ultrafiltration.c
    • -1
    • +1
    ./DDCommon.h
    • -2
    • +2
    ./Drivers/TemperatureSensors.c
    • -2
    • +2
    ./Modes/ModeGenDialysate.c
    • -2
    • +2
    ./Modes/ModeGenDialysate.h
    • -2
    • +2
    ./Monitors/Temperature.c
    • -1
    • +1
    ./Monitors/Temperature.h
    • -2
    • +2
    ./Services/AlarmMgmtSWFaults.h
    • -2
    • +2
    ./Services/Messaging.c
7:47 pm

Sean Nash and Vendor - TEL - Sameer Poyil

7:28 pm

Vinayakam Mani

Same comment applies here (removing resetPIController).

Same comment applies here (removing resetPIController).

7:18 pm

Vinayakam Mani

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

7:14 pm

Vinayakam Mani

Maintain space after and before parenthesis across the file.

Maintain space after and before parenthesis across the file.

7:11 pm

Vinayakam Mani

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across th...

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across the file.

7:02 pm

Vinayakam Mani

Remove this comment.

Remove this comment.

6:58 pm

Vinayakam Mani

You may use getF32OverrideValue for consistency (across the file).

You may use getF32OverrideValue for consistency (across the file).

6:51 pm

Vinayakam Mani

The resetPIController is already invoked in InitializePIController with the InitialControlSignal. Instead of 0.0F, pass the STD_BICARB_DOSING as initialControlSignal ( in InitializePIController)

The resetPIController is already invoked in InitializePIController with the InitialControlSignal. Instead of 0.0F, pass the STD_BICARB_DOSING as initialControlSignal ( in InitializePIController)

6:21 pm

Vinayakam Mani

This is being repeated.

This is being repeated.

6:20 pm

Vinayakam Mani

Please add comment. if it is not being used, delete it.

Please add comment. if it is not being used, delete it.

6:19 pm

Vinayakam Mani

Can this be reused from ConcentratePumps.h?

Can this be reused from ConcentratePumps.h?

6:16 pm

Vinayakam Mani

Add a space after and before parenthesis.

Add a space after and before parenthesis.

6:14 pm

Vinayakam Mani

This comment is same as previous lines comment, update something similar to 'Maximum pressure allowed at bicart fill during supply process/state"

This comment is same as previous lines comment, update something similar to 'Maximum pressure allowed at bicart fill during supply process/state"

6:10 pm

Vinayakam Mani

Add comment. is this the pressure offset for 11 PSI, if so, this offset supposed to be 1?

Add comment. is this the pressure offset for 11 PSI, if so, this offset supposed to be 1?

6:07 pm

Vinayakam Mani

Please update this value with high resolution ( for example, 0.67 to 0.666666667 and 1.15 to 1.146666667? ).

Please update this value with high resolution ( for example, 0.67 to 0.666666667 and 1.15 to 1.146666667? ).

5:28 pm

Sean Nash

So I think this compiler will give you 64 bit if you ask for long. Did you intend it to be 64 bit? If not, you can just use the BIT_BY_POS macro above.

So I think this compiler will give you 64 bit if you ask for long. Did you intend it to be 64 bit? If not, you can just use the BIT_BY_POS macro above.

5:15 pm

Vendor - TEL - Sameer Poyil

LDT-2004 converting tab to spaces

Options
    • -1
    • +1
    ./Controllers/DryBiCart.c
5:05 pm

Vendor - TEL - Sameer Poyil

LDT-2004 drybicart closed loop control

Options
    • -6
    • +6
    ./Monitors/Conductivity.c
4:39 pm

Vinayakam Mani

LDT-3352 resolving merge issues

Options
    • -78
    • +428
    ./Controllers/BalancingChamber.c
    • -7
    • +14
    ./Controllers/Heaters.c
    • -1
    • +2
    ./Controllers/RinsePump.c
    • -14
    • +29
    ./Controllers/Ultrafiltration.c
    • -6
    • +3
    ./DDCommon.h
    • -16
    • +40
    ./Modes/ModeGenDialysate.c
    • -2
    • +1
    ./Modes/ModeGenDialysate.h
    • -28
    • +26
    ./Monitors/Temperature.c
    • -2
    • +2
    ./Monitors/Temperature.h
    • -4
    • +5
    ./Services/AlarmMgmtSWFaults.h
    • -25
    • +20
    ./Services/Messaging.c
4:15 pm

Vendor - TEL - Sameer Poyil

LDT-2004 addressed review comments

Options
    • -7
    • +9
    ./Controllers/BalancingChamber.c
    • -18
    • +7
    ./Controllers/DryBiCart.c
    • -4
    • +1
    ./Controllers/DryBiCart.h
    • -4
    • +2
    ./Monitors/Conductivity.c
4:11 pm

Vendor - TEL - Sameer Poyil

Removing it now. will introduce it later if required

Removing it now. will introduce it later if required

3:59 pm

Vendor - TEL - Sameer Poyil

will finalize it when ocean spray logic is tested

will finalize it when ocean spray logic is tested

3:57 pm

Vendor - TEL - Sameer Poyil

dryBicartState is top level state machine which is different data type. removed dryBicartSubstate

dryBicartState is top level state machine which is different data type. removed dryBicartSubstate