dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 27
Total Committers: 17
Last Commit: 01 Jun
Commits this week: 27

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 01 Jun
9:20 am

Michael Garthwaite

LDT-4001: code review comments.

Options
    • -5
    • +6
    ./Controllers/SubstitutionPump.c
Friday 29 May
6:29 pm

Vinayakam Mani

6:29 pm

Vinayakam Mani

This needs TD source update and also dialin update, keep informed system team about this change as this would impact DD demo running.

This needs TD source update and also dialin update, keep informed system team about this change as this would impact DD demo running.

6:25 pm

Vinayakam Mani

Please add HDF Pump speed register and add a monitor in the substitution pump controller to compare against the target speed and if the difference is out of range, trigger an alarm.

Please add HDF Pump speed register and add a monitor in the substitution pump controller to compare against the target speed and if the difference is out of range, trigger an alarm.

6:20 pm

Vinayakam Mani

Substitution pump

Substitution pump

2:48 pm

Sean Nash

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

2:48 pm

Sean Nash

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

2:03 pm

Vinayakam Mani

Missing comment.

Missing comment.

2:01 pm

Vinayakam Mani

update comment. next one as well.

update comment. next one as well.

2:00 pm

Vinayakam Mani

blank line after the banner and maintain alphabetical order of include files.

blank line after the banner and maintain alphabetical order of include files.

12:10 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
12:08 pm

Vinayakam Mani

LDT-3958 resoving merge issues

Options
    • -24
    • +288
    ./Controllers/Heaters.c
    • -7
    • +4
    ./DDCommon.h
    • -2
    • +2
    ./Monitors/Conductivity.c
    • -5
    • +1
    ./Monitors/Temperature.c
11:57 am

Michael Garthwaite

LDT-4001: previous CR comments. updates to TD interface and messaging

Options
    • -34
    • +56
    ./Controllers/SubstitutionPump.c
    • -9
    • +8
    ./Controllers/SubstitutionPump.h
    • -0
    • +4
    ./Services/Messaging.c
    • -1
    • +1
    ./Services/TDInterface.c
11:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
10:58 am

Vinayakam Mani

Done.

Done.

10:55 am

Vinayakam Mani

LDT-3958 disabling blood leak alarm

Options
    • -1
    • +1
    ./DDCommon.h
10:47 am

Michael Garthwaite

LDT-4001: fixes and merges from previous working branch.

Options
    • -1
    • +1
    ./Controllers/RinsePump.c
    • -0
    • +73
    ./Controllers/SubstitutionPump.h
    • -6
    • +0
    ./Monitors/Conductivity.c
    • -1
    • +3
    ./Services/FpgaDD.c
    • -0
    • +4
    ./Services/FpgaDD.h
    • -0
    • +2
    ./Services/TDInterface.c
10:13 am

Michael Garthwaite

LDT-4000: changed beta 2.0 test config to beta 1.9 test config

Options
    • -7
    • +7
    ./Controllers/Heaters.c
    • -9
    • +4
    ./Controllers/RinsePump.c
    • -4
    • +4
    ./Monitors/Conductivity.c
    • -24
    • +22
    ./Monitors/Level.c
    • -12
    • +12
    ./Monitors/Temperature.c
    • -27
    • +93
    ./Services/FpgaDD.c
10:07 am

Vendor - TEL - Jashwant Gantyada

10:06 am

Vendor - TEL - Jashwant Gantyada

I think we also need this to be uncommented, as we were running into an alarm because of this.

I think we also need this to be uncommented, as we were running into an alarm because of this.

9:48 am

Vinayakam Mani

LDT-3958 disabling few alarms

Options
    • -2
    • +2
    ./DDCommon.h
9:45 am

Vinayakam Mani

LDT-3958 alarm disabling

Options
    • -3
    • +3
    ./DDCommon.h
9:43 am

Vinayakam Mani

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

9:41 am

Vinayakam Mani

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

9:41 am

Vinayakam Mani

as discussed, these were outcome of the test results. we will review these gains with latest controller.

as discussed, these were outcome of the test results. we will review these gains with latest controller.

9:40 am

Vinayakam Mani

Done.

Done.

9:40 am

Vinayakam Mani

Done.

Done.

Thursday 28 May
6:02 pm

Vinayakam Mani

LDT-3958 heater control update

Options
    • -15
    • +1
    ./Controllers/Heaters.c
    • -2
    • +2
    ./Monitors/Conductivity.c
    • -5
    • +1
    ./Monitors/Temperature.c
    • -0
    • +1
    ./Monitors/Temperature.h
5:03 pm

Vinayakam Mani

LDT-3958 resolving merge issues

Options
    • -9
    • +18
    ./DDCommon.h
    • -10
    • +31
    ./Modes/ModeGenDialysate.c
    • -2
    • +7
    ./Monitors/Temperature.c
1:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4: