dd-firmware / firmware

App

Clone Tools

Stats

Commits this week: 74
Total Committers: 20
Last Commit: 17:13
Commits this week: 74

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 27 Jul
10:06 pm

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

We are checking level status 3 times in same function. So Vinay suggested to use local variable to avoid the inconsistent states across the function.

We are checking level status 3 times in same function. So Vinay suggested to use local variable to avoid the inconsistent states across the function.

10:00 pm

Vendor - TEL - Jashwant Gantyada

No, it isn't. We are going to fault mode on that alarm and Vinay has asked me to comment it out as this needs further testing.

No, it isn't. We are going to fault mode on that alarm and Vinay has asked me to comment it out as this needs further testing.

4:13 pm

Sean Nash

Remove leading space before void.

Remove leading space before void.

4:13 pm

Sean Nash

Is issue resolved? Can we revert now?

Is issue resolved? Can we revert now?

4:12 pm

Sean Nash

Also an input I think.

Also an input I think.

3:58 pm

Sean Nash

keep a blank line between declaration(s) and code.

keep a blank line between declaration(s) and code.

3:57 pm

Sean Nash

If level can be overridden, you should use get function.

If level can be overridden, you should use get function.

3:55 pm

Sean Nash

Add blank line before banner.

Add blank line before banner.

3:20 pm

Vinayakam Mani

We made an implementation in such a way that when D65 is opened, D80 needs to be closed. Same way D80 is opened, D65 to be closed.

We made an implementation in such a way that when D65 is opened, D80 needs to be closed. Same way D80 is opened, D65 to be closed.

3:15 pm

Vinayakam Mani

That's the worst-case timeout decided by team.

That's the worst-case timeout decided by team.

2:29 pm

Vinayakam Mani and Sean Nash

2:22 pm

Vinayakam Mani

you need to bring in the new set of valves here as well.

you need to bring in the new set of valves here as well.

2:21 pm

Vinayakam Mani

I would recommend commenting the stopping D108 heater here, as there is no implementation yet at driver level. Add a TODO comment for now.

I would recommend commenting the stopping D108 heater here, as there is no implementation yet at driver level. Add a TODO comment for now.

2:15 pm

Vinayakam Mani

We don't have a specific DD permeate sample mode implementation yet. We need to align with Michael on this. Looks FP may need a mode to handle permeate request (if FP was not in gen permeate mode b...

We don't have a specific DD permeate sample mode implementation yet. We need to align with Michael on this. Looks FP may need a mode to handle permeate request (if FP was not in gen permeate mode by TD request already).

1:43 pm

Vinayakam Mani

Align the indent. Replace RO to FP.

Align the indent. Replace RO to FP.

11:21 am

Vendor - TEL - Arpita Srivastava

Added but crucible is not showing this change. Please check bitbucket.

Added but crucible is not showing this change. Please check bitbucket.

11:17 am

Vendor - TEL - Arpita Srivastava

These variables are correctly initialized to the first enum in the list.

These variables are correctly initialized to the first enum in the list.

11:16 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

11:16 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:15 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:14 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

8:29 am

Vendor - TEL - Jashwant Gantyada

This was added by Vinay to force the chamber F filling.

This was added by Vinay to force the chamber F filling.

8:27 am

Vendor - TEL - Jashwant Gantyada

It was changed by Vinay as part of the Conductivity spikes issue.

It was changed by Vinay as part of the Conductivity spikes issue.

Sunday 26 Jul
10:01 am

Vendor - TEL - Sameer Poyil

This is a problem, when lower cart pressure, D80 closes and if it is not reached upper cart pressure, it won't open D80

This is a problem, when lower cart pressure, D80 closes and if it is not reached upper cart pressure, it won't open D80

9:56 am

Vendor - TEL - Sameer Poyil

Why do we need 1 minutes of D80 opening ? is it not filling withing 10 seconds ?

Why do we need 1 minutes of D80 opening ? is it not filling withing 10 seconds ?

9:45 am

Vendor - TEL - Sameer Poyil

bicarbChamberLevel is a local variable and not an input

bicarbChamberLevel is a local variable and not an input

9:44 am

Vendor - TEL - Sameer Poyil

This is not required , we should design the state machine properly to handle chamber low level

This is not required , we should design the state machine properly to handle chamber low level

9:42 am

Vendor - TEL - Sameer Poyil

This is not the correct order for state machine,

This is not the correct order for state machine,

Friday 24 Jul
10:11 am

Vinayakam Mani

At end of transition, do you want to initialize the totalSpentChamberFill reset to zero?

At end of transition, do you want to initialize the totalSpentChamberFill reset to zero?

10:07 am

Vinayakam Mani

Could you use SpentChamberLevel here, instead calling the getLevelStatus function again? Same for next conditions check as well ( line:889)

Could you use SpentChamberLevel here, instead calling the getLevelStatus function again? Same for next conditions check as well ( line:889)