Activity dd-firmware/firmware

Tree
Accordion

Stats

Commits this week: 32

Total Committers:	15
Last Commit:	02 Mar
Commits this week:	32

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Monday 02 Mar

1:13 pm

Michael Garthwaite

More
77d2a00
changed 1 file
LDT-3514-dialin-config, develop LEAHI-DD-FIRMWARE-LDT-3514-1

LDT-3514: wrapped ALARM_ID_FP_POWER_BUDGET_OUT_OF_RANGE around test config TEST_CONFIG_FP_DISABLE_RO_CURRENT_ALARM.

- -1
- +5
./App/Monitors/WaterQualityMonitor.c
- History
- Source
- Diff
./App/Monitors/WaterQualityMonitor.c

1:03 pm

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-3514-1
started review

LEAHI-DD-FIRMWARE-LDT-3514_Dialin config request to disable IOFP current monitoring

LEAHI-DD-FIRMWARE-LDT-3514_Dialin config request to disable IOFP current monitoring

12:57 pm

Michael Garthwaite

More
333baf3
changed 2 files
LDT-2004-v2-conductivity-sensors LEAHI-DD-FIRMWARE-LDT-2004-4

LDT-2004: warning reductions for teensy driver

- -2
- +4
./App/Drivers/ConductivitySensors.h
- History
- Source
- Diff
./App/Drivers/ConductivitySensors.h
- -109
- +5
./App/Drivers/ConductivityTeensy.c
- History
- Source
- Diff
./App/Drivers/ConductivityTeensy.c

11:40 am

Michael Garthwaite

added

added

11:40 am

Michael Garthwaite

added

added

11:40 am

Michael Garthwaite

More
3b97a99
changed 1 file
LDT-3372-v1-conductivity-fixes LEAHI-DD-FIRMWARE-LDT-3372-2

LDT-3372: code review comments.

- -13
- +10
./App/Drivers/ConductivityTeensy.c
- History
- Source
- Diff
./App/Drivers/ConductivityTeensy.c

11:40 am

Michael Garthwaite

fixed.

fixed.

11:39 am

Michael Garthwaite

then we return false as expected

then we return false as expected

11:33 am

Michael Garthwaite

These are correct variable names based on their coefficient names in calculations of conductivity.

These are correct variable names based on their coefficient names in calculations of conductivity.

11:31 am

Michael Garthwaite

Can you clarify? this is allowing us to switch conductivity calculations based on the needs of the dialin user. ( systems team testing for accuracy )

Can you clarify? this is allowing us to switch conductivity calculations based on the needs of the dialin user. ( systems team testing for accuracy )

11:30 am

Michael Garthwaite

removed. thanks!

removed. thanks!

11:30 am

Michael Garthwaite

parameter check happens in getTeensyCondId

parameter check happens in getTeensyCondId

11:25 am

Michael Garthwaite

Yes as it is a way for us to identify if the teensy is not responding to us correctly. This along with no LED activity on the board helps us identify teensy failures

Yes as it is a way for us to identify if the teensy is not responding to us correctly. This along with no LED activity on the board helps us identify teensy failures

11:24 am

Michael Garthwaite

Not for this situation since its an array of structs and looks like a 2d array. Please see static const FP_OP_MODE_T MODE_TRANSITION_TABLE in FPOperationModes.c static const DD_OP_MODE_T MODE_TRAN...

Not for this situation since its an array of structs and looks like a 2d array. Please see

static const FP_OP_MODE_T MODE_TRANSITION_TABLE in FPOperationModes.c
static const DD_OP_MODE_T MODE_TRANSITION_TABLE in OperationModes.c
static PI_CONTROLLER_T piControllers in PIControllers.c ( FWCommon repo )

11:17 am

Dara Navaei

More
50951be
changed 1 file
develop

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
./App/DDCommon.h
- History
- Source
- Diff
./App/DDCommon.h

11:15 am

Michael Garthwaite

More
37e25a9
changed 1 file
LDT-3372-v1-conductivity-fixes, develop LEAHI-DD-FIRMWARE-LDT-3372-2

LDT-3372: fixes to conductivity calculation.

- -5
- +5
./App/Drivers/ConductivityTeensy.c
- History
- Source
- Diff
./App/Drivers/ConductivityTeensy.c

9:58 am

Dara Navaei

More
24efc54
changed 1 file
develop

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

- -1
- +1
./App/DDCommon.h
- History
- Source
- Diff
./App/DDCommon.h

9:56 am

Vinayakam Mani

More
4aa373d
changed 1 file
develop

LDT-1477 merge into develop

- -4
- +20
./App/Controllers/BalancingChamber.c
- History
- Source
- Diff
./App/Controllers/BalancingChamber.c

9:52 am

Vinayakam Mani

More
f554e39
changed 2 files
LDT-1477-ultrafiltration---dd---04-dev--, develop LEAHI-DD-FIRMWARE-LDT-1477-1

LDT-1477 trimmer heater target update

- -4
- +20
./App/Controllers/BalancingChamber.c
- History
- Source
- Diff
./App/Controllers/BalancingChamber.c
- -2
- +16
./App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
./App/Modes/ModeGenDialysate.c

8:13 am

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

its unsigned integer , no need to check -ve value

its unsigned integer , no need to check -ve value

Friday 27 Feb

11:28 am

Vendor - TEL - Arpita Srivastava

More
c71a1a9
changed 9 files
LDT-1195-dd-is-balancing-chamber-switching LEAHI-DD-FIRMWARE-LDT-1195-2

LDT-1195: Updated balancing chamber switching request flags names and definitions.

- -89
- +62
./App/Controllers/BalancingChamber.c
- History
- Source
- Diff
./App/Controllers/BalancingChamber.c
- -3
- +2
./App/Controllers/BalancingChamber.h
- History
- Source
- Diff
./App/Controllers/BalancingChamber.h
- -0
- +2
./App/Modes/ModeFault.c
- History
- Source
- Diff
./App/Modes/ModeFault.c
- -17
- +22
./App/Modes/ModeGenDialysate.c
- History
- Source
- Diff
./App/Modes/ModeGenDialysate.c
- -0
- +2
./App/Modes/ModeInitPOST.c
- History
- Source
- Diff
./App/Modes/ModeInitPOST.c
- -1
- +2
./App/Modes/ModePostGenDialysate.c
- History
- Source
- Diff
./App/Modes/ModePostGenDialysate.c
- -1
- +2
./App/Modes/ModePreGenDialysate.c
- History
- Source
- Diff
./App/Modes/ModePreGenDialysate.c
- -0
- +2
./App/Modes/ModeService.c
- History
- Source
- Diff
./App/Modes/ModeService.c
- -5
- +10
./App/Modes/ModeStandby.c
- History
- Source
- Diff
./App/Modes/ModeStandby.c

7:36 am

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

is this function required?

is this function required?

7:32 am

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

remove all commented code

remove all commented code

7:31 am

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

good to have doxygen comments on right hand side

good to have doxygen comments on right hand side

7:26 am

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

what if user send -ve values ?

what if user send -ve values ?

7:24 am

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

Where is len used ?

Where is len used ?

7:08 am

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

its a public function , input parameter check required, apply to all public functions

its a public function , input parameter check required, apply to all public functions

7:07 am

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

need documentation for this two approach, what is the merits ? when to use it ?

need documentation for this two approach, what is the merits ? when to use it ?

7:06 am

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

need math formula as documentation

need math formula as documentation

7:00 am

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DD-FIRMWARE-LDT-3372-2
commented on review

Need mathematical formula as documentation and need to explain each term

Need mathematical formula as documentation and need to explain each term

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-03-03 05:02 -0800