DG.dil

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Can we get by with just 1 msg? Add doxygen comments.

Can we get by with just 1 msg? Add doxygen comments.

we need to take care of existing stack size while we merge the bootloader changes. the current stack size is 0x3400, not 0x4C00.

we need to take care of existing stack size while we merge the bootloader changes. the current stack size is 0x3400, not 0x4C00.

DEN-16204 updated the branch with the changes from staging

  1. … 6 more files in changeset.
DG-DEN-16204_UI FW Pure Water Mode Turning ON Intermittently P1 Staging
DG-DEN-16204_UI FW Pure Water Mode Turning ON Intermittently P1 Staging
DEN-16204 stack optimization

  1. … 3 more files in changeset.
DG-DEN-16204_UI FW Pure Water Mode Turning Intermittently Staging
DG-DEN-16204_UI FW Pure Water Mode Turning Intermittently Staging
Is bootloader going to use fwcommon code? Is #ifdef #else backwards?

Is bootloader going to use fwcommon code? Is #ifdef #else backwards?

Needed?

Needed?

This is not user code. Next regen will restore this code. Do we really need to disable ECC test code?

This is not user code. Next regen will restore this code. Do we really need to disable ECC test code?

This is not user code. Next regen will restore this code. Do we really need to remove this code?

This is not user code. Next regen will restore this code. Do we really need to remove this code?

What is this code doing? Why no comments? Is it necessary?

What is this code doing? Why no comments? Is it necessary?

#if 1 and #endif appear to be unnecessary. Remove.

#if 1 and #endif appear to be unnecessary. Remove.

Remove duplicate user code start comment.

Remove duplicate user code start comment.

This is not user code. Next regen will restore this code. Do we really need to disable ECC error handling?

This is not user code. Next regen will restore this code. Do we really need to disable ECC error handling?

This is not user code. Next regen will restore this code. Do we really need to disable this?

This is not user code. Next regen will restore this code. Do we really need to disable this?

Why one handler for 3 commands?

Why one handler for 3 commands?

Why aren't we calling the specific handlers for reboot and enter bootloader commands?

Why aren't we calling the specific handlers for reboot and enter bootloader commands?

DG-DEN-16565_SW Updater HD DG App Side Intake From Sunrise
DG-DEN-16565_SW Updater HD DG App Side Intake From Sunrise
RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH