dialin / tools

install_to_venv.sh

Clone Tools

Stats

Commits this week: 0
Total Committers: 2
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 06 Nov 2024
3:20 pm

Michael Garthwaite

3:19 pm

Michael Garthwaite

Monday 04 Nov 2024
10:29 am

Sean Nash

Saturday 02 Nov 2024
4:01 pm

Dara Navaei

DIALIN-DENBUG-280_Issues With HD Broadcast P1
DIALIN-DENBUG-280_Issues With HD Broadcast P1
Thursday 31 Oct 2024
11:03 am

Dara Navaei

11:03 am

Dara Navaei

11:02 am

Dara Navaei

DIALIN-DENBUG-280_Issues With HD Broadcast P1B
DIALIN-DENBUG-280_Issues With HD Broadcast P1B
Monday 01 Jul 2024
10:16 am

Michael Garthwaite

10:16 am

Michael Garthwaite

This CR should be closed due to bad branching. Should have been branched out of p1_staging.

This CR should be closed due to bad branching. Should have been branched out of p1_staging.

Wednesday 26 Jun 2024
12:01 pm

Dara Navaei

DIALIN-DIAL-299_Air Trap Observer NO Longer Pub P1
DIALIN-DIAL-299_Air Trap Observer NO Longer Pub P1
Friday 16 Oct 2020
2:42 pm

plucia  (deleted user)

2:41 pm

qnguyen  (deleted user) and Sean Nash

Wednesday 14 Oct 2020
5:26 pm

qnguyen  (deleted user)

RESOLVED.

RESOLVED.

4:22 pm

qnguyen  (deleted user)

RESOLVED.

RESOLVED.

4:22 pm

qnguyen  (deleted user)

RESOLVED.

RESOLVED.

4:07 pm

plucia  (deleted user)

The version of crucible we're using has an issue where duplicate files show in the file viewer on the left. If you look at the more recent hemodialysis_device.py file (see the files viewer on the ...

The version of crucible we're using has an issue where duplicate files show in the file viewer on the left.

If you look at the more recent hemodialysis_device.py file (see the files viewer on the left), this message id is removed: http://dvm-linux02:8060/cru/DIALIN-DEN-4856-1#CFR-19219

It is also removed from both msg_defs.py: http://dvm-linux02:8060/cru/DIALIN-DEN-4856-1#CFR-19027 and http://dvm-linux02:8060/cru/DIALIN-DEN-4856-1#CFR-19203

3:57 pm

plucia  (deleted user)

Done

Done

3:57 pm

plucia  (deleted user)

Yes, if it's already there no reason to remove it. I've added it back

Yes, if it's already there no reason to remove it. I've added it back

Monday 12 Oct 2020
9:18 am

qnguyen  (deleted user)

This message id is not being used.

This message id is not being used.

9:16 am

qnguyen  (deleted user)

The file should be renamed to match this.

The file should be renamed to match this.

9:13 am

qnguyen  (deleted user)

should we keep the copyright?

should we keep the copyright?

Wednesday 07 Oct 2020
11:54 am

plucia  (deleted user)

DIALIN-DEN-4856_Sprint_27
DIALIN-DEN-4856_Sprint_27
Wednesday 30 Sep 2020
1:34 pm

plucia  (deleted user)

1:34 pm

Sean Nash and Behrouz NematiPour

12:12 pm

Behrouz NematiPour

Good, So please consider cleaning up used libraries periodically. RESOLVED.

Good,
So please consider cleaning up used libraries periodically.

RESOLVED.

12:10 pm

Behrouz NematiPour

RESOLVED

RESOLVED

Wednesday 09 Sep 2020
11:07 am

plucia  (deleted user)

1 - pip uses requirements.txt to install dependencies. See tools/setup_environment.sh for more detail. 2 - What you're asking about is the offline install capability. I have created a ticket in Jir...

1 - pip uses requirements.txt to install dependencies. See tools/setup_environment.sh for more detail.
2 - What you're asking about is the offline install capability. I have created a ticket in Jira http://dvm-linux02:8080/browse/DIAL-34 to track this new feature request.
3 - The offline install capability addresses this situation, in the (very) unlikely event that pypi hosting can't be relied upon.
4 - No. My understanding is that we do not need to validate these libraries because Dialin is NPSW.
5 - It's fine to have all of these libraries. For example, some of them are dependencies of python-can. Periodically this requirements.txt will be cleaned if a library is no longer being used. For this change-set, I added flake8 so we can run static code analysis. Flake8 is installed along with its dependencies.

10:45 am

plucia  (deleted user)

I have updated it so it says Dialin now.

I have updated it so it says Dialin now.

Tuesday 08 Sep 2020
12:01 pm

Behrouz NematiPour

I have some questions regarding these libraries. 1 - What tool/code is checking for these requirements? 2 - What if the requirement is not met? (not a correct version or lib not exists) 3 - If the ...

I have some questions regarding these libraries.
1 - What tool/code is checking for these requirements?
2 - What if the requirement is not met? (not a correct version or lib not exists)
3 - If the lib does not exist is it going to be installed or thrown an error?
4 - Don't we need to validate all these libraries?
5 - What is our process of adding more libraries to the list? On the other way is it fine to have all these libs? are all of them being used?

11:52 am

Behrouz NematiPour

Why this code review starts with "UI_" it's all Dialin. Shouldn't it be started with Dialin?

Why this code review starts with "UI_" it's all Dialin.
Shouldn't it be started with Dialin?