leahi-common

Clone Tools

Stats

Commits this week: 9
Total Committers: 18
Last Commit: 12:46
Commits this week: 9

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 29 Jan
1:28 pm

Vendor - TEL - Varshini Nagabooshanam

LDT-1415-pressures-monitoring-td

Options
    • -2
    • +2
    /AlarmDefs.h
1:23 pm

Sean Nash

Add space between = and (F32)

Add space between = and (F32)

1:19 pm

Vendor - TEL - Varshini Nagabooshanam

Yes we need to add

Yes we need to add

1:19 pm

Sean Nash

Added param looks wrong.

Added param looks wrong.

1:17 pm

Sean Nash

Align | separators all the way to right end of these 2 rows.

Align | separators all the way to right end of these 2 rows.

1:06 pm

Sean Nash

I would make another local variable (BOOL) above and set it per trinary operation and then pass the BOOL to the function. I think we want to avoid complex logic or function calls as a function para...

I would make another local variable (BOOL) above and set it per trinary operation and then pass the BOOL to the function.
I think we want to avoid complex logic or function calls as a function parameter per our coding standards.

1:03 pm

Sean Nash

Remove blank line.

Remove blank line.

12:07 pm

Vendor - TEL - Varshini Nagabooshanam

No, by mistake I copy pasted the same

No, by mistake I copy pasted the same

12:06 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

12:06 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

12:06 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:05 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:05 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

12:05 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:04 pm

Vendor - TEL - Varshini Nagabooshanam

Sorry, Updated

Sorry, Updated

12:04 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

12:04 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

12:04 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

12:04 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

12:04 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

12:04 pm

Vendor - TEL - Jashwant Gantyada

removed

removed

12:03 pm

Vendor - TEL - Jashwant Gantyada

LDT-2749 addressed code review comments

Options
    • -1
    • +1
    /MsgDefs.h
12:02 pm

Vendor - TEL - Jashwant Gantyada

done

done

11:59 am

Vendor - TEL - Varshini Nagabooshanam

LDT-1415-pressures-monitoring-td

Options
    • -2
    • +2
    /AlarmDefs.h
11:02 am

Sean Nash

Not an override command. We want to update bubbleDetectionEnabled[] for the venous sensor (index 0) to the given T/F state.

Not an override command. We want to update bubbleDetectionEnabled[] for the venous sensor (index 0) to the given T/F state.

11:00 am

Sean Nash

MSG_ID_TD_ENABLE_VENOUS_BUBBLE_ALARM

MSG_ID_TD_ENABLE_VENOUS_BUBBLE_ALARM

10:58 am

Sean Nash

Check msg payload length, set result to TRUE and set enable only if length is correct.

Check msg payload length, set result to TRUE and set enable only if length is correct.

10:57 am

Vendor - TEL - Jashwant Gantyada

LDT-2749 added msg id for bubble enable

Options
    • -0
    • +1
    /MsgDefs.h
10:56 am

Sean Nash

Update function name to match actual name. Remove references to standby mode - function should work in any mode.

Update function name to match actual name. Remove references to standby mode - function should work in any mode.

10:56 am

Vendor - TEL - Varshini Nagabooshanam

LDT-1415-pressures-monitoring-td

Options
    • -4
    • +4
    /AlarmDefs.h