leahi-common

Clone Tools

Stats

Commits this week: 27
Total Committers: 16
Last Commit: 17:48
Commits this week: 27

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 13 Feb
5:08 pm

Vinayakam Mani

Can we check some persistence before declaring alarm?

Can we check some persistence before declaring alarm?

5:07 pm

Vinayakam Mani

recommend running the pump at few sample speeds and observe the measured feedback and fix the tolerance number.

recommend running the pump at few sample speeds and observe the measured feedback and fix the tolerance number.

4:46 pm

Vinayakam Mani

Rinse pump fault? do we have one? remove concentrate references, commented codes, empty lines.

Rinse pump fault? do we have one? remove concentrate references, commented codes, empty lines.

3:51 pm

Vendor - TEL - Sameer Poyil

No, Yes for lowering event. Fill event uses PWM 150 always irrespective of Qb and Venous pressure only lower event used equation based PWM and that is in the range of 60-250 , not default., based ...

No, Yes for lowering event.

Fill event uses PWM 150 always irrespective of Qb and Venous pressure
only lower event used equation based PWM and that is in the range of 60-250 , not default., based on venous pressure it changes

3:47 pm

Sean Nash

Looks like we are doing a lot of the dialysate temp control in Gen Dialysate mode. Do we not do any heating in PreGen mode? Even if all dialysate heating is done in this mode, should we consider cr...

Looks like we are doing a lot of the dialysate temp control in Gen Dialysate mode. Do we not do any heating in PreGen mode?
Even if all dialysate heating is done in this mode, should we consider creating a service controller (like BC controller) to manage this complex temperature control?

3:38 pm

Sean Nash

Resolve merge conflicts.

Resolve merge conflicts.

2:11 pm

Sean Nash

Do we ever want to use the default (250)? Do we always want to use this venous pressure based power level?

Do we ever want to use the default (250)? Do we always want to use this venous pressure based power level?

2:09 pm

Sean Nash

Why not for release?

Why not for release?

2:03 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:03 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:00 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:40 am

Vinayakam Mani

9:33 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-1903_Air Trap Level Control - TD - 04: DEV - Feature Implementation
Thursday 12 Feb
5:15 pm

Vendor - TEL - Jashwant Gantyada

5:09 pm

Vinayakam Mani

For B1.0/B1.9 - Where Diener silencer 2000 pumps, this macro needs to be enabled.

For B1.0/B1.9 - Where Diener silencer 2000 pumps, this macro needs to be enabled.

5:07 pm

Vinayakam Mani

There are recent changes done on FPGA register in staging for B1.0/B1.9. please merge the latest changes here.

There are recent changes done on FPGA register in staging for B1.0/B1.9. please merge the latest changes here.

4:57 pm

Sean Nash and Vendor - TEL - Sameer Poyil

4:56 pm

Vinayakam Mani

Add valve details per HDD (may be 2.0 valves. as we remove beta 1/1.9 in sometime)

Add valve details per HDD (may be 2.0 valves. as we remove beta 1/1.9 in sometime)

4:55 pm

Vinayakam Mani

add new valves.

add new valves.

4:53 pm

Vinayakam Mani

Can we follow the same terminology as DD, starting a variable with 'fpga...'. for all IOFP variables?

Can we follow the same terminology as DD, starting a variable with 'fpga...'. for all IOFP variables?

4:50 pm

Vinayakam Mani

typo - used.

typo - used.

4:46 pm

Vinayakam Mani

Add as HDF hallsensor. start the comment with capital letter R.

Add as HDF hallsensor. start the comment with capital letter R.

4:30 pm

Vinayakam Mani

#define 0U across the file.

#define 0U across the file.

4:18 pm

Vinayakam Mani

Instead of generic function, recommend adding a specific function something similar to "getACSwitchStatus' or 'getLeaskSensorStatus' and return the values ( ex: leak sensor Enum states?). Do we nee...

Instead of generic function, recommend adding a specific function something similar to "getACSwitchStatus' or 'getLeaskSensorStatus' and return the values ( ex: leak sensor Enum states?). Do we need to add the application code as well now, say if leak is found, trigger an alarm?

3:56 pm

Vinayakam Mani

either typecast pwmInCount as U08 while passing to FPGA or declare the variable size as U08 instead of U32.

either typecast pwmInCount as U08 while passing to FPGA or declare the variable size as U08 instead of U32.

3:50 pm

Vinayakam Mani

Add a variable to convert PWM count to target speed for monitor function.

Add a variable to convert PWM count to target speed for monitor function.

3:43 pm

Vinayakam Mani

Please add 'execRinsePumpMonitor' which checks the commanded vs measured speed tolerance check and trigger alarm if deviates beyond the limit. You may move this function into monitor.

Please add 'execRinsePumpMonitor' which checks the commanded vs measured speed tolerance check and trigger alarm if deviates beyond the limit. You may move this function into monitor.

3:11 pm

Vinayakam Mani

Use #define macros for magic numbers.

Use #define macros for magic numbers.

3:07 pm

Vendor - TEL - Jashwant Gantyada

It was typo. Updated it.

It was typo. Updated it.

3:02 pm

Sean Nash

This doesn't look right. Status = time?

This doesn't look right. Status = time?