leahi-common

Clone Tools

Stats

Commits this week: 34
Total Committers: 20
Last Commit: 17:11
Commits this week: 34

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
3 hrs ago

Vendor - TEL - Vijay Pamula

LDT-5472: Added Mesg Id to trigger Barcode Request through dialin

Options
    • -0
    • +1
    /MsgDefs.h
5 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Yes,

Yes,

5 hrs ago

Vendor - TEL - Varshini Nagabooshanam

In pre-treatment

In pre-treatment

5 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

5 hrs ago

Vendor - TEL - Varshini Nagabooshanam

Yes, fixed

Yes, fixed

7 hrs ago

Sean Nash

Add a command to turn air pump off here in this state (since we aren't doing that in transition anymore to prevent large pressure drop).

Add a command to turn air pump off here in this state (since we aren't doing that in transition anymore to prevent large pressure drop).

7 hrs ago

Sean Nash

Don't turn off air pump here - looks like we lose too much air pressure when we do that. Move this command to the stabilize state handler (I'll add a comment there).

Don't turn off air pump here - looks like we lose too much air pressure when we do that. Move this command to the stabilize state handler (I'll add a comment there).

8 hrs ago

Sean Nash

You removed it here, but where did it go? I expected to see it in next case below.

You removed it here, but where did it go? I expected to see it in next case below.

8 hrs ago

Vendor - TEL - Varshini Nagabooshanam

LDT-5613: Changes in Pressure self test

Options
    • -14
    • +14
    /TDDefs.h
9 hrs ago

Sean Nash

Align "="

Align "="

9 hrs ago

Sean Nash

Add comment to right.

Add comment to right.

10 hrs ago

Sean Nash

Better to say != TRUE here.

Better to say != TRUE here.

10 hrs ago

Sean Nash

Add TODO comment as to whether we should trigger an alarm/fault here.

Add TODO comment as to whether we should trigger an alarm/fault here.

10 hrs ago

Sean Nash

Add blank line after declaration. Fix indent.

Add blank line after declaration.
Fix indent.

10 hrs ago

Sean Nash

We can un-comment syringe pump stop now.

We can un-comment syringe pump stop now.

10 hrs ago

Sean Nash

I think this function should be private (called by public message handler).

I think this function should be private (called by public message handler).

10 hrs ago

Sean Nash

Should this be static (private)?

Should this be static (private)?

11 hrs ago

Sean Nash

Ok to reject for now (because we don't want TD to go to disinfection state while DD doesn't). Add TODO to handle other disinfection options when they are implemented.

Ok to reject for now (because we don't want TD to go to disinfection state while DD doesn't). Add TODO to handle other disinfection options when they are implemented.

11 hrs ago

Vendor - TEL - Suresh Dharnala

Added alarm for disinfect in progress

Options
    • -4
    • +4
    /AlarmDefs.h
    • -1
    • +1
    /MsgDefs.h
    • -1
    • +0
    /TDDefs.h
11 hrs ago

Sean Nash

Add a blank line between banner and comment.

Add a blank line between banner and comment.

11 hrs ago

Sean Nash

gen to post gen and post gen to standby are simple commands unlike the pre-gen and gen dialysate requests which have a bunch of parameters. I think we should keep the simple transition requests in ...

gen to post gen and post gen to standby are simple commands unlike the pre-gen and gen dialysate requests which have a bunch of parameters. I think we should keep the simple transition requests in this enum with the disinfection requests and eventually any other simple command requests.

11 hrs ago

Sean Nash

DD only needs a command to start a specific disinfection. This can be achieved with the one generic command message here.

DD only needs a command to start a specific disinfection. This can be achieved with the one generic command message here.

11 hrs ago

Sean Nash

I was thinking we would have a generic command message with a single enum for the command ID. This one message could handle many different commands including post get to standby command.

I was thinking we would have a generic command message with a single enum for the command ID. This one message could handle many different commands including post get to standby command.

Friday 21 Aug
6:02 pm

Vendor - TEL - Praneeth Bunne

LDT-3992: Merge latest staging & reolve merge conflicts

Options
    • -61
    • +58
    /AlarmDefs.h
    • -5
    • +9
    /DDDefs.h
    • -3
    • +10
    /MsgDefs.h
5:16 pm

Vendor - TEL - Jashwant Gantyada

merge conflicts resolved

Options
    • -55
    • +54
    /AlarmDefs.h
    • -5
    • +8
    /DDDefs.h
    • -3
    • +10
    /MsgDefs.h
    • -12
    • +8
    /TDDefs.h
4:32 pm

Vendor - TEL - Jashwant Gantyada

LDT-4024 added msg id's for broadcast

Options
    • -1
    • +3
    /MsgDefs.h
10:57 am

Vinayakam Mani

Please add another sub condition for now that sub mode is in DD_POST_GEN_DIALYSATE_STATE_COMPLETE. Make sure you transition substate from Post gen start state to complete state for now to wait for ...

Please add another sub condition for now that sub mode is in DD_POST_GEN_DIALYSATE_STATE_COMPLETE. Make sure you transition substate from Post gen start state to complete state for now to wait for this request.

10:57 am

Michael Garthwaite

for now, keep this only related for disinfection cmds. for Post gen and standby. Follow the similiar messaging like pre-gen and gen dialysate requests and the reply back. ( but one message/handler )

for now, keep this only related for disinfection cmds.

for Post gen and standby. Follow the similiar messaging like pre-gen and gen dialysate requests and the reply back. ( but one message/handler )

10:50 am

Vinayakam Mani

are we rejecting this request for Aug Month demo, I guess, you still need to accept these requests and set the corresponding pending DD disinfect request flags.

are we rejecting this request for Aug Month demo, I guess, you still need to accept these requests and set the corresponding pending DD disinfect request flags.

10:47 am

Michael Garthwaite

Do we have a MSG_ID for the selection of disinfection? If not, lets rename and repurpose this one.

Do we have a MSG_ID for the selection of disinfection? If not, lets rename and repurpose this one.