leahi-common

AlarmDefs.h

Clone Tools

Stats

Commits this week: 11
Total Committers: 17
Last Commit: 10:15
Commits this week: 11

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 07 Jul
11:42 am

Vendor - TEL - Praneeth Bunne

change accordingly

change accordingly

11:42 am

Vendor - TEL - Praneeth Bunne

Rename to AlarmTableResposnePayload

Rename to AlarmTableResposnePayload

Monday 06 Jul
1:56 pm

Sean Nash

1:07 pm

Sean Nash

I would keep blank line between library includes and regular includes.

I would keep blank line between library includes and regular includes.

1:05 pm

Sean Nash

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added. I think you should just remove this new alarm 196...

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

10:56 am

Vendor - TEL - Praneeth Bunne

10:10 am

Vinayakam Mani

Thursday 02 Jul
3:32 pm

Sean Nash

test instead of handle

test instead of handle

3:06 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

2:42 pm

Sean Nash

Align =

Align =

2:41 pm

Sean Nash

Should modality be an enum type?

Should modality be an enum type?

2:41 pm

Sean Nash

Align =

Align =

2:40 pm

Sean Nash

Should this be an enum type?

Should this be an enum type?

1:47 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4029_Pre-Treatment - FW Implementation - 4/6:
LEAHI-TD-FIRMWARE-LDT-4029_Pre-Treatment - FW Implementation - 4/6:
11:36 am

Sean Nash

You also need to add these to the ALARM_RANK_TABLE (the table sorted by rank).

You also need to add these to the ALARM_RANK_TABLE (the table sorted by rank).

Wednesday 01 Jul
6:34 pm

Sean Nash

Can we be a little more specific about what conductivity we are returning in these functions? And I think we should include constants in the Inputs section of function headers.

Can we be a little more specific about what conductivity we are returning in these functions?
And I think we should include constants in the Inputs section of function headers.

1:36 pm

Sean Nash

What is the 3rd modality?

What is the 3rd modality?

1:26 pm

Sean Nash

Return type should be an enum (TREATMENT_TYPE_T).

Return type should be an enum (TREATMENT_TYPE_T).

1:24 pm

Sean Nash

Return type should be an enum (FLUID_BOLUS_MEDIUM_T).

Return type should be an enum (FLUID_BOLUS_MEDIUM_T).

1:17 pm

Sean Nash

Move after Modes so they are alphabetized.

Move after Modes so they are alphabetized.

10:32 am

Vendor - TEL - Jashwant Gantyada

updated

updated

10:32 am

Vendor - TEL - Jashwant Gantyada

updated

updated

10:32 am

Vendor - TEL - Jashwant Gantyada

updated

updated

10:32 am

Vendor - TEL - Jashwant Gantyada

moved.

moved.

10:32 am

Vendor - TEL - Jashwant Gantyada

updated

updated

9:36 am

Sean Nash

Move below Messaging.h to keep list in alphabetical order.

Move below Messaging.h to keep list in alphabetical order.

Tuesday 30 Jun
5:09 pm

Vinayakam Mani

Same here. Let's use only D29.

Same here. Let's use only D29.

5:02 pm

Vinayakam Mani

Suppose to use D74, Instead of D17 (for Control only).

Suppose to use D74, Instead of D17 (for Control only).

4:48 pm

Vinayakam Mani

Move these functions to top area where all public functions defined. let's keep the static function after the public function.

Move these functions to top area where all public functions defined. let's keep the static function after the public function.

4:44 pm

Vinayakam Mani

Missing Comment.

Missing Comment.