leahi-common

MsgDefs.h

Clone Tools

Stats

Commits this week: 14
Total Committers: 16
Last Commit: 15:33
Commits this week: 14

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 14 Apr
5:28 pm

Sean Nash

So I think this compiler will give you 64 bit if you ask for long. Did you intend it to be 64 bit? If not, you can just use the BIT_BY_POS macro above.

So I think this compiler will give you 64 bit if you ask for long. Did you intend it to be 64 bit? If not, you can just use the BIT_BY_POS macro above.

4:11 pm

Vendor - TEL - Sameer Poyil

Removing it now. will introduce it later if required

Removing it now. will introduce it later if required

3:59 pm

Vendor - TEL - Sameer Poyil

will finalize it when ocean spray logic is tested

will finalize it when ocean spray logic is tested

3:57 pm

Vendor - TEL - Sameer Poyil

dryBicartState is top level state machine which is different data type. removed dryBicartSubstate

dryBicartState is top level state machine which is different data type. removed dryBicartSubstate

3:56 pm

Vendor - TEL - Sameer Poyil

removed

removed

3:52 pm

Vendor - TEL - Sameer Poyil

This is not extra blank line its a line for TASK_GENERAL_INTERVAL )

This is not extra blank line its a line for TASK_GENERAL_INTERVAL )

3:33 pm

Vendor - TEL - Sameer Poyil

a macro used to create a contiguous bitmask starting at bit position l (low) and ending at bit position h

a macro used to create a contiguous bitmask starting at bit position l (low) and ending at bit position h

3:30 pm

Vendor - TEL - Sameer Poyil

nr means short form of bit 'number', unsigned long is portable, 32bit for 32-bit cpu and 64 bits for 64bit cpu whereas unsigned int is always 32 bits regardless of architecture.

nr means short form of bit 'number', unsigned long is portable, 32bit for 32-bit cpu and 64 bits for 64bit cpu whereas unsigned int is always 32 bits regardless of architecture.

2:35 pm

Sean Nash

Remove this blank line.

Remove this blank line.

2:35 pm

Sean Nash

Put () around each of the 2 conditions being ANDed.

Put () around each of the 2 conditions being ANDed.

2:34 pm

Sean Nash

Remove blank line.

Remove blank line.

2:33 pm

Sean Nash

Remove blank line.

Remove blank line.

2:31 pm

Sean Nash

Add a blank line after declarations.

Add a blank line after declarations.

2:31 pm

Sean Nash

Remove blank line.

Remove blank line.

2:31 pm

Sean Nash

Should we remove this else if or is it going to be restored later?

Should we remove this else if or is it going to be restored later?

2:27 pm

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

2:26 pm

Sean Nash

Shouldn't we be assigning dryBicartState instead of dryBicartSubstate in all of these cases?

Shouldn't we be assigning dryBicartState instead of dryBicartSubstate in all of these cases?

2:26 pm

Sean Nash

Why do we need this?

Why do we need this?

2:24 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:23 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:19 pm

Sean Nash

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.

Not clear what GENMASK is doing. What do h and l refer to. This doesn't look like a simple bit mask.

2:16 pm

Sean Nash

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above. What does nr stand for?

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above.
What does nr stand for?

2:14 pm

Sean Nash

Let's remove this commented line.

Let's remove this commented line.

2:08 pm

Sean Nash

Add blank line before return.

Add blank line before return.

2:07 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

2:05 pm

Sean Nash

Why U32? Why not RECOVER_STATE_T?

Why U32? Why not RECOVER_STATE_T?

2:04 pm

Sean Nash

Lower case x

Lower case x

2:02 pm

Sean Nash

Is blood flow in need of a PID controller too?

Is blood flow in need of a PID controller too?

1:34 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

11:18 am

Vendor - TEL - Sameer Poyil

I don't need to edit this file. I will check with Dara to exclude this file from code review.

I don't need to edit this file. I will check with Dara to exclude this file from code review.