leahi-common

MsgDefs.h

Clone Tools

Stats

Commits this week: 29
Total Committers: 18
Last Commit: 31 Jul
Commits this week: 29

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 28 Jul
10:19 am

Vendor - TEL - Arpita Srivastava

Delete this row.

Delete this row.

9:52 am

Vendor - TEL - Arpita Srivastava

should we replace current Pre-Treatment state with currentPreTreatmentState?

should we replace current Pre-Treatment state with currentPreTreatmentState?

9:51 am

Vendor - TEL - Arpita Srivastava

Add @Message

Add @Message

9:46 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

9:46 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

Monday 27 Jul
5:09 pm

Vinayakam Mani

the function call seems returning U16. Type cast to U32.

the function call seems returning U16. Type cast to U32.

11:21 am

Vendor - TEL - Arpita Srivastava

Added but crucible is not showing this change. Please check bitbucket.

Added but crucible is not showing this change. Please check bitbucket.

11:17 am

Vendor - TEL - Arpita Srivastava

These variables are correctly initialized to the first enum in the list.

These variables are correctly initialized to the first enum in the list.

11:16 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

11:16 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:15 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:14 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

10:26 am

Sean Nash

Why is this on a separate line? Move after = above.

Why is this on a separate line? Move after = above.

10:22 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

10:22 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

10:01 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4031_Pre-Treatment - FW Implementation - 6/6:
LEAHI-TD-FIRMWARE-LDT-4031_Pre-Treatment - FW Implementation - 6/6:
Sunday 26 Jul
8:37 pm

Sean Nash

Should this be the "Load Syringe" alarm that you just added?

Should this be the "Load Syringe" alarm that you just added?

Friday 24 Jul
4:37 pm

Sean Nash

Can't return in middle of function code.

Can't return in middle of function code.

4:29 pm

Sean Nash

Remove else and reject command in it and re-test.

Remove else and reject command in it and re-test.

Thursday 23 Jul
11:48 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

11:48 am

Vendor - TEL - Arpita Srivastava

recircPublishTimerCtr is an output

recircPublishTimerCtr is an output

11:46 am

Vendor - TEL - Arpita Srivastava

Add @message MSG_ID_TD_RECIRCULATE_RESPONSE

Add @message MSG_ID_TD_RECIRCULATE_RESPONSE

11:44 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

11:40 am

Vendor - TEL - Arpita Srivastava

Initialization missing for the following variables in the init function. startRecircRequested reconnectRequested backToTreatmentRequested resumeRecircRequested

Initialization missing for the following variables in the init function.

startRecircRequested
reconnectRequested
backToTreatmentRequested
resumeRecircRequested

11:32 am

Vendor - TEL - Praneeth Bunne

All signal flags are initialized in resetSignalFlags() which we are calling below

All signal flags are initialized in resetSignalFlags() which we are calling below

11:23 am

Vendor - TEL - Arpita Srivastava

please update the alarm id reservation sheet.

please update the alarm id reservation sheet.

11:22 am

Dara Navaei

Same question as above: should we alarm if the retries failed?

Same question as above: should we alarm if the retries failed?

11:20 am

Vendor - TEL - Arpita Srivastava

Why is MSG_ID_DD_SUBSTITUTION_PUMP_DATA commented out? Line 214 and 215 are using tabs instead of whitespace characters because of which the alignment is off.

Why is MSG_ID_DD_SUBSTITUTION_PUMP_DATA commented out?
Line 214 and 215 are using tabs instead of whitespace characters because of which the alignment is off.

11:15 am

Vendor - TEL - Arpita Srivastava

break this line : one variable per line will be easy to read.

break this line : one variable per line will be easy to read.

11:13 am

Vendor - TEL - Arpita Srivastava

StateTxRecirc should be above StateTxRinseback

StateTxRecirc should be above StateTxRinseback