leahi-dialin / leahi_dialin / dd / modules

piston_pump.py

Clone Tools

Stats

Commits this week: 0
Total Committers: 2
Last Commit: 11 Dec
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 09 Dec
2:27 pm

Sean Nash

Why do we have an "ro" and an "fp" folder? Is "ro" folder obsolete (replaced by "fp")?

Why do we have an "ro" and an "fp" folder? Is "ro" folder obsolete (replaced by "fp")?

2:18 pm

Sean Nash

Isn't timestamp typically first (or last) in publish list?

Isn't timestamp typically first (or last) in publish list?

Monday 08 Dec
8:15 am

Dara Navaei

LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module
LEAHI-DIALIN-LDT-2655_Cannot override conductivity sensor temperature from the conductivity module
Friday 17 Oct
10:17 am

jpaguio  (deleted user)

8:48 am

Sean Nash

Thursday 16 Oct
5:18 pm

Vinayakam Mani and Michael Garthwaite

4:53 pm

jpaguio  (deleted user)

done - as part of this comment, the piston pump module was deleted

done - as part of this comment, the piston pump module was deleted

4:52 pm

jpaguio  (deleted user)

done

done

4:52 pm

jpaguio  (deleted user)

done

done

4:46 pm

Jonny Paguio <jpaguio@diality.com>

LDT-2352: Addressed code review comments

Options
    • -207
    • +0
    ./piston_pump.py
  2. … 4 more files in changeset.
3:24 pm

Vinayakam Mani

This message ID (0xF0) is no longer valid? and remove empty spaces.

This message ID (0xF0) is no longer valid? and remove empty spaces.

3:21 pm

Vinayakam Mani

Update the comments = Valve 7, D26.

Update the comments = Valve 7, D26.

3:21 pm

Vinayakam Mani

Update the comments - Valve 4, D21

Update the comments - Valve 4, D21

Tuesday 14 Oct
2:52 pm

jpaguio  (deleted user)

Monday 29 Sep
2:43 pm

Jonny Paguio <jpaguio@diality.com>

Merged LDT-1196

Options
    • -1
    • +1
    ./piston_pump.py
  2. … 4 more files in changeset.
Thursday 25 Sep
3:05 pm

Jonny Paguio <jpaguio@diality.com>

Merged LDT-1196

Options
    • -1
    • +1
    ./piston_pump.py
  2. … 8 more files in changeset.
2:42 pm

jpaguio  (deleted user)

2:35 pm

Dara Navaei and Sean Nash

12:57 pm

Jonny Paguio <jpaguio@diality.com>

LDT-2300: Resolved code review comments

Options
    • -1
    • +1
    ./piston_pump.py
  2. … 40 more files in changeset.
12:16 pm

jpaguio  (deleted user)

Done - timestamps added to DD, FP, and TD

Done - timestamps added to DD, FP, and TD

12:13 pm

jpaguio  (deleted user)

Done

Done

12:12 pm

jpaguio  (deleted user)

Done

Done

12:11 pm

jpaguio  (deleted user)

Done

Done

Tuesday 23 Sep
6:01 pm

Dara Navaei

LEAHI-DIALIN-LDT-2352_Dialin: Update enumerations to match merged DD and FP
LEAHI-DIALIN-LDT-2352_Dialin: Update enumerations to match merged DD and FP
Monday 22 Sep
2:26 pm

jpaguio  (deleted user)

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only...

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only one "variable" is being published. The same goes for the other publish functions before each handler. I will reorganize the order of the published variables so that timestamp is listed last.

9:48 am

Sean Nash

No timestamp?

No timestamp?

9:45 am

Sean Nash

I didn't see dbg variables in the publish list above.

I didn't see dbg variables in the publish list above.

9:44 am

Sean Nash

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere. Also, I think we typically list the timestamp ...

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere.
Also, I think we typically list the timestamp last.

9:41 am

Sean Nash

Replace "dg" with "dd".

Replace "dg" with "dd".

9:38 am

Sean Nash

Replace "hd" with "dd".

Replace "hd" with "dd".