Activity leahi-dialin/leahi_dialin/fp/modules/alarms.py

2:42 pm

jpaguio (deleted user)

2:35 pm

Dara Navaei and Sean Nash

More
LEAHI-DIALIN-LDT-2300-1
finished reviewing

12:16 pm

jpaguio (deleted user)

Done - timestamps added to DD, FP, and TD

12:13 pm

jpaguio (deleted user)

Done

12:12 pm

jpaguio (deleted user)

Done

12:11 pm

jpaguio (deleted user)

Done

2:26 pm

jpaguio (deleted user)

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only...

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only one "variable" is being published. The same goes for the other publish functions before each handler. I will reorganize the order of the published variables so that timestamp is listed last.

9:48 am

Sean Nash

More
Re: LEAHI-DIALIN-LDT-2300-1
commented on review

No timestamp?

9:45 am

Sean Nash

More
Re: LEAHI-DIALIN-LDT-2300-1
commented on review

I didn't see dbg variables in the publish list above.

9:44 am

Sean Nash

More
Re: LEAHI-DIALIN-LDT-2300-1
commented on review

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere. Also, I think we typically list the timestamp ...

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere.
Also, I think we typically list the timestamp last.

9:41 am