leahi-dialin / leahi_dialin / fp / modules

ro_pump.py

Clone Tools

Stats

Commits this week: 0
Total Committers: 2
Last Commit: 11 Dec
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 Sep
2:42 pm

jpaguio  (deleted user)

2:35 pm

Dara Navaei and Sean Nash

12:57 pm

Jonny Paguio <jpaguio@diality.com>

LDT-2300: Resolved code review comments

Options
    • -1
    • +1
    ./ro_pump.py
  2. … 40 more files in changeset.
12:16 pm

jpaguio  (deleted user)

Done - timestamps added to DD, FP, and TD

Done - timestamps added to DD, FP, and TD

12:13 pm

jpaguio  (deleted user)

Done

Done

12:12 pm

jpaguio  (deleted user)

Done

Done

12:11 pm

jpaguio  (deleted user)

Done

Done

Monday 22 Sep
2:26 pm

jpaguio  (deleted user)

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only...

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only one "variable" is being published. The same goes for the other publish functions before each handler. I will reorganize the order of the published variables so that timestamp is listed last.

9:48 am

Sean Nash

No timestamp?

No timestamp?

9:45 am

Sean Nash

I didn't see dbg variables in the publish list above.

I didn't see dbg variables in the publish list above.

9:44 am

Sean Nash

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere. Also, I think we typically list the timestamp ...

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere.
Also, I think we typically list the timestamp last.

9:41 am

Sean Nash

Replace "dg" with "dd".

Replace "dg" with "dd".

9:38 am

Sean Nash

Replace "hd" with "dd".

Replace "hd" with "dd".

Monday 15 Sep
4:49 pm

Jonny Paguio <jpaguio@diality.com>

LDT-2300: Added message ID to each observer

Options
    • -3
    • +3
    ./ro_pump.py
  2. … 40 more files in changeset.
4:03 pm

Dara Navaei

LEAHI-DIALIN-LDT-2300_Dialin: Add a way for a Dialin user to identify what broadcast message is being received
LEAHI-DIALIN-LDT-2300_Dialin: Add a way for a Dialin user to identify what broadcast message is being received
Thursday 21 Aug
4:36 pm

jpaguio  (deleted user)

2:30 pm

Michael Garthwaite and Vinayakam Mani

2:04 pm

Dara Navaei

LEAHI-DIALIN-LDT-2070_Leahi Dialin Move Dictionary EN
LEAHI-DIALIN-LDT-2070_Leahi Dialin Move Dictionary EN
Monday 18 Aug
5:21 pm

Jonny Paguio <jpaguio@diality.com>

LDT-2070: Updated DD, FP, and TD modules

Options
    • -19
    • +19
    ./ro_pump.py
  2. … 14 more files in changeset.
Friday 15 Aug
5:21 pm

Jonny Paguio <jpaguio@diality.com>

LDT-2070: Updated DD, FP, TD sensor and valve modules to use enumerated classes

Options
    • -21
    • +26
    ./ro_pump.py
  2. … 18 more files in changeset.
Tuesday 05 Aug
1:05 pm

Michael Garthwaite

12:50 pm

Sean Nash and Vinayakam Mani

Monday 04 Aug
9:21 am

Michael Garthwaite

LDT-566: code review comments.

Options
    • -4
    • +0
    ./ro_pump.py
  2. … 2 more files in changeset.
Friday 01 Aug
3:47 pm

Sean Nash

Why so much white space?

Why so much white space?

3:44 pm

Sean Nash

???

???

3:40 pm

Sean Nash

Where is 0x5B?

Where is 0x5B?

Thursday 17 Jul
12:59 pm

Michael Garthwaite

LDT-566

LDT-566: implemented alarm triggered handling for fp and dd. Added documentation for ro pump and boost pump control loops

Options
    • -4
    • +4
    ./ro_pump.py
  2. … 7 more files in changeset.
Wednesday 16 Jul
11:53 am

Michael Garthwaite

LDT-611, LDT-1198, LDT-594, LDT-609 fixes.

Options
    • -1
    • +9
    ./ro_pump.py
  2. … 3 more files in changeset.
Tuesday 15 Jul
4:27 pm

Michael Garthwaite

WIP on develop

LDT-566: implemented ro and boost pump hard stop commands

Options
    • -0
    • +27
    ./ro_pump.py
  2. … 2 more files in changeset.
1:11 pm

Michael Garthwaite

LDT-556: created boost pump and ro pump modules. Updated naming to across modules from RO to FP. Moved older denali tests to a depreciated tests. Created a thread-based diagnostic logger for fp

Options
    • -0
    • +242
    ./ro_pump.py
  2. … 90 more files in changeset.