ro_pump.py

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-2300: Resolved code review comments

  1. … 40 more files in changeset.
Done - timestamps added to DD, FP, and TD

Done - timestamps added to DD, FP, and TD

Done

Done

Done

Done

Done

Done

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only...

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only one "variable" is being published. The same goes for the other publish functions before each handler. I will reorganize the order of the published variables so that timestamp is listed last.

No timestamp?

No timestamp?

I didn't see dbg variables in the publish list above.

I didn't see dbg variables in the publish list above.

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere. Also, I think we typically list the timestamp ...

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere.
Also, I think we typically list the timestamp last.

Replace "dg" with "dd".

Replace "dg" with "dd".

Replace "hd" with "dd".

Replace "hd" with "dd".

LDT-2300: Added message ID to each observer

  1. … 40 more files in changeset.
LEAHI-DIALIN-LDT-2300_Dialin: Add a way for a Dialin user to identify what broadcast message is being received
LEAHI-DIALIN-LDT-2300_Dialin: Add a way for a Dialin user to identify what broadcast message is being received
LEAHI-DIALIN-LDT-2070_Leahi Dialin Move Dictionary EN
LEAHI-DIALIN-LDT-2070_Leahi Dialin Move Dictionary EN
LDT-2070: Updated DD, FP, and TD modules

  1. … 14 more files in changeset.
LDT-2070: Updated DD, FP, TD sensor and valve modules to use enumerated classes

  1. … 18 more files in changeset.
LDT-566: code review comments.

  1. … 2 more files in changeset.
Why so much white space?

Why so much white space?

???

???

Where is 0x5B?

Where is 0x5B?

LDT-566

LDT-566: implemented alarm triggered handling for fp and dd. Added documentation for ro pump and boost pump control loops

  1. … 7 more files in changeset.
LDT-611, LDT-1198, LDT-594, LDT-609 fixes.

  1. … 3 more files in changeset.
WIP on develop

LDT-566: implemented ro and boost pump hard stop commands

  1. … 2 more files in changeset.
LDT-556: created boost pump and ro pump modules. Updated naming to across modules from RO to FP. Moved older denali tests to a depreciated tests. Created a thread-based diagnostic logger for fp

  1. … 90 more files in changeset.