leahi-fwcommon

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'LDT-2004-v2-conductivity-sensors' into staging

FALSE?

FALSE?

if fresh and spent pressure is not met after certain time, we should trigger an alarm and not to stuck in this state forever.

if fresh and spent pressure is not met after certain time, we should trigger an alarm and not to stuck in this state forever.

are we using this variable, if not, can we remove across the file?

are we using this variable, if not, can we remove across the file?

Add comment

Add comment

Remove the unused macros.

Remove the unused macros.

fixed.

fixed.

added.

added.

deleted

deleted

done.

done.

done.

done.

changed and updated all the other places.

changed and updated all the other places.

changed.

changed.

handled accordingly.

handled accordingly.

done

done

done

done

done

done

done.

done.

LDT-3103 addressed code review comments and changes

I don't see a TODO. If we intend to uncomment this line out later, we should add a TODO comment to the right as a reminder. If we do not intend to uncomment this later, we should just delete it.

I don't see a TODO. If we intend to uncomment this line out later, we should add a TODO comment to the right as a reminder. If we do not intend to uncomment this later, we should just delete it.

Fix alignment of "=".

Fix alignment of "=".

Add a param line in this header.

Add a param line in this header.

Can we delete this commented out line?

Can we delete this commented out line?

Add a params line in function header.

Add a params line in function header.

Why did we change this spelling? Now it's wrong.

Why did we change this spelling? Now it's wrong.

Can we delete this commented out line?

Can we delete this commented out line?

Keep this blank line.

Keep this blank line.

Should be before ModeStandby.

Should be before ModeStandby.

I see we are doing this same logic in multiple places. Can we just have a function that returns the minimum speed for the given dialysate pump?

I see we are doing this same logic in multiple places. Can we just have a function that returns the minimum speed for the given dialysate pump?

Remove blank line.

Remove blank line.