leahi-fwcommon

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

Why do some functions take sensor as a U32 and some as a CONDUCTIVITY_SENSORS_T? The latter seems appropriate.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Add blank line before return.

Add blank line before return.

Add blank line before return.

Add blank line before return.

Remove blank line.

Remove blank line.

From what I see in UI, it is just a range value not an enum/index

From what I see in UI, it is just a range value not an enum/index

Is it an enum/index like Denali then?

Is it an enum/index like Denali then?

No we are not getting conv factor from UI on it I will have to confirm with Nick to see if we will get the bicarbConvFactor

No we are not getting conv factor from UI on it
I will have to confirm with Nick to see if we will get the bicarbConvFactor

Align comments.

Align comments.

Can we just remove this?

Can we just remove this?

Can we just remove this?

Can we just remove this?

F suffix.

F suffix.

Is bicarbonate also a conversion factor?

Is bicarbonate also a conversion factor?

Can we just remove the old enum now?

Can we just remove the old enum now?

Not sure these min/max are right here either.

Not sure these min/max are right here either.

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?

Remove extra blank lines.

Remove extra blank lines.

LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation
LEAHI-TD-FIRMWARE-LDT-473_Treatment Parameters (Create Rx) - TD - 04: DEV - Feature Implementation
Done.

Done.

Done

Done

Done.

Done.

Same comment.

Same comment.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.