Activity leahi-fwcommon/

1:55 pm

Raghu Kallala

More
1273b99
changed 0 files
develop

LDT-4188 merge to develop

1:41 pm

What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert ...

What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert to L/hr every time it needs to send UI a message. Either way works for me.

12:21 pm

Raghu Kallala

Changed to U32

12:21 pm

Raghu Kallala

we are sending a message ack as response in the handler of this message request

12:20 pm

Raghu Kallala

More
119dba2
changed 1 file
LDT-4000-hdf-fw-implementation-1-4, LDT-4188-sw-fw-integration-to-run-a-trea, develop LEAHI-DD-FIRMWARE-LDT-4000-1 LEAHI-TD-FIRMWARE-LDT-4188-1

LDT-4188 added dialysate delivery msg payload

- -0
- +9
/MessagePayloads.h
- History
- Source
- Diff
/MessagePayloads.h

11:53 am

Raghu Kallala

Other existing set functions in TD is using UF in liter and rate in L/hr Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

Other existing set functions in TD is using UF in liter and rate in L/hr

Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

11:21 am

Michael Garthwaite and Vinayakam Mani

More
LEAHI-TD-FIRMWARE-LDT-4188-1
joined review

11:19 am

Vendor - TEL - Jashwant Gantyada

More
895ecce
changed 1 file
develop

Merge branch 'feature/LDT-3963-dialysate-flow-rate---fw-implem' into develop

- -1
- +1
/PIControllers.c
- History
- Source
- Diff
/PIControllers.c

11:10 am

Sean Nash

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When se...

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When sending UF rate to UI, we would convert back to L/hr first, but everywhere else we would work with mL/min.

11:01 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4188-1
commented on review

Remove extra blank line.

11:00 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4188-1
commented on review

Remove extra space before function name.

11:00 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4188-1
commented on review

This is not a Dialin message, so move up above all of these "test" functions.

10:59 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-4188-1
commented on review

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate dox...

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate doxygen group.

10:46 am