leahi-fwcommon

Clone Tools

Stats

Commits this week: 20
Total Committers: 13
Last Commit: 30 Apr
Commits this week: 20

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Apr
8:49 pm

Michael Garthwaite

Merge branch 'LDT-4000-hdf-fw-implementation-1-4' into develop

Options
    • -1
    • +1
    /TestSupport.h
8:49 pm

Michael Garthwaite

LDT-4000: changed beta 2.0 test config to beta 1.9 test config

Options
    • -4
    • +4
    /TestSupport.c
    • -1
    • +1
    /TestSupport.h
8:25 pm

Michael Garthwaite

Merge branch 'LDT-4000-hdf-fw-implementation-1-4' into develop

Options
8:25 pm

Michael Garthwaite

LDT-4000: reverted test config changes.

Options
    • -2
    • +2
    /TestSupport.c
    • -1
    • +1
    /TestSupport.h
7:26 pm

Michael Garthwaite

Merge branch 'LDT-4188-sw-fw-integration-to-run-a-trea' into LDT-4000-hdf-fw-implementation-1-4

Options
6:16 pm

Michael Garthwaite

LDT-4000: flipped test config for beta 1.9 and 2.0s

Options
    • -4
    • +4
    /TestSupport.c
    • -1
    • +1
    /TestSupport.h
5:55 pm

Michael Garthwaite

4:50 pm

Michael Garthwaite

Merge branch 'staging' into LDT-4000-hdf-fw-implementation-1-4

Options
2:10 pm

Raghu Kallala

LDT-4188 resolved merge conflicts

Options
    • -9
    • +0
    /MessagePayloads.h
1:55 pm

Raghu Kallala

LDT-4188 merge to develop

Options
1:41 pm

Sean Nash

What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert ...

What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert to L/hr every time it needs to send UI a message. Either way works for me.

12:21 pm

Raghu Kallala

Changed to U32

Changed to U32

12:21 pm

Raghu Kallala

we are sending a message ack as response in the handler of this message request

we are sending a message ack as response in the handler of this message request

12:20 pm

Raghu Kallala

LDT-4188 added dialysate delivery msg payload

Options
    • -0
    • +9
    /MessagePayloads.h
11:53 am

Raghu Kallala

Other existing set functions in TD is using UF in liter and rate in L/hr Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

Other existing set functions in TD is using UF in liter and rate in L/hr

Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

11:21 am

Michael Garthwaite and Vinayakam Mani

11:19 am

Vendor - TEL - Jashwant Gantyada

Merge branch 'feature/LDT-3963-dialysate-flow-rate---fw-implem' into develop

Options
    • -1
    • +1
    /PIControllers.c
11:10 am

Sean Nash

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When se...

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When sending UF rate to UI, we would convert back to L/hr first, but everywhere else we would work with mL/min.

11:01 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

11:00 am

Sean Nash

Remove extra space before function name.

Remove extra space before function name.

11:00 am

Sean Nash

This is not a Dialin message, so move up above all of these "test" functions.

This is not a Dialin message, so move up above all of these "test" functions.

10:59 am

Sean Nash

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate dox...

Why is this in TDCommon? It should probably be in MessagePayloads.h or DDDefs.h so both DD and TD f/w can share this payload structure. And the common definitions should be added to appropriate doxygen group.

10:46 am

Vendor - TEL - Jashwant Gantyada

Merge branch 'develop' of bitbucket.org:diality-cloud/leahi-fwcommon into develop

Options
10:45 am

Vendor - TEL - Jashwant Gantyada

LDT-3963 enabled fault mode tranisiton for switching off hetares for dilaysate flow rate testing

Options
    • -1
    • +1
    /PIControllers.c
9:55 am

Vinayakam Mani

Do we have a return confirmation that the command is accepted by DD?

Do we have a return confirmation that the command is accepted by DD?

9:45 am

Vinayakam Mani

Is the UF rate unit in ml/min (instead of hr.)?

Is the UF rate unit in ml/min (instead of hr.)?

9:36 am

Vinayakam Mani

Are we assuming the sub mode return is pre-gen sub mode always?

Are we assuming the sub mode return is pre-gen sub mode always?

8:41 am

Michael Garthwaite

create the getDialGoodToDeliverStatus() function and have that return true rather than have the assignment here

create the getDialGoodToDeliverStatus() function and have that return true rather than have the assignment here

8:37 am

Michael Garthwaite

comment still needed?

comment still needed?

Wednesday 29 Apr
2:01 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI
LEAHI-TD-FIRMWARE-LDT-4188_SW/FW integration to run a Treatment from UI