leahi-fwcommon

Clone Tools

Stats

Commits this week: 12
Total Committers: 15
Last Commit: 17 Jul
Commits this week: 12

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 29 May
12:09 pm

Vinayakam Mani

LDT-3958 resolving merge issues

Options
    • -0
    • +1
    /PIControllers.c
    • -0
    • +1
    /PIControllers.h
11:48 am

Michael Garthwaite

LDT-4001: updates to dialysate request message payload.

Options
    • -0
    • +1
    /MessagePayloads.h
11:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
10:58 am

Vinayakam Mani

Done.

Done.

10:07 am

Vendor - TEL - Jashwant Gantyada

10:06 am

Vendor - TEL - Jashwant Gantyada

I think we also need this to be uncommented, as we were running into an alarm because of this.

I think we also need this to be uncommented, as we were running into an alarm because of this.

9:56 am

Sean Nash

How can settings be pending when you set that flag to TRUE in the code below this? And why would we want to use uf volume setting in the else part of this ternary?

How can settings be pending when you set that flag to TRUE in the code below this? And why would we want to use uf volume setting in the else part of this ternary?

9:52 am

Sean Nash

else reason is Invalid Request Format

else reason is Invalid Request Format

9:47 am

Sean Nash

Should check if iso UF volume + UF volume < max. And if user can do multiple iso uf sessions, you would check iso UF volume + any previous iso UF volume + UF volume. I don't know if there is a mini...

Should check if iso UF volume + UF volume < max. And if user can do multiple iso uf sessions, you would check iso UF volume + any previous iso UF volume + UF volume.
I don't know if there is a minimum iso UF volume.

9:45 am

Sean Nash

Looking for "less than current" only makes sense if user can do multiple iso UF sessions in a treatment. And if that's the case, we should be looking at how much time we've already spent doing iso ...

Looking for "less than current" only makes sense if user can do multiple iso UF sessions in a treatment. And if that's the case, we should be looking at how much time we've already spent doing iso UF instead of how much time we've spent in the HD or HDF treatment.

9:43 am

Vinayakam Mani

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

9:41 am

Vinayakam Mani

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

9:41 am

Vinayakam Mani

as discussed, these were outcome of the test results. we will review these gains with latest controller.

as discussed, these were outcome of the test results. we will review these gains with latest controller.

9:40 am

Vinayakam Mani

Done.

Done.

9:40 am

Sean Nash

I think we have to check whether the iso uf duration + treatment duration does not exceed maximum treatment duration. And I'm not sure if there is a minimum duration for iso uf, but if there is a m...

I think we have to check whether the iso uf duration + treatment duration does not exceed maximum treatment duration.
And I'm not sure if there is a minimum duration for iso uf, but if there is a minimum, it probably isn't the same as the minimum treatment duration.

9:40 am

Vinayakam Mani

Done.

Done.

9:37 am

Sean Nash

Just add this as an AND condition in the if statement above.

Just add this as an AND condition in the if statement above.

9:33 am

Sean Nash

If we are in treatment end state, the treatment is completed (no need to check that) and I don't think iso UF is a modality.

If we are in treatment end state, the treatment is completed (no need to check that) and I don't think iso UF is a modality.

9:31 am

Sean Nash

Do we need this? Check with Raghu. I don't think iso UF is a modality (at least not yet).

Do we need this? Check with Raghu. I don't think iso UF is a modality (at least not yet).

9:19 am

Sean Nash

Align all or none of the =

Align all or none of the =

9:14 am

Sean Nash

I don't think iso uf is considered a modality - at least not in phase 1 of development.

I don't think iso uf is considered a modality - at least not in phase 1 of development.

Thursday 28 May
10:43 pm

Sean Nash

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

10:33 pm

Sean Nash

Can we restore the real code here yet? Ask Dara.

Can we restore the real code here yet? Ask Dara.

4:55 pm

Sean Nash

Why isn't this TRUE == ?

Why isn't this TRUE == ?

4:45 pm

Vinayakam Mani

LDT-3958 latest from staging

Options
    • -3
    • +3
    /PIControllers.c
    • -2
    • +2
    /PIControllers.h
1:47 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-TD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
1:46 pm

Sean Nash

LDT_3975: add PID for blood pump controller.

Options
    • -0
    • +3
    /PIDControllers.h
1:37 pm

Sean Nash

LDT-3975: refactored PID controller.

Options
    • -59
    • +40
    /PIDControllers.c
    • -2
    • +1
    /PIDControllers.h
Wednesday 27 May
7:58 pm

Vendor - TEL - Praneeth Bunne

LDT-4103: Update code related to fluid bolus

Options
    • -17
    • +7
    /AlarmMgmt.c
    • -1
    • +1
    /AlarmMgmt.h
4:24 pm

Dara Navaei