leahi-fwcommon

Clone Tools

Stats

Commits this week: 20
Total Committers: 16
Last Commit: 29 Jul
Commits this week: 20

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 29 Jul
1:22 pm

Sean Nash

10:55 am

Vendor - TEL - Suresh Dharnala

Fixed.

Fixed.

10:54 am

Vendor - TEL - Suresh Dharnala

Moved.

Moved.

10:53 am

Sean Nash

Move buttons down just above "Comm.h". And why is buttons being included here?

Move buttons down just above "Comm.h". And why is buttons being included here?

10:53 am

Vendor - TEL - Suresh Dharnala

This reason code is not used anywhere, and the existing REQUEST_REJECT_REASON_NOT_ALLOWED_IN_CURRENT_MODE can be used if a rejection response is needed. I removed the new reason code.

This reason code is not used anywhere, and the existing REQUEST_REJECT_REASON_NOT_ALLOWED_IN_CURRENT_MODE can be used if a rejection response is needed. I removed the new reason code.

10:50 am

Sean Nash

I don't see it.

I don't see it.

10:50 am

Sean Nash

I don't see it.

I don't see it.

10:43 am

Sean Nash

I would think reason code 1 would work for this - do we really need to add this one?

I would think reason code 1 would work for this - do we really need to add this one?

10:42 am

Sean Nash

Fix this.

Fix this.

Tuesday 28 Jul
12:57 pm

Vendor - TEL - Suresh Dharnala

Updated as suggested by removing the unnecessary else block and reject command. Retested the power-off confirmation and shutdown flow successfully.

Updated as suggested by removing the unnecessary else block and reject command. Retested the power-off confirmation and shutdown flow successfully.

12:56 pm

Vendor - TEL - Suresh Dharnala

Updated to remove the return from the middle of the function. The function now sets newID and returns only once at the end. Retested successfully.

Updated to remove the return from the middle of the function. The function now sets newID and returns only once at the end. Retested successfully.

10:19 am

Vendor - TEL - Jashwant Gantyada

renamed. thanks!

renamed. thanks!

10:18 am

Vendor - TEL - Jashwant Gantyada

renamed

renamed

10:18 am

Vendor - TEL - Jashwant Gantyada

updated to not have it update always

updated to not have it update always

10:17 am

Vendor - TEL - Jashwant Gantyada

updated with latest staging implementation.

updated with latest staging implementation.

Monday 27 Jul
11:21 am

Vendor - TEL - Arpita Srivastava

Added but crucible is not showing this change. Please check bitbucket.

Added but crucible is not showing this change. Please check bitbucket.

11:17 am

Vendor - TEL - Arpita Srivastava

These variables are correctly initialized to the first enum in the list.

These variables are correctly initialized to the first enum in the list.

11:16 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

11:16 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:15 am

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

11:14 am

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

10:14 am

Sean Nash

What is happening here? Not clear if we need cartridge param. Let's remove it for now.

What is happening here? Not clear if we need cartridge param. Let's remove it for now.

10:07 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

10:07 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

10:06 am

Sean Nash

Comment these out again.

Comment these out again.

10:06 am

Sean Nash

Move this to right before syringe pump controller below. Add comment "Execute pinch valve command state machine."

Move this to right before syringe pump controller below. Add comment "Execute pinch valve command state machine."

10:05 am

Sean Nash

Move this to right after valves controller exec below.

Move this to right after valves controller exec below.

10:04 am

Sean Nash

Restore this.

Restore this.

10:03 am

Sean Nash

Restore this.

Restore this.

9:56 am

Sean Nash

uncomment this line.

uncomment this line.